Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4186425ybl; Mon, 9 Dec 2019 06:51:21 -0800 (PST) X-Google-Smtp-Source: APXvYqxFNObo4FeiCSMnFgZ2HpwR2CElHv9PJmSzyZrb1UzEKs0AMHDzDDPd9J66WOTIqXzFewoM X-Received: by 2002:a9d:6005:: with SMTP id h5mr23005003otj.153.1575903081361; Mon, 09 Dec 2019 06:51:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575903081; cv=none; d=google.com; s=arc-20160816; b=tAMx11MDB0aolidaniJJ2wKhVHieCtGRgnxt8L8tbQtm0oHx5i4AgTIgbIVkniuYb2 2AejjM5ZJla1fFwcy9nyjKk+BTEHKOmdk/MqOKwL6HKy6xIBx+lYQOkvZj63cyS/LHyk liy8E6xKpn++Jd9wUxBwQ6H6dugYzkv7DweVuLJfqddDxLWWjolH1MaMC3q3dsMRRDWT czg4WyZQ4ftbIbXuWbMtBuo4E1DlVmL0bqijNUzwkwwtZVnlZYatSuUIPie2kbCoCheW PsmD5lMR5UtGSk7VBmSo2GrB5rxI4yBvijNmghVMA3FF4EjVwTWtUVxFq1+5YeZSYnro vqbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=0HvN+3e+7om8qumnXzunxi56S61TczW41AS4hCzUgbE=; b=OFTvWpXh/fErvUHPF/SlziW5kHkOmmdDmHBmPC9um8wop+deuZWJ9KkD0vqsO2Ed7B kKzrNF/i/Q+yaHydbb/OOyhs+OFLZHKCin3qZOh5QF0Ev5oy6WMakpRLxFkuyAvtwlHy XzJ5pOw3wiEsw342wiBcpDLGF0tatLIUj8hUGCKMlVVZwW7IyQAaakE1iyQlggrfRiMV 4JoKqkDlEe8PYLPXQ2U7NxL0f5ZXgTYJQt6soJO++90g9e3GogcMU5E90vUO/RFLJ656 G+nG24TOzkwgMMqsgXWZYbHZzRYrYMEvDr/XWei+2KDNwauJYCl5hIu3OvIQWfEd3X7F LDpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=XlwlAish; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r26si11638340otc.163.2019.12.09.06.51.09; Mon, 09 Dec 2019 06:51:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=XlwlAish; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727742AbfLIOsF (ORCPT + 99 others); Mon, 9 Dec 2019 09:48:05 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:42058 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727568AbfLIOsF (ORCPT ); Mon, 9 Dec 2019 09:48:05 -0500 Received: by mail-lj1-f196.google.com with SMTP id e28so15922871ljo.9 for ; Mon, 09 Dec 2019 06:48:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0HvN+3e+7om8qumnXzunxi56S61TczW41AS4hCzUgbE=; b=XlwlAisha/IQ7vS/gPNErAprRksj1pwwuHY/qJSvFrQftdWih8AAn/4LDfkagAGmLA sZR6bvN2z4ljSMIpTJi/Il6SofvgqRgEX78t/iRPfj2M2D+ks0ropUWEp3cqkqLB+Et2 sSqnzNYvkMhxhSpfXfdpygzs7CQVB0+tm1fxM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0HvN+3e+7om8qumnXzunxi56S61TczW41AS4hCzUgbE=; b=MsXID8qSm60x1M9vN/xSaj8CdpzbxCIpmOC+qEklIkeVvVJSYLZXOgH/3NVQQLoO6H xUTh8AGsWi+SGUMtLqiGqYCAp0mT6JYUss4w+100ltHetu7jT9CRoMtNM6u+swTxLS+X s5e6Np4avnbXDy1w5qdLndRW4c21h+ufhPy3pJwqd+DQUwfpC04OmsU6nUUH8/irCUWa 35jtTHoJ9sz9OL3m5w3GJ6ZIu95A7jl4eQT3Caq0DIya4dTPbMFPSeVcemAS2LaFjuqi wUrl2JffmF4V4lFLcIHP3n4KiJ1rIgHGv8wVHCwmuwZQjMYjzExwHUmmIDiQ7VNifNIa gofg== X-Gm-Message-State: APjAAAXMn5qqPOt2XIyb2c+Q44Ey0SqIKPwW9/KSNfir7mmVRB+E5Y3l DTJDc6ALHXKG9p6jTFmjgrxEnnHsicQH0LyF X-Received: by 2002:a2e:9b95:: with SMTP id z21mr14634556lji.112.1575902882749; Mon, 09 Dec 2019 06:48:02 -0800 (PST) Received: from [172.16.11.28] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id h24sm21816ljl.80.2019.12.09.06.48.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Dec 2019 06:48:01 -0800 (PST) Subject: Re: [PATCH] mmc: sdhci-of-esdhc: Revert "mmc: sdhci-of-esdhc: add erratum A-009204 support" To: Adrian Hunter , Ulf Hansson Cc: Yinbo Zhu , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191204085447.27491-1-linux@rasmusvillemoes.dk> From: Rasmus Villemoes Message-ID: <4d61ffef-f325-e1f9-7d02-d546f2f3d2cb@rasmusvillemoes.dk> Date: Mon, 9 Dec 2019 15:48:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191204085447.27491-1-linux@rasmusvillemoes.dk> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping, any comments on this revert? On 04/12/2019 09.54, Rasmus Villemoes wrote: > This reverts commit 5dd195522562542bc6ebe6e7bd47890d8b7ca93c. > > First, the fix seems to be plain wrong, since the erratum suggests > waiting 5ms before setting setting SYSCTL[RSTD], but this msleep() > happens after the call of sdhci_reset() which is where that bit gets > set (if SDHCI_RESET_DATA is in mask).