Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   philip@warpmail.net (Philip K.)
To:     Denis Efremov <efremov@linux.com>
Cc:     moritzm.mueller@posteo.de, linux-kernel@vger.kernel.org,
        linux-block@vger.kernel.org, linux-kernel@i4.cs.fau.de
Subject: Re: [PATCH] floppy: hide invalid floppy disk types
References: <20191208194534.32270-1-moritzm.mueller@posteo.de>
        <d3f0613c-6c3a-8efc-1c27-a6b75c34972f@gmail.com> <87h82ajzqd.fsf@bulbul>
        <04f0dfb9-d25a-d9a3-74cd-538165a8bfa2@linux.com>
Date:   Mon, 09 Dec 2019 18:30:18 +0100
In-Reply-To: <04f0dfb9-d25a-d9a3-74cd-538165a8bfa2@linux.com> (Denis Efremov's
        message of "Mon, 9 Dec 2019 20:04:32 +0300")
Message-ID: <878snle79x.fsf@bulbul>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


> Hmm, I would say that driver blacklisting is a more proper solution in
> this case. I doubt there are people with this issue and real floppy drives
> in their setup. Altering the default driver's initialization scheme seems
> superfluous to me.

As long as major distributions like Ubuntu ship the floppy module, there
are enough people who could be affected by this peculiar behaviour.
While I agree that blacklisting the module would be more elegant, I
still think that a patch that goes in this direction could help more
people, especially those who don't want or cannot solve kernel-related
issues.

> This will force users (if there are ones) who depends on this behavior
> to rebuild the kernel. blacklisting doesn't require kernel rebuild.

Are there floppy disks of unknown types? Our patch is intentionally
conservative: We won't hide false negatives. If the motherboard reports
an non-existent disk

If you're ready to think about it, we could consider extending the patch
to un-register the device if it can recognise that it's (probably) not
real. In our case, for example, fdisk reported that fd0 had a size of
4k, something think is a strong indicator that something's not right.

Alternatively, we could look into what the comment

	/* FIXME: additional physical CMOS drive detection should go here */

would imply. This particular bug can only affect fd0 and fd1, so if we
spent some more time, we could find something.

=2D-=20
	With kind regards,
	Philip K.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEXEVvqaSeWykH0GvsTLppj2Aa7OEFAl3uhKoACgkQTLppj2Aa
7OF9pAgAqWP2tVIcoQy/Ulcz7yj53sm5Owk+EhQWE3AvheRX6y0GKgoISKw3PDHG
D+EluFH2strIYikcsEkWzvEGNnafcvHhfT+qNVwg5uj5aN2MfaMHHBzkHsgYYV1n
AIYU62vaY2Wvrh2QxGEojUNL8YHBHWLihVxmUPVzztP8KJ7MnPhYhJDi9jZwPZzM
bsZzavZL/E8YS4FprpXJ2bLMMHgdn/uG2M0VXQ4ZWowtqKv4Md5wwILpukA0JdpD
C8UzNE49oFIGb/WHGLj/fZCM002in9hcsTOBVM5Cl20KbHGUU0M2+S1R3gu0cLR0
spfepi0i9PEPa6b/KB8mmltBvuCQ/A==
=bMz4
-----END PGP SIGNATURE-----
--=-=-=--