Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Leo Li <leoyang.li@nxp.com>
To:     Michael Walle <michael@walle.cc>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>
Subject: RE: [PATCH v2] arm64: dts: ls1028a: fix reboot node
Thread-Topic: [PATCH v2] arm64: dts: ls1028a: fix reboot node
Thread-Index: AQHVrsESw4ah5znw0UmG0v9WXCnxKKeyNhjA
Date:   Mon, 9 Dec 2019 19:50:40 +0000
Message-ID: <VE1PR04MB6687035009C691D31844C51D8F580@VE1PR04MB6687.eurprd04.prod.outlook.com>
References: <20191209184644.14057-1-michael@walle.cc>
In-Reply-To: <20191209184644.14057-1-michael@walle.cc>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ce08cba7-a2af-4def-7b48-08d77ce111f3
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2019 19:50:40.5830
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uk5sKrQqzteuRlDg0QAtG48JrNrfAcqQJqEVw6f8xCF+HcSFq1z1/LgXvObiwrOkEupuGivffiCF41JjCTX3eA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6445
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Michael Walle <michael@walle.cc>
> Sent: Monday, December 9, 2019 12:47 PM
> To: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; lin=
ux-
> kernel@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; Rob
> Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>;
> Michael Walle <michael@walle.cc>
> Subject: [PATCH v2] arm64: dts: ls1028a: fix reboot node
>=20
> The reboot register isn't located inside the DCFG controller, but in its =
own RST
> controller. Fix it.
>=20
> Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
> Signed-off-by: Michael Walle <michael@walle.cc>

Acked-by: Li Yang <leoyang.li@nxp.com>

> ---
>=20
> changes since v1:
>  - add fixes tag
>  - remove "ls1028a-rst" compatible string, because there is no actual
>    driver for it. It just use the syscon driver.
>=20
>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>=20
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 8b28fda2ca20..7825550b7cef 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -88,7 +88,7 @@
>=20
>  	reboot {
>  		compatible =3D"syscon-reboot";
> -		regmap =3D <&dcfg>;
> +		regmap =3D <&rst>;
>  		offset =3D <0xb0>;
>  		mask =3D <0x02>;
>  	};
> @@ -178,6 +178,12 @@
>  			little-endian;
>  		};
>=20
> +		rst: syscon@1e60000 {
> +			compatible =3D "syscon";
> +			reg =3D <0x0 0x1e60000 0x0 0x10000>;
> +			little-endian;
> +		};
> +
>  		scfg: syscon@1fc0000 {
>  			compatible =3D "fsl,ls1028a-scfg", "syscon";
>  			reg =3D <0x0 0x1fc0000 0x0 0x10000>;
> --
> 2.20.1