Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 9 Dec 2019 21:42:48 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To:     Stefan Berger <stefanb@linux.ibm.com>,
        Stefan Berger <stefanb@linux.vnet.ibm.com>,
        linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org, linux-security-module@vger.kernel.org
Subject: Re: [PATCH 0/2] Revert patches fixing probing of interrupts
Message-ID: <20191209194248.GC19243@linux.intel.com>
References: <20191126131753.3424363-1-stefanb@linux.vnet.ibm.com>
 <20191129223418.GA15726@linux.intel.com>
 <6f6f60a2-3b55-e76d-c11a-4677fcb72c16@linux.ibm.com>
 <20191202185520.57w2h3dgs5q7lhob@cantor>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191202185520.57w2h3dgs5q7lhob@cantor>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Dec 02, 2019 at 11:55:20AM -0700, Jerry Snitselaar wrote:
> On Sun Dec 01 19, Stefan Berger wrote:
> > On 11/29/19 5:37 PM, Jarkko Sakkinen wrote:
> > > On Tue, Nov 26, 2019 at 08:17:51AM -0500, Stefan Berger wrote:
> > > > From: Stefan Berger <stefanb@linux.ibm.com>
> > > > 
> > > > Revert the patches that were fixing the probing of interrupts due
> > > > to reports of interrupt stroms on some systems
> > > Can you explain how reverting is going to fix the issue?
> > 
> > 
> > The reverts fix 'the interrupt storm issue' that they are causing on
> > some systems but don't fix the issue with the interrupt mode not being
> > used. I was hoping Jerry would get access to a system faster but this
> > didn't seem to be the case. So sending these patches seemed the better
> > solution than leaving 5.4.x with the problem but going back to when it
> > worked 'better.'
> > 
> 
> I finally heard back from IT support, and unfortunately they don't
> have any T490s systems to give out on temp loan. So I can only send
> patched kernels to the end user that had the problem.

At least it is a fact that tpm_chip_stop() is called too early and that
is destined to cause issues.

Should I bake a patch or do you have already something?

/Jarkko