Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191209085747.16057-1-hslester96@gmail.com>
In-Reply-To: <20191209085747.16057-1-hslester96@gmail.com>
From:   Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Date:   Mon, 9 Dec 2019 21:35:26 +0100
Message-ID: <CAMeQTsbHFjRpi1HrzsV36vkM5MmU_wi2fLiy+TSkgNCb3wdAwA@mail.gmail.com>
Subject: Re: [PATCH] drm/gma500: add a missed gma_power_end in error path
To:     Chuhong Yuan <hslester96@gmail.com>
Cc:     David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Dec 9, 2019 at 9:57 AM Chuhong Yuan <hslester96@gmail.com> wrote:
>
> oaktrail_lvds_mode_set() misses a gma_power_end() in an error path.
> Add the call to fix it.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>

Hi Chuhong, thanks for the patch.

Applied to drm-misc-next

-Patrik

> ---
>  drivers/gpu/drm/gma500/oaktrail_lvds.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/gma500/oaktrail_lvds.c b/drivers/gpu/drm/gma500/oaktrail_lvds.c
> index 7390403ea1b7..582e09597500 100644
> --- a/drivers/gpu/drm/gma500/oaktrail_lvds.c
> +++ b/drivers/gpu/drm/gma500/oaktrail_lvds.c
> @@ -117,6 +117,7 @@ static void oaktrail_lvds_mode_set(struct drm_encoder *encoder,
>
>         if (!connector) {
>                 DRM_ERROR("Couldn't find connector when setting mode");
> +               gma_power_end(dev);
>                 return;
>         }
>
> --
> 2.24.0
>