Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4609973ybl; Mon, 9 Dec 2019 13:54:33 -0800 (PST) X-Google-Smtp-Source: APXvYqzzoP3TLGx6immDS2QXUFn6mJuYPXEd7NPl5wh/SM3SPrYZoW9Is8VrN1WWhrOmWUURyTie X-Received: by 2002:aca:fdd7:: with SMTP id b206mr1131167oii.35.1575928473244; Mon, 09 Dec 2019 13:54:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575928473; cv=none; d=google.com; s=arc-20160816; b=iu5kZvwBLsu8BuUWpW1GRdFPxn+f8GUvU+Opkg2qMcTQqXqr0cLv0r0lcTGIS7ZSfi I/84LAJOzHYmHy/F042B6aJXe2nhF8d8L5ELXh/DxPo2gL6TEomYZI33vZzW2A/cUtJJ m7ipwwZ+TAu99cJBNXoFSLSgaMK+ZCBOUF1e5i0c8iOwO/qkQs29mKxgIMmr8ide0+8m g9pWo1ijRt1lg7Ft5BJgbjP8j16/gINFKrPK1vZ87Jk/ynstxh0xAj4T8ltCEI6of5kh ZwuGwhLQwFSnq5WtTEB+NK7ylNRtzqafn0Uj6o7xczeNKS4W94X4wLQwhe6diFH9epst 5nLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=FhsD4XoraOrhcYU/bmdtm44QDUDPKPQnbWRVNcj/Pdw=; b=C/B8gFHE8evklkJqDG/BYpixhv9nOkXaqMYfiaoZoMv9oq1/YM+zmvr/bfWJP6DSJa p0L34KexDrPFtyhqLxZk428ZoGOJ8mB7gQokBWBqXE4ShdEw1qcNitIWrwYj31OVE+mn EIZz3qrUboM+FaCZh53Eyux/ttMsfEpD4EjNlzL7ZvNHqnFXtzF4amu0aPM4dWD1ZZS0 QIsTMR7eJe0dKp7GQOLxMJIBrR6+ripxl3DJt3TPNzMo1eMSRA6GA/vqOLOhxZniCedv NrLUMXOVfMcBCsbYVa/RA8WjrwBUJNERBVXzq9r5tMBH08PHLlsJd90bwU7kFpr7NIoC G6Jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=plzq5Hfx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j26si649118otk.291.2019.12.09.13.54.20; Mon, 09 Dec 2019 13:54:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=plzq5Hfx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726958AbfLIVw3 (ORCPT + 99 others); Mon, 9 Dec 2019 16:52:29 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:39775 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726230AbfLIVw2 (ORCPT ); Mon, 9 Dec 2019 16:52:28 -0500 Received: by mail-wm1-f65.google.com with SMTP id s14so927007wmh.4 for ; Mon, 09 Dec 2019 13:52:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FhsD4XoraOrhcYU/bmdtm44QDUDPKPQnbWRVNcj/Pdw=; b=plzq5HfxDYgsXkKks69lSVb87yXZcc+LP3zeyOWaTML+CBz5kI3xgDicZhmUusmvel AI0QyiJCGj2PBkyana9/jxKAp/5rPwkTsUXwCanmkIEEGisSD694ul6cvhBCaOFV+aGR WKoF0tUw5Cmb9OHB6TSsBvRHcGftHn1ITnnbh64/y5y6DZNzHQW6sdI+sp/zk7yPFD9+ BCxneGqB05jT2K9DHDIeITH+9eQthGT5BGnyFCw+y18krFNzPPH486yQXVpUL6/U8mM0 EMyZybof3qOwy060Z58GZJWK0QXlAUc1n5/ZcmVJ5TCJ+4Cz7aCbXoEBc074apNSryjM kszQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FhsD4XoraOrhcYU/bmdtm44QDUDPKPQnbWRVNcj/Pdw=; b=GLLFMuVdWy0/lfvDXlO6ba5jw0PJz9nEPL8cwpG6PiQxW5R6jeAI99Su6zYM2mAVaS +KpEzPZmpD0frGzzA8nGxiODGQg6a5jx6LhZDiuKClmHT46MLH8AkVuKAK2/uPsH12/K tzVMtMOkvdeIbvXYrN+G8/vwwz1FL/J1dOJrqSp69N1Pnm50QunsamJmVI7WeSVkQzeh CB8STEly79bWETjGMJkBsOnqzWMZsiEjzALPpYnRtePgp8B/DvCH+bYAY5i89RT70o/u x24xKSG1FIRwSQQPOrpAliT6k9+jSqEVhn2jM02aKSuY0S1z95P4wwEkSBAUD3ZzdzPq 7Ipg== X-Gm-Message-State: APjAAAVKqdAkHBLzGAFDLcsW8OOGZnFDa1S7XlA7fU7IavDPVaSIxHnl gPgfsNR1g1gvCElpiEW0594= X-Received: by 2002:a1c:638a:: with SMTP id x132mr1306927wmb.43.1575928346943; Mon, 09 Dec 2019 13:52:26 -0800 (PST) Received: from localhost.localdomain ([2a02:a03f:40f6:4600:a51f:44c:fbfb:c44]) by smtp.gmail.com with ESMTPSA id 16sm788661wmi.0.2019.12.09.13.52.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2019 13:52:26 -0800 (PST) From: Luc Van Oostenryck To: Kent Overstreet Cc: Andrew Morton , linux-kernel@vger.kernel.org, Luc Van Oostenryck Subject: [PATCH] lib/generic-radix-tree.c: remove unneeded __rcu Date: Mon, 9 Dec 2019 22:50:20 +0100 Message-Id: <20191209215020.58281-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org struct __genradix is defined as having its member 'root' annotated as __rcu. But in the corresponding API RCU is not used. Sparse reports this type mismatch as: lib/generic-radix-tree.c:56:35: warning: incorrect type in initializer (different address spaces) lib/generic-radix-tree.c:56:35: expected struct genradix_root *r lib/generic-radix-tree.c:56:35: got struct genradix_root [noderef] *__val with 6 other ones. So, correct root's type by removing this unneeded __rcu. Signed-off-by: Luc Van Oostenryck --- include/linux/generic-radix-tree.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/generic-radix-tree.h b/include/linux/generic-radix-tree.h index 02393c0c98f9..bfd00320c7f3 100644 --- a/include/linux/generic-radix-tree.h +++ b/include/linux/generic-radix-tree.h @@ -44,7 +44,7 @@ struct genradix_root; struct __genradix { - struct genradix_root __rcu *root; + struct genradix_root *root; }; /* -- 2.24.0