Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4687918ybl; Mon, 9 Dec 2019 15:10:34 -0800 (PST) X-Google-Smtp-Source: APXvYqworle4eANLWONRl4777k1l5E/diQkCZLN1hWKrccT3UzVjoLyrjyWVtTnyjzOo2bVCOKtX X-Received: by 2002:aca:54cc:: with SMTP id i195mr1392681oib.126.1575933034430; Mon, 09 Dec 2019 15:10:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575933034; cv=none; d=google.com; s=arc-20160816; b=0HYh6VhTa5WuoTTrv2uvc/nYPBKduXXuwnEedXRTRYzF+AN2VZqQOaWrngailpRO7y /99wSF4j3fZsuyifAgfOUVNY3QDDKcsy+mH9jbxR8+wLt0rFItsFcXnDcpYJwhj1cp0W Gxsa5LRAvR39ZlD/suj/Wi5SAPp8Gr01S6WJQvO/ZjlQS4I6YmBNZN0nW9N2iQsImxSp N3cb4SzCbFIVqmz3Ffux94ZKrvtaXlVHFX5vFDpk03+CxmagXXjuPJ4M0yMUxUP0shDv qxMtYxxFInLqJyb0AqPboOXUn86V++PNJUtzT+kKOukbYYU36YEC1DoNIuDUJTA8208D 3RpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=8tjmVSeobmMgjonTroVTxesPehyw5ZOz2eTvOwDYaIQ=; b=ZaUNp5IhpKIlRCqpDwLmt0irEPOBjDoR+cW7t7sd0ybwiDInmMLJBIX0JYFWwozJEA z4h5ctN7tHkdQ4lozCoxbREoVXhLfSGnbwmwBKP5HoiVD4xa39CalLypa17O3K+ijyY1 AFCOykb0orv6dmFSRk/o8sa4nZmTmjd48PNqT6gNr1hXoV+C6SYSY6Al2rFqc6bxWZZz cRuEcgPFXVmkrJnLofL/bYdrzPQGXrca0qsw9LXu+6/WQ5Wq+PSIo1OxYUgiy73JQ9UE yojliviJuOYNztm4UbR78A8Nq3aPEGO9sQSNU6k10U42r/hDCbzXhxNXV6iqvrkQ6LuJ JTJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=ix9Owl8+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y11si807532oiy.210.2019.12.09.15.10.21; Mon, 09 Dec 2019 15:10:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=ix9Owl8+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727178AbfLIXJp (ORCPT + 99 others); Mon, 9 Dec 2019 18:09:45 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:57608 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726362AbfLIXJo (ORCPT ); Mon, 9 Dec 2019 18:09:44 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xB9N9IsW005786; Mon, 9 Dec 2019 23:09:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=8tjmVSeobmMgjonTroVTxesPehyw5ZOz2eTvOwDYaIQ=; b=ix9Owl8+yPjzAGYtgiSvAz7bur2EksS6KCkJK+yiT7g30omzAp4kJB9zYMiNgCGBol3F RpK4m1aTD2Bomv5Gsf6DAIyDn3wXF4WGMMqHo8/BGtELAs9k6I1guYykAyRrkb9IBbkQ JyX0EG99XuKVAVpIX2BwX2h4CjIJJ0+lRw/HabBZ0r4e7bqshoT/Zq/1o+nrwUqnJGi+ v9gdWc/IIPBGUAXC6txEisif3dvvTS2PoeddspJ2sfFVO7DYyh7V9Rezep0DgrVUIUw1 6EEFlplXPfTUVbL2qOgHJfxzsYrh3tzEHx15eKLpd+xc68CqMEhmilmDNrPC9Nlu6JDf 0A== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2wrw4myj5m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 09 Dec 2019 23:09:33 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xB9N9NP7149624; Mon, 9 Dec 2019 23:09:32 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 2wsru81vt3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 09 Dec 2019 23:09:30 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xB9N9AaX015611; Mon, 9 Dec 2019 23:09:11 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 09 Dec 2019 15:09:10 -0800 To: "wubo \(T\)" Cc: "james.smart\@broadcom.com" , "dick.kennedy\@broadcom.com" , "jejb\@linux.vnet.ibm.com" , "martin.petersen\@oracle.com" , "linux-scsi\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" , "liuzhiqiang \(I\)" , Mingfangsen Subject: Re: [PATCH] scsi:lpfc:Fix memory leak on lpfc_bsg_write_ebuf_set func From: "Martin K. Petersen" Organization: Oracle Corporation References: Date: Mon, 09 Dec 2019 18:09:08 -0500 In-Reply-To: (wubo's message of "Sat, 7 Dec 2019 03:22:46 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9466 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912090182 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9466 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912090182 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org wubo, > When phba->mbox_ext_buf_ctx.seqNum != phba->mbox_ext_buf_ctx.numBuf, > dd_data should be freed before return SLI_CONFIG_HANDLED. > > When lpfc_sli_issue_mbox func return fails, pmboxq should be also > freed in job_error tag. Applied to 5.5/scsi-fixes. Please make sure your Author: string matches your Signed-off-by:. Also, please use checkpatch! -- Martin K. Petersen Oracle Linux Engineering