Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <c64e986c976b6b647b86c1243d356a8b78483c36.camel@sipsolutions.net>
Subject: Re: [PATCH net-next 1/5] rtnetlink: provide permanent hardware
 address in RTM_NEWLINK
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Michal Kubecek <mkubecek@suse.cz>,
        David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Cc:     Jakub Kicinski <jakub.kicinski@netronome.com>,
        Jiri Pirko <jiri@resnulli.us>, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        John Linville <linville@tuxdriver.com>,
        Stephen Hemminger <stephen@networkplumber.org>,
        linux-kernel@vger.kernel.org
Date:   Tue, 10 Dec 2019 00:21:33 +0100
In-Reply-To: <54d6f040b283ad19e739d3b5a05d249285231c54.camel@sipsolutions.net>
References: <cover.1575920565.git.mkubecek@suse.cz>
         <0f4b780d5dd38109768d863781b0ce6de9ef4fbb.1575920565.git.mkubecek@suse.cz>
         <54d6f040b283ad19e739d3b5a05d249285231c54.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2019-12-10 at 00:20 +0100, Johannes Berg wrote:
> On Mon, 2019-12-09 at 20:55 +0100, Michal Kubecek wrote:
> > +	if (memchr_inv(dev->perm_addr, '\0', dev->addr_len) &&
> 
> Why not simply !is_zero_ether_addr()?

Ugh, sorry, ignore me. I need to go sleep instead of looking at patches.

johannes