Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4746710ybl; Mon, 9 Dec 2019 16:08:41 -0800 (PST) X-Google-Smtp-Source: APXvYqxfU3RUIHiqgIB6BzblsnSQBsyUAXOjIXhQ6GAcyn0Fn+hOTXBVKwq4pjFh7Qkqai07B8iF X-Received: by 2002:aca:728c:: with SMTP id p134mr1740578oic.176.1575936521745; Mon, 09 Dec 2019 16:08:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575936521; cv=none; d=google.com; s=arc-20160816; b=v/oZ9ANtHBEXevCygZEjMntl1U6VIW3kjp/xGmEIrTcnHUNPvcPCOyX6Goa4I6VhUR jcg17dahfCbV+Bw40VjrNO99nDfmGWJsI9Xb0tw2Cv/Jl8+BW+dftFDO1iKTJnWaPG/Z R408xvn7qfUlyOfaJD8WulBuGKsO0GrKok5uv34fpAmmSA/janR9hRWBlG0c8rfz5zVO Ga3UbN+07CJ5Wk9SLu1mqOqbMstkAZfiLuye8uolrzqdZ4BhUy2Fj85SZunAkzxRYgn3 Va8+1qoJqVhsfoSUg/y3/rFludnN4p4VAMS4pDC/nVi9NfC6+bl1KP1pjy5RMmZ2TEHZ 3Ykg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=3s1yOhxXzIZ2EdKGgerVgQWxqiH1u5YZX4OXhPSEQz4=; b=EQKkfY/0+LQNVzVcrnR3kX3hXrFHGauJn0mab7gzotVEkDetHquvR7L79SulLLWytu LM8i7YiYkt/Qid1C9T2tO2xQLR2JssC7YlfamS9gJ2IGBhnbBCr95HR9CYhiiG/Mva+9 dTm0XlUaKLdkfmO7Mf6/CQ3Eq90eRwFg46N8ZnLbZEqkCFCZuICYRgCdOSrit/e5lIDG geseOXfwGjis3R7uVlfURfYIKwpzYrQXR5F/L3z/UpKYL4CvjrloaPIok+YIvyfMLHI5 d7x41XgAg3Kvn/ZzWk2a3xqS1Etky2dI4Ehy8ZGLJ9s4j0Cx9gWKKQ5WJCd5hf5wrq2m mwzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=po7ej6FQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b133si963852oif.244.2019.12.09.16.08.28; Mon, 09 Dec 2019 16:08:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=po7ej6FQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727387AbfLJAGq (ORCPT + 99 others); Mon, 9 Dec 2019 19:06:46 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:52032 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726495AbfLJAGq (ORCPT ); Mon, 9 Dec 2019 19:06:46 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBA04GhW031683; Tue, 10 Dec 2019 00:06:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=3s1yOhxXzIZ2EdKGgerVgQWxqiH1u5YZX4OXhPSEQz4=; b=po7ej6FQbAjQODWDACjuUl0jMaMtw9QSVUDT/VQ9cx/FXrKdoQJwApx3gNc0SeBNB5Yq kkO7VsiLsPtjIvhnfswH1hO5ZR+Bf5DGyTaPQBHYMLLLIfg0z0tgd08B+rDGv/1wgJf4 P9GtYwtkw3UqVVjzu+O4W2JOL8tvOhaxzph3Doqai/XYAeRlsM06zHJFY86SsT/puNjN SIUapaSsiD0mcR1XOYraQzcOPsKOfAtUBFyREXHYJ3uWjpxxLaDMJnQ8/5mQR9YQ2aJu TvSuKFFsGSkTxQUFVbj9gR9ltbiT/9b8inmns5wZ35Oy6IPDaJ4bgk59dtCKA5xh3aBC qw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 2wr41q2wq8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Dec 2019 00:06:39 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBA04D5D157892; Tue, 10 Dec 2019 00:06:39 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 2wsv8atg4f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Dec 2019 00:06:38 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id xBA06bIx003934; Tue, 10 Dec 2019 00:06:37 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 09 Dec 2019 16:06:36 -0800 To: Chuhong Yuan Cc: Don Brace , "James E . J . Bottomley" , "Martin K . Petersen" , esc.storagedev@microsemi.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH resend] scsi: smartpqi: add missed free_irq in suspend From: "Martin K. Petersen" Organization: Oracle Corporation References: <20191203111337.13054-1-hslester96@gmail.com> Date: Mon, 09 Dec 2019 19:06:34 -0500 In-Reply-To: <20191203111337.13054-1-hslester96@gmail.com> (Chuhong Yuan's message of "Tue, 3 Dec 2019 19:13:37 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9466 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=836 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912090190 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9466 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=917 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912090191 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The driver calls request_irq in resume but does not call free_irq in > suspend. > Add the missed call to fix it. Microsemi: Please review! -- Martin K. Petersen Oracle Linux Engineering