Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   10 Dec 2019 09:09:15 +0900
Message-ID: <87o8whyrbo.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Daniel Baluta <daniel.baluta@nxp.com>
Cc:     broonie@kernel.org, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: simple-card: Don't create separate link when platform is present
In-Reply-To: <20191209135353.17427-1-daniel.baluta@nxp.com>
References: <20191209135353.17427-1-daniel.baluta@nxp.com>
User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Hi

> In normal sound case all DAIs are detected as CPU-Codec.
> simple_dai_link_of supports the presence of a platform but it counts
> it as a CPU DAI resulting in the creation of an extra link.
> 
> Adding a platform property to a link description like:
> 
> simple-audio-card,dai-link {
> 	cpu {
> 		sound-dai = <&sai1>;
> 	};
> 	plat {
> 		sound-dai = <&dsp>;
> 	};
> 	codec {
> 		sound-dai = <&wm8960>;
> 	}
> 
> will result in the creation of two links:
> 	* sai1 <-> wm8960
> 	* dsp  <-> wm8960
> 
> which is obviously not what we want. We just want one single link
> with:
> 	* sai1 <-> wm8960 (and platform set to dsp).
> 
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thank you for your help !!
Best regards
---
Kuninori Morimoto