Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 10 Dec 2019 11:31:13 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Cc:     dan.j.williams@intel.com, michal.simek@xilinx.com,
        nick.graumann@gmail.com, andrea.merello@gmail.com,
        appana.durga.rao@xilinx.com, mcgrof@kernel.org,
        dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
        git@xilinx.com
Subject: Re: [PATCH] dmaengine: xilinx_dma: Reset DMA channel in
 dma_terminate_all
Message-ID: <20191210060113.GP82508@vkoul-mobl>
References: <1574664121-13451-1-git-send-email-radhey.shyam.pandey@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1574664121-13451-1-git-send-email-radhey.shyam.pandey@xilinx.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 25-11-19, 12:12, Radhey Shyam Pandey wrote:
> Reset DMA channel after stop to ensure that pending transfers and FIFOs
> in the datapath are flushed or completed. It fixes intermittent data
> verification failure reported by xilinx dma test client.
> 
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> ---
>  drivers/dma/xilinx/xilinx_dma.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
> index a9c5d5c..6f1539c 100644
> --- a/drivers/dma/xilinx/xilinx_dma.c
> +++ b/drivers/dma/xilinx/xilinx_dma.c
> @@ -2404,16 +2404,17 @@ static int xilinx_dma_terminate_all(struct dma_chan *dchan)
>  	u32 reg;
>  	int err;
>  
> -	if (chan->cyclic)
> -		xilinx_dma_chan_reset(chan);

So reset is required for non cyclic cases as well now?

> -
> -	err = chan->stop_transfer(chan);
> -	if (err) {
> -		dev_err(chan->dev, "Cannot stop channel %p: %x\n",
> -			chan, dma_ctrl_read(chan, XILINX_DMA_REG_DMASR));
> -		chan->err = true;
> +	if (!chan->cyclic) {
> +		err = chan->stop_transfer(chan);

no stop for cyclic now..?

> +		if (err) {
> +			dev_err(chan->dev, "Cannot stop channel %p: %x\n",
> +				chan, dma_ctrl_read(chan,
> +				XILINX_DMA_REG_DMASR));
> +			chan->err = true;
> +		}
>  	}
>  
> +	xilinx_dma_chan_reset(chan);
>  	/* Remove and free all of the descriptors in the lists */
>  	xilinx_dma_free_descriptors(chan);
>  	chan->idle = true;
> -- 
> 2.7.4

-- 
~Vinod