Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5014428ybl; Mon, 9 Dec 2019 22:03:31 -0800 (PST) X-Google-Smtp-Source: APXvYqw4ELnIGq+OxEUOfOJ1TN2FKk2QxkH3676ljNT2I7sIqthIpy7dizBBxB/LmLQrUZPdRc1h X-Received: by 2002:a9d:7a4b:: with SMTP id z11mr24712298otm.46.1575957811548; Mon, 09 Dec 2019 22:03:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575957811; cv=none; d=google.com; s=arc-20160816; b=vNtqPVTIjCATZOo0TBe4ZOigvCBTumdqX/wxahSi8vcrUnmRmkX+HzLkKGKE6LJ4Ez tCVEP+RlZjQE8br2cOe3ytfJHRqxWDzY8pq0pcqSDmzK7HGFEmkoKvc9m5Z3r7m00RPy J0B3kD1iq8hV3UleeDlX3zCEqpmmh0qod9JAmsQcy/MLk2tYXMrDNtNfSHBCZZyliOVj tqIEsAPs4jSYjyDVjineWwqx0j0qSccX3vGDkSeC3YXZnVBCjDX3JUHoFoAg9NDFIO4Z 5hOKMCXrhRUXrhdUweD5LH/LTQUhZhJsWXWhFRr3RitNu8qql19zRpieYBp3nDkeNZ1R pSSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ZGNz+wST/TC5L22btvBYhW34ImkSZc4kLbamwRrJ8jk=; b=HiskWIlln6bA20W863veG18Y3NRH8BAgiUjxkcAj4wZdalAdn51U7mkkSRz03ZuWYB GmjU/88iVG69XbmBiOKN78vRMOkEQziqyDfliI92HvW5YOmacFlBdSpmvJ3aQwG/JVPo 7deukrlj0k9Mn2wd/zgu/mLSamGa5PNDSerb8P7LK/QbrZA/8WN9YldvgTGO6mvZzHMD fgS0VH03jGtPtfU3Xf9yrXm3P1aGBu71qtizbUeEkLc7zAbcLq/tYUPNywjFvUS4wtOO +lOlIa5BCTuBra/P2I6ksVEZ7mrIexile9ZgBAmzSuB3mA+KG4eW2pu61h5YoGJs3BO2 Y7Tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NX5YT5De; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o128si1394749oih.66.2019.12.09.22.03.19; Mon, 09 Dec 2019 22:03:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NX5YT5De; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726989AbfLJGCw (ORCPT + 99 others); Tue, 10 Dec 2019 01:02:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:50322 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725942AbfLJGCw (ORCPT ); Tue, 10 Dec 2019 01:02:52 -0500 Received: from localhost (unknown [106.201.45.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 32A9520652; Tue, 10 Dec 2019 06:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575957772; bh=syvbhAR/ADsJyMnOlOSI0B7aatrRGP2kpxTU6u/WAOE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NX5YT5DeCowC/Mi+uHgqUvsvtunko8BdoEGU+P34H0KdO31rcS7Zj/A1SAbX4B9p7 Asf/rhbEEjj/ZJenjdI7a8FexDk2KvvFlFHau+IYBJ9w2eV2fcCRAN3/V648JsjU1Z qSZj1x+Gl5PHEwgDsADpk9m0xB+RLDzPio7BF+0Q= Date: Tue, 10 Dec 2019 11:32:47 +0530 From: Vinod Koul To: Chuhong Yuan Cc: Dan Williams , Peter Ujfalusi , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] dmaengine: ti: edma: add missed operations Message-ID: <20191210060247.GQ82508@vkoul-mobl> References: <20191124052855.6472-1-hslester96@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191124052855.6472-1-hslester96@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24-11-19, 13:28, Chuhong Yuan wrote: > The driver forgets to call pm_runtime_disable and pm_runtime_put_sync in > probe failure and remove. > Add the calls and modify probe failure handling to fix it. > > To simplify the fix, the patch adjusts the calling order and merges checks > for devm_kcalloc. Applied, thanks -- ~Vinod