Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5106797ybl; Tue, 10 Dec 2019 00:08:25 -0800 (PST) X-Google-Smtp-Source: APXvYqx/L+vVSDPHj44Y2f0qa57r/7PYkIxzXocwqbRdpIt1ZueCYDtL3djUametp3u6QWqTEDTc X-Received: by 2002:a9d:4c88:: with SMTP id m8mr20702998otf.12.1575965305715; Tue, 10 Dec 2019 00:08:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575965305; cv=none; d=google.com; s=arc-20160816; b=pHhWye4am3x747uUoisRIlyGDZhS9fR7DFYPteyRIdw64JSMsS0AYuMnq8ZYqFzPQO YbzRVSR2Z/T6dNopGqXrG2OxSBZiIlFmrCkXNOHMCemBweXCUgWtkSq4n8EWKexp9lMX EsiWG5j71FNU45kxcCldNBghbPzaGs5HvIx/rJqlZgCx0Unn+0yP5PKazP3SXZSIsV1a reAwLcyUWjBWQDpjTzD9+1LSApyOtWXiQcxYJr7Wl9VlMGQ6GMCZRVAiZ4iEqsdeTlMr WMRCoU1ZWfSgmVLu9Z1wIT9HTNXLYaAEmGmEwAF4DjgzF82yLSEICCtcuWOIJhWlQO/L 3qfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=6RAW380bDza2LKCex9KQLfz6c9wFFEA3z1oJn/Qeiu0=; b=zfIq0X6OKuZpbpp45M1CfulFaDAUQRVVJx1njs2Kdg1O295J+AOcZdQBO4fyqoQVXj JZesKAShzEfL02RgjK6JJzIAaJpVSqxVqaSOQ/GYI3rapmPqS/mCvdnf2ai6DXHLyeT9 NcqV2Orqp0XGBuZ/d1UQA5s0TbzcBmuibFMF0xGRA2O0lanz8a+DovJxzE5/C3DTR2AL FfPI7Ycr1QkKjvZpWNYRTVy8K6myKGL67VEpP9+Gbzz/W8HvCttartWAD/LNsfN7gZ7h BnUjG6atfiXd1qiU9UuU3vjak8pl20YHewHY6xavqndmiTrzW2UyXd2PSk31mZhd+fhp lrxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 101si1421298otc.322.2019.12.10.00.08.12; Tue, 10 Dec 2019 00:08:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727127AbfLJIHK (ORCPT + 99 others); Tue, 10 Dec 2019 03:07:10 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:35787 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726248AbfLJIHJ (ORCPT ); Tue, 10 Dec 2019 03:07:09 -0500 Received: by mail-oi1-f193.google.com with SMTP id k196so9022674oib.2 for ; Tue, 10 Dec 2019 00:07:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6RAW380bDza2LKCex9KQLfz6c9wFFEA3z1oJn/Qeiu0=; b=QWPwSTzsMNeiyfzCnFf22C8sBQJKZm/7e17UQSo4Fa91U0Q3SeTXOrk6bbgqJ1AwiI GSu1TqeLzpMEO+QlfZudYvp4qGyewV/Rx6qZl/a04oh6/lH0F/S8batCS+l3nNvLG/3C 6r+8VVDbN4S5w5Yz27w/pTQFOP5P4y9/6yFa5KlR8J42gejtR9Q/HmEMC4YLvGF7uSOL VZ6iJrJTva+GvgbN3tdxf89BEkaLbVe8jRieRFps510SrQmo1GGRh7DSRB1myVYdCHpL laRkbHDWAbo8h3oRb2yOv7Gm9AtWS9AELKnRq/olDrTV3uDw+h96uglILnMVCRIeud04 M+1g== X-Gm-Message-State: APjAAAW9Yo+C+fy02sPI8VC0O0LTI9cw7SFTRvnIH3fzZKY4ibYyP0RP 9+IYIV5QnDjk4y1q1kQRKYhH6NRfGVmp0UuGgBs= X-Received: by 2002:aca:4e87:: with SMTP id c129mr2806009oib.153.1575965228901; Tue, 10 Dec 2019 00:07:08 -0800 (PST) MIME-Version: 1.0 References: <20191016210629.1005086-1-ztuowen@gmail.com> <20191016210629.1005086-3-ztuowen@gmail.com> <20191111084105.GI18902@dell> In-Reply-To: <20191111084105.GI18902@dell> From: Geert Uytterhoeven Date: Tue, 10 Dec 2019 09:06:57 +0100 Message-ID: Subject: Re: [PATCH v5 2/4] lib: devres: add a helper function for ioremap_uc To: Lee Jones Cc: Tuowen Zhao , Linux Kernel Mailing List , Andy Shevchenko , Mika Westerberg , acelan.kao@canonical.com, "Luis R. Rodriguez" , "David S. Miller" , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 11, 2019 at 9:45 AM Lee Jones wrote: > On Wed, 16 Oct 2019, Tuowen Zhao wrote: > > Implement a resource managed strongly uncachable ioremap function. > > > > Cc: > > Tested-by: AceLan Kao > > Signed-off-by: Tuowen Zhao > > Acked-by: Mika Westerberg > > Acked-by: Andy Shevchenko > > Acked-by: Luis Chamberlain > > Acked-for-MFD-by: Lee Jones > > --- > > include/linux/io.h | 2 ++ > > lib/devres.c | 19 +++++++++++++++++++ > > 2 files changed, 21 insertions(+) > > Applied, thanks. This is now commit e537654b7039aacf ("lib: devres: add a helper function for ioremap_uc") in upstream. Do we really need this? There is only one user of ioremap_uc(), which Christoph is trying hard to get rid of, and now you made it mandatory. https://lore.kernel.org/dri-devel/20191112105507.GA7122@lst.de/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds