Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5111038ybl; Tue, 10 Dec 2019 00:14:03 -0800 (PST) X-Google-Smtp-Source: APXvYqzX3kHJ729BeeVbL+gNsCMf90CVrcchAHzPr8qp7lzOJM036kIzWTasa7YTGq3dtt+qXbXn X-Received: by 2002:a54:4485:: with SMTP id v5mr2823078oiv.144.1575965643449; Tue, 10 Dec 2019 00:14:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575965643; cv=none; d=google.com; s=arc-20160816; b=D4udjBp4i8XXXn8cte/NTZTaywi5EC64kchOpLmGvehoIV5LiIweLPbSukbxPAcuVm kHGQCJULPhAOV7BlH0dYdXWvHLRYLPvdC3RW30gmByr9LOUDemkJdBP14zbqZvgmJIUO 0S73xASeY3xxS8SDqifJEXI5bGH2EggiYcd95HTMCT3dEKXa/Dhc/Qz6iF4rWVJJfIZe g6L7lDYNxB4/OuNUE0d8RON8PlALbsBNDvDaZ4lCBKU7lPQBk44wUKfx9zGPM3J8Yv9H nDxFI/imj6tr+4wKBzgFYsL+37RUMp2wexLWRhrkAeqRcCozYGaZv7EJdzAJ6GyFjydO uNxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=zUF00rSBZ0rnjT0she8dgiVuY2HTDNpwSRiMpgHNEPo=; b=I9DJUNhbwUnzBHsx7hIC2XaIjt5+LRdqDEPAJjvSrvgM/wYraphLzG34ujZ9Cxn60i TMXEWoA2bV69McNEZYZpIps7sVDwvZCvpMsHmmVR4wWLKeCofguWP2anDoE1IAuL2Ult ZT/P1BEc0t8ANLa13kO1qeSLrs8vMDHdm6rsPlWpuxP7MktUgt8LX6BJpeM/b3P73YVW yMpTa64Z8aTfTRqtPxVaoC2hVFk/eMvH/geaFMkuNDlvfzXy6h4PJhEOHQ4lr/cTgMkp XeVoaUpaXqlekoib/rOorVOdlLncBR2s2inTx7qR2vUD4xNV48ZKCxKQjt92MOgodgwx kShg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n65si1488792oib.262.2019.12.10.00.13.49; Tue, 10 Dec 2019 00:14:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726739AbfLJIL4 (ORCPT + 99 others); Tue, 10 Dec 2019 03:11:56 -0500 Received: from mail-ot1-f66.google.com ([209.85.210.66]:43168 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726062AbfLJILz (ORCPT ); Tue, 10 Dec 2019 03:11:55 -0500 Received: by mail-ot1-f66.google.com with SMTP id p8so14731356oth.10 for ; Tue, 10 Dec 2019 00:11:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zUF00rSBZ0rnjT0she8dgiVuY2HTDNpwSRiMpgHNEPo=; b=JrHKV25z641rC4YUp3fMWtpvuHnCbHKTg7bQ/EowcloId68Noial+jQ4mN4Ruz9iNX Q/bJACdVsv1YbxcAnzcyyhl7I9/VHdFeuaGeMICB8K0mk344mnLTftfSgOV1DK3vsQ2n c8u/WYKmAa8tJMbmlg1qPhw72x8g4GePwNriWFxMhNHhCTjXZJrsxSoftoqhxCoWOI/X 3J3ekGfAlHwAalUcn7t1dY6lAv+V+4F1qAOo2AdmuO8Gmdtxwk5vAt+F+zUNSK5GHpKm PHNLaWivCgQbSjiRxDAiLorQ2otl+kL/r5GNAoR0gdG8+43RO7kxPo9zaBusVzlptQ6n chtg== X-Gm-Message-State: APjAAAX3dFPGoVsj+yDqcePgfwBvbXOrL2ICFCKEIc+iyXWJYgR/AmJo pNijC8ySNxNPOvB46RbHdlB3YJTdgcZNk0QsA4Y= X-Received: by 2002:a9d:6c81:: with SMTP id c1mr23733892otr.39.1575965514778; Tue, 10 Dec 2019 00:11:54 -0800 (PST) MIME-Version: 1.0 References: <20191016210629.1005086-1-ztuowen@gmail.com> <20191016210629.1005086-4-ztuowen@gmail.com> In-Reply-To: <20191016210629.1005086-4-ztuowen@gmail.com> From: Geert Uytterhoeven Date: Tue, 10 Dec 2019 09:11:43 +0100 Message-ID: Subject: Re: [PATCH v5 3/4] mfd: intel-lpss: use devm_ioremap_uc for MMIO To: Tuowen Zhao Cc: Lee Jones , Linux Kernel Mailing List , Andy Shevchenko , Mika Westerberg , acelan.kao@canonical.com, "Luis R. Rodriguez" , "David S. Miller" , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org CC Christoph (ioremap() API cleanup) On Thu, Oct 17, 2019 at 10:44 PM Tuowen Zhao wrote: > Some BIOS erroneously specifies write-combining BAR for intel-lpss-pci > in MTRR. This will cause the system to hang during boot. If possible, > this bug could be corrected with a firmware update. > > This patch use devm_ioremap_uc to overwrite/ignore the MTRR settings > by forcing the use of strongly uncachable pages for intel-lpss. > > The BIOS bug is present on Dell XPS 13 7390 2-in-1: > > [ 0.001734] 5 base 4000000000 mask 6000000000 write-combining > > 4000000000-7fffffffff : PCI Bus 0000:00 > 4000000000-400fffffff : 0000:00:02.0 (i915) > 4010000000-4010000fff : 0000:00:15.0 (intel-lpss-pci) > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=203485 > Cc: > Tested-by: AceLan Kao > Signed-off-by: Tuowen Zhao > Acked-by: Mika Westerberg > Acked-by: Andy Shevchenko > Acked-for-MFD-by: Lee Jones > --- > drivers/mfd/intel-lpss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c > index bfe4ff337581..b0f0781a6b9c 100644 > --- a/drivers/mfd/intel-lpss.c > +++ b/drivers/mfd/intel-lpss.c > @@ -384,7 +384,7 @@ int intel_lpss_probe(struct device *dev, > if (!lpss) > return -ENOMEM; > > - lpss->priv = devm_ioremap(dev, info->mem->start + LPSS_PRIV_OFFSET, > + lpss->priv = devm_ioremap_uc(dev, info->mem->start + LPSS_PRIV_OFFSET, > LPSS_PRIV_SIZE); > if (!lpss->priv) > return -ENOMEM; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds