Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Alison Wang <alison.wang@nxp.com>
To:     Michael Walle <michael@walle.cc>
CC:     Shawn Guo <shawnguo@kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Leo Li <leoyang.li@nxp.com>, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>
Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: put SAIs into async mode
Thread-Topic: [EXT] Re: [PATCH] arm64: dts: ls1028a: put SAIs into async mode
Thread-Index: AQHVrnBLtaYchIru+E6aNXw66ImuFqeyq8zwgABj3QCAAASy0A==
Date:   Tue, 10 Dec 2019 09:13:23 +0000
Message-ID: <VI1PR04MB406255C30EDF41634C01EE2DF45B0@VI1PR04MB4062.eurprd04.prod.outlook.com>
References: <20191129210937.26808-1-michael@walle.cc>
 <20191209090840.GL3365@dragon>
 <VI1PR04MB4062D212996FE37A72DE3557F45B0@VI1PR04MB4062.eurprd04.prod.outlook.com>
 <83445bed8b838b56e7d041915f1849f8@walle.cc>
In-Reply-To: <83445bed8b838b56e7d041915f1849f8@walle.cc>
Accept-Language: zh-CN, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 31770836-91c0-4337-fef6-08d77d51354a
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2019 09:13:23.4455
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qElqFmhZjB3vxL3li3qfREJvYm5JIvPfzDMcuHZDJ7UeRW7aoXC4s/nx8anxMc9707jnS/JoX3Z2iEscTgYwrg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4349
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Michael,

> Caution: EXT Email
>=20
> Hi Alison,
>=20
> Am 2019-12-10 06:35, schrieb Alison Wang:
> > Hi, Michael,
> >
> > In most of our cases, TX and RX are using the same BCLK and SYNC
> > clocks. So the default synchronous mode (sync Rx with Tx) is used,
> > which means both transmitter and receiver will send and receive data
> > by following clocks of transmitter. It is verified on our boards.
>=20
>=20
> I get that, but it doesn't make sense for the LS1028A SoC because, there =
is no
> way you have have the TX data and the RX clocks or vice versa. The hardwa=
re
> of the SoC doesn't allow that. I cannot speak of the QDS variant of the S=
oC, but
> the LS1028ARDB only has a transmitter. So there is no problem, because it=
 will
> default to the TX clock. But as soon as you also have a receiver you have=
 to use
> the clock of the receiver block. You could say, use fsl,sai-synchronous-r=
x, but
> that will only work if the SAI is used in RX mode. fsl,sai-asynchronous m=
ode
> works for both on the other hand and can therefore be the default mode.
>=20
> -michael
[Alison] Your explanation is reasonable. LS1028A SoC is a specific one. Usi=
ng fsl,sai-asynchronous
mode is the preferred choice.

Acked-by: Alison Wang <alison.wang@nxp.com>


Best Regards,
Alison Wang

>=20
>=20
> >
> >
> > Best Regards,
> > Alison Wang
> >
> >> -----Original Message-----
> >> From: Shawn Guo <shawnguo@kernel.org>
> >> Sent: Monday, December 9, 2019 5:09 PM
> >> To: Michael Walle <michael@walle.cc>; Alison Wang
> >> <alison.wang@nxp.com>
> >> Cc: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
> >> linux-kernel@vger.kernel.org; Leo Li <leoyang.li@nxp.com>; Rob
> >> Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>
> >> Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: put SAIs into async
> >> mode
> >>
> >> Caution: EXT Email
> >>
> >> + Alison Wang
> >>
> >> On Fri, Nov 29, 2019 at 10:09:37PM +0100, Michael Walle wrote:
> >> > The LS1028A SoC has only unidirectional SAIs. Therefore, it doesn't
> >> > make sense to have the RX and TX part synchronous. Even worse, the
> >> > RX part wont work out of the box because by default it is
> >> > configured as synchronous to the TX part. And as said before, the
> >> > pinmux of the SoC can only be configured to route either the RX or
> >> > the TX signals to the SAI but never both at the same time. Thus
> >> > configure the asynchronous mode by default.
> >> >
> >> > Signed-off-by: Michael Walle <michael@walle.cc>
> >>
> >> Alison, Leo,
> >>
> >> Looks good to you?
> >>
> >> Shawn
> >>
> >> > ---
> >> >  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 6 ++++++
> >> >  1 file changed, 6 insertions(+)
> >> >
> >> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> >> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> >> > index 379913756e90..9be33426e5ce 100644
> >> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> >> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> >> > @@ -637,6 +637,7 @@
> >> >                       dma-names =3D "tx", "rx";
> >> >                       dmas =3D <&edma0 1 4>,
> >> >                              <&edma0 1 3>;
> >> > +                     fsl,sai-asynchronous;
> >> >                       status =3D "disabled";
> >> >               };
> >> >
> >> > @@ -651,6 +652,7 @@
> >> >                       dma-names =3D "tx", "rx";
> >> >                       dmas =3D <&edma0 1 6>,
> >> >                              <&edma0 1 5>;
> >> > +                     fsl,sai-asynchronous;
> >> >                       status =3D "disabled";
> >> >               };
> >> >
> >> > @@ -665,6 +667,7 @@
> >> >                       dma-names =3D "tx", "rx";
> >> >                       dmas =3D <&edma0 1 8>,
> >> >                              <&edma0 1 7>;
> >> > +                     fsl,sai-asynchronous;
> >> >                       status =3D "disabled";
> >> >               };
> >> >
> >> > @@ -679,6 +682,7 @@
> >> >                       dma-names =3D "tx", "rx";
> >> >                       dmas =3D <&edma0 1 10>,
> >> >                              <&edma0 1 9>;
> >> > +                     fsl,sai-asynchronous;
> >> >                       status =3D "disabled";
> >> >               };
> >> >
> >> > @@ -693,6 +697,7 @@
> >> >                       dma-names =3D "tx", "rx";
> >> >                       dmas =3D <&edma0 1 12>,
> >> >                              <&edma0 1 11>;
> >> > +                     fsl,sai-asynchronous;
> >> >                       status =3D "disabled";
> >> >               };
> >> >
> >> > @@ -707,6 +712,7 @@
> >> >                       dma-names =3D "tx", "rx";
> >> >                       dmas =3D <&edma0 1 14>,
> >> >                              <&edma0 1 13>;
> >> > +                     fsl,sai-asynchronous;
> >> >                       status =3D "disabled";
> >> >               };
> >> >
> >> > --
> >> > 2.20.1
> >> >