Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
From:   "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
To:     Liviu Dudau <Liviu.Dudau@arm.com>,
        "airlied@linux.ie" <airlied@linux.ie>,
        Brian Starkey <Brian.Starkey@arm.com>,
        Mihail Atanassov <Mihail.Atanassov@arm.com>, nd <nd@arm.com>,
        "Oscar Zhang (Arm Technology China)" <Oscar.Zhang@arm.com>,
        "Tiannan Zhu (Arm Technology China)" <Tiannan.Zhu@arm.com>,
        "Jonathan Chai (Arm Technology China)" <Jonathan.Chai@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "Julien Yin (Arm Technology China)" <Julien.Yin@arm.com>,
        "Channing Chen (Arm Technology China)" <Channing.Chen@arm.com>,
        "Thomas Sun (Arm Technology China)" <thomas.Sun@arm.com>,
        "Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>,
        Ben Davis <Ben.Davis@arm.com>
Subject: Re: [PATCH v1 2/2] drm/komeda: Refactor sysfs node "config_id"
Thread-Topic: [PATCH v1 2/2] drm/komeda: Refactor sysfs node "config_id"
Thread-Index: AQHVpEfreeFjBGX9KE2GMbcm5nukJKedW8GAgBXtVgA=
Date:   Tue, 10 Dec 2019 10:59:06 +0000
Message-ID: <20191210105900.GA20614@jamwan02-TSP300>
References: <20191126105412.5978-1-james.qian.wang@arm.com>
 <20191126105412.5978-3-james.qian.wang@arm.com>
 <20191126120805.GU29965@phenom.ffwll.local>
In-Reply-To: <20191126120805.GU29965@phenom.ffwll.local>
Accept-Language: en-US
Content-Language: en-US
user-agent: Mutt/1.10.1 (2018-07-13)
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=james.qian.wang@arm.com; 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 1334237a-fae2-4423-f69d-08d77d5fff03
X-MS-TrafficTypeDiagnostic: VE1PR08MB4974:|VE1PR08MB4974:|VI1PR08MB4093:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <VI1PR08MB409328916828F44AC3D0A25DB35B0@VI1PR08MB4093.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
x-ms-oob-tlc-oobclassifiers: OLM:6790;OLM:6790;
x-forefront-prvs: 02475B2A01
X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(7916004)(136003)(376002)(346002)(366004)(39860400002)(396003)(199004)(189003)(6512007)(9686003)(81166006)(8936002)(478600001)(81156014)(33656002)(6486002)(8676002)(5660300002)(71200400001)(33716001)(966005)(2906002)(52116002)(64756008)(55236004)(316002)(6506007)(26005)(66556008)(1076003)(66476007)(66446008)(86362001)(6636002)(186003)(110136005)(66946007)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR08MB4974;H:VE1PR08MB5006.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: DpEMBemi4H5UyidYVPothgjVtIqSF5ZC1HWWN34/9++HjUMGlpeaM+n1PDatds/d7chMUVnzYMs9nKPNwP5OJBPBdXUNPUlRbBG4KlUqlSss5T2bpCsHAahncFQunNI52tv+UIW1DUOcyvsZJaAtz0TEp/pBX2ddIlOT2yBTy3ZHV9JANdAOVwPXBtFU4YTW2tr8e0EWLnq22aJ7nTbPWBuuwSj+cFCc3SaeHz00rTQ9sP/+jIHY9Zyn/cTlFdqVOmCLqYIviCcCMa1PRRb8cuDr4iaT5QwMvQq/f7P2BqbM4btSL6pyVghkSyn0GwQ92bkFSwfvDStKDrSJT6Muzy5zS+YSu09qliQNLTEg9QwDNGagAAe98LHGhcX0E+XwByC2qHilBfzYjCgouWSGSkxLkrxycGYbilC/q8MQuvtgwsvOXp8Uwsx7imOXpqDNJKNw8doFJ5+ACKKZNlZilOqjdnM+DA/48ucKIxW0yPZN08IRl5mRJGRliRZkA/QrHKqXntspNGVjno3gEEjNE7WGKdgVknMnWwwJBpCoqRs=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7D7C92B8BE3F044A9F0F2407F6CFE94D@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4974
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=james.qian.wang@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(7916004)(4636009)(136003)(376002)(396003)(39860400002)(346002)(189003)(199004)(40434004)(36906005)(966005)(8936002)(478600001)(6512007)(110136005)(9686003)(26826003)(8676002)(2906002)(1076003)(33656002)(316002)(6486002)(356004)(81166006)(81156014)(86362001)(70586007)(70206006)(6506007)(336012)(26005)(33716001)(6636002)(76130400001)(5660300002)(186003)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR08MB4093;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:Pass;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;MX:1;A:1;
X-MS-Office365-Filtering-Correlation-Id-Prvs: 58e72cc8-2662-4720-a086-08d77d5ffa10
X-Forefront-PRVS: 02475B2A01
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ALcaVD2l0U07g/jn+fUwLOMVL0H7SNp9OWh6OWtF4FzEgjzdAkXMJuC/gAqg2gMSwH1vOnMuG2PYlDKKaoEikTFiW36mGAF+mtu5uv1AUZkbAfc6pdnmc3tWaSe6smmji9hCOU1SoOY27RcPxWl8hqIH4Exjxw2vmuWFLIdYCINnfAPZqE4Lyce1b2989qVDJ+M8rr349+jjQpvJ4TdQeNmjmhTcdkCC4CSF+iFMDhkrMDbsRPvP25MgK0yU15J85Cww6GUtxxhcefizgtY+M3F1qReykCLRC2l6SEmd3jIWETHx6ZHUMIRHeWSRbYNfLZCeXXuNcKHA2nEiZm8egF5wLfQlNiPULh9NtEI71DP9SweQMJUPNyuE4QG09BpHJjXIOXu8XRkiLp+NHTCVeX0pzDqfPVzRmYF4HA/YUSwhzgyW/OSxYDt4nNekMMz4vtx7mRy/Wj0pZFqdyYmaBMZkoKdMApVV8tZA72ksrNuqgR7wiy0jQMPgnBAqjggv/7JWdZHezUpFZSOkEPp7ONsvxFZjPO8uWKEiTNaJ+JjW6tUI8sE9fPCJTMJC/AuO
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2019 10:59:14.8608
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1334237a-fae2-4423-f69d-08d77d5fff03
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4093
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 26, 2019 at 01:08:05PM +0100, Daniel Vetter wrote:
> On Tue, Nov 26, 2019 at 10:54:47AM +0000, james qian wang (Arm Technology=
 China) wrote:
> > From: "James Qian Wang (Arm Technology China)" <james.qian.wang@arm.com=
>
> >
> > Split sysfs config_id bitfiles to multiple separated sysfs files.
> >
> > Signed-off-by: James Qian Wang (Arm Technology China) <james.qian.wang@=
arm.com>
>
> I guess Dave&my questions werent quite clear, this looks like uapi that's
> consumed by hwc, so the userspace needs to be open source. Plus it needs
> to be discussed/reviewed like any other kms uapi extensions, with a
> critical eye whether this makes sense to add to a supposedly cross-vendor
> interface.
>

Hi Dave & Daniel:

I think some komeda sysfs nodes can be added as cross-vendor.

  - core_id:
    which actually is like vendor_id/subsystem_device_id/revision in
    PCI dev, Maybe we can add a util funcs to fake these sysfs nodes
    for none PCI-dev like komeda

    device_info_sysfs_add(struct device *dev,
        u16 vendor, u16 subsystem_vendor,
        u16 subsystem_device, u8 revision);

    The arguments:
      vendor: I'd like to use the PCI vendor_ID, since with that user
              can see a unique ID, and easy to indentify different devices.
      subsystem_vendor/device/revision: device specific.

  - line_size.
    This actually is mode_config->max_width, but current drm still use
    this value to restrict the fb->width, but our HW supports crop, we
    don't have such limition. we can not set the real line_size to
    max_width.
    And I saw there is a fix:
    https://patchwork.freedesktop.org/patch/333454/
    with this fix, we can directly use mode_config->max_width

Beside that we still needs some komeda specific node like:
 - aclk_hz: for expose display engine clock.
 - num_scalers: per pipeline scalers
 - num_pipes: number of display pipelines.

For the open sourced user space, we're trying to switch to
drm_hwcomposer, and drop our internal hwcomposer. but that may need time.
Can we start from porting our specific test to IGT for komeda private uapi
coverage.

Thanks
James
> I suspect the right thing to do here is to push the revert. From a quick
> look at git history this landed together with the other kms properties in
> komeda which we reverted already.
> -Daniel
>
> > ---
> >  .../drm/arm/display/include/malidp_product.h  | 13 ---
> >  .../gpu/drm/arm/display/komeda/komeda_sysfs.c | 80 ++++++++++++++-----
> >  2 files changed, 62 insertions(+), 31 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/arm/display/include/malidp_product.h b/dri=
vers/gpu/drm/arm/display/include/malidp_product.h
> > index dbd3d4765065..b21f4aa15c95 100644
> > --- a/drivers/gpu/drm/arm/display/include/malidp_product.h
> > +++ b/drivers/gpu/drm/arm/display/include/malidp_product.h
> > @@ -21,17 +21,4 @@
> >  #define MALIDP_D71_PRODUCT_ID      0x0071
> >  #define MALIDP_D32_PRODUCT_ID      0x0032
> >
> > -union komeda_config_id {
> > -   struct {
> > -           __u32   max_line_sz:16,
> > -                   n_pipelines:2,
> > -                   n_scalers:2, /* number of scalers per pipeline */
> > -                   n_layers:3, /* number of layers per pipeline */
> > -                   n_richs:3, /* number of rich layers per pipeline */
> > -                   side_by_side:1, /* if HW works on side_by_side mode=
 */
> > -                   reserved_bits:5;
> > -   };
> > -   __u32 value;
> > -};
> > -
> >  #endif /* _MALIDP_PRODUCT_H_ */
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_sysfs.c b/driver=
s/gpu/drm/arm/display/komeda/komeda_sysfs.c
> > index 740f095b4ca5..5effab795dc1 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_sysfs.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_sysfs.c
> > @@ -18,28 +18,67 @@ core_id_show(struct device *dev, struct device_attr=
ibute *attr, char *buf)
> >  static DEVICE_ATTR_RO(core_id);
> >
> >  static ssize_t
> > -config_id_show(struct device *dev, struct device_attribute *attr, char=
 *buf)
> > +line_size_show(struct device *dev, struct device_attribute *attr, char=
 *buf)
> >  {
> >     struct komeda_dev *mdev =3D dev_to_mdev(dev);
> >     struct komeda_pipeline *pipe =3D mdev->pipelines[0];
> > -   union komeda_config_id config_id;
> > -   int i;
> > -
> > -   memset(&config_id, 0, sizeof(config_id));
> > -
> > -   config_id.max_line_sz =3D pipe->layers[0]->hsize_in.end;
> > -   config_id.side_by_side =3D mdev->side_by_side;
> > -   config_id.n_pipelines =3D mdev->n_pipelines;
> > -   config_id.n_scalers =3D pipe->n_scalers;
> > -   config_id.n_layers =3D pipe->n_layers;
> > -   config_id.n_richs =3D 0;
> > -   for (i =3D 0; i < pipe->n_layers; i++) {
> > +
> > +   return snprintf(buf, PAGE_SIZE, "%d\n", pipe->layers[0]->hsize_in.e=
nd);
> > +}
> > +static DEVICE_ATTR_RO(line_size);
> > +
> > +static ssize_t
> > +n_pipelines_show(struct device *dev, struct device_attribute *attr, ch=
ar *buf)
> > +{
> > +   struct komeda_dev *mdev =3D dev_to_mdev(dev);
> > +
> > +   return snprintf(buf, PAGE_SIZE, "%d\n", mdev->n_pipelines);
> > +}
> > +static DEVICE_ATTR_RO(n_pipelines);
> > +
> > +static ssize_t
> > +n_layers_show(struct device *dev, struct device_attribute *attr, char =
*buf)
> > +{
> > +   struct komeda_dev *mdev =3D dev_to_mdev(dev);
> > +   struct komeda_pipeline *pipe =3D mdev->pipelines[0];
> > +
> > +   return snprintf(buf, PAGE_SIZE, "%d\n", pipe->n_layers);
> > +}
> > +static DEVICE_ATTR_RO(n_layers);
> > +
> > +static ssize_t
> > +n_rich_layers_show(struct device *dev, struct device_attribute *attr, =
char *buf)
> > +{
> > +   struct komeda_dev *mdev =3D dev_to_mdev(dev);
> > +   struct komeda_pipeline *pipe =3D mdev->pipelines[0];
> > +   int i, n_richs =3D 0;
> > +
> > +   for (i =3D 0; i < pipe->n_layers; i++)
> >             if (pipe->layers[i]->layer_type =3D=3D KOMEDA_FMT_RICH_LAYE=
R)
> > -                   config_id.n_richs++;
> > -   }
> > -   return snprintf(buf, PAGE_SIZE, "0x%08x\n", config_id.value);
> > +                   n_richs++;
> > +
> > +   return snprintf(buf, PAGE_SIZE, "%d\n", n_richs);
> > +}
> > +static DEVICE_ATTR_RO(n_rich_layers);
> > +
> > +static ssize_t
> > +n_scalers_show(struct device *dev, struct device_attribute *attr, char=
 *buf)
> > +{
> > +   struct komeda_dev *mdev =3D dev_to_mdev(dev);
> > +   struct komeda_pipeline *pipe =3D mdev->pipelines[0];
> > +
> > +   return snprintf(buf, PAGE_SIZE, "%d\n", pipe->n_scalers);
> > +}
> > +static DEVICE_ATTR_RO(n_scalers);
> > +
> > +static ssize_t
> > +side_by_side_show(struct device *dev, struct device_attribute *attr, c=
har *buf)
> > +{
> > +   struct komeda_dev *mdev =3D dev_to_mdev(dev);
> > +
> > +   return snprintf(buf, PAGE_SIZE, "%d\n", mdev->side_by_side);
> >  }
> > -static DEVICE_ATTR_RO(config_id);
> > +static DEVICE_ATTR_RO(side_by_side);
> >
> >  static ssize_t
> >  aclk_hz_show(struct device *dev, struct device_attribute *attr, char *=
buf)
> > @@ -52,7 +91,12 @@ static DEVICE_ATTR_RO(aclk_hz);
> >
> >  static struct attribute *komeda_sysfs_entries[] =3D {
> >     &dev_attr_core_id.attr,
> > -   &dev_attr_config_id.attr,
> > +   &dev_attr_line_size.attr,
> > +   &dev_attr_n_pipelines.attr,
> > +   &dev_attr_n_layers.attr,
> > +   &dev_attr_n_rich_layers.attr,
> > +   &dev_attr_n_scalers.attr,
> > +   &dev_attr_side_by_side.attr,
> >     &dev_attr_aclk_hz.attr,
> >     NULL,
> >  };
> > --
> > 2.20.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
IMPORTANT NOTICE: The contents of this email and any attachments are confid=
ential and may also be privileged. If you are not the intended recipient, p=
lease notify the sender immediately and do not disclose the contents to any=
 other person, use it for any purpose, or store or copy the information in =
any medium. Thank you.