Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 10 Dec 2019 13:29:41 +0100
From:   Lukas Wunner <lukas@wunner.de>
To:     Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
Cc:     "mika.westerberg@linux.intel.com" <mika.westerberg@linux.intel.com>,
        Bjorn Helgaas <helgaas@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        alexander.deucher@amd.com, tiwai@suse.de
Subject: Re: Linux v5.5 serious PCI bug
Message-ID: <20191210122941.zzybs4z5jphpjsu2@wunner.de>
References: <PSXP216MB0438BFEAA0617283A834E11580580@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
 <20191209131239.GP2665@lahna.fi.intel.com>
 <PSXP216MB043809A423446A6EF2C7909A80580@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
 <20191210072800.GY2665@lahna.fi.intel.com>
 <PSXP216MB04384F89D9D9DDA6999347CF805B0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <PSXP216MB04384F89D9D9DDA6999347CF805B0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

[cc += Alex, Takashi]

On Tue, Dec 10, 2019 at 12:00:23PM +0000, Nicholas Johnson wrote:
> On Tue, Dec 10, 2019 at 09:28:00AM +0200, mika.westerberg@linux.intel.com wrote:
> > On Mon, Dec 09, 2019 at 01:33:49PM +0000, Nicholas Johnson wrote:
> > > On Mon, Dec 09, 2019 at 03:12:39PM +0200, mika.westerberg@linux.intel.com wrote:
> > > > On Mon, Dec 09, 2019 at 12:34:04PM +0000, Nicholas Johnson wrote:
> > > > > I have compiled Linux v5.5-rc1 and thought all was good until I 
> > > > > hot-removed a Gigabyte Aorus eGPU from Thunderbolt. The driver for the 
> > > > > GPU was not loaded (blacklisted) so the crash is nothing to do with the 
> > > > > GPU driver.
> > > > > 
> > > > > We had:
> > > > > - kernel NULL pointer dereference
> > > > > - refcount_t: underflow; use-after-free.
> 
> The following is the culprit responsible for the issues:
> 
> commit 586bc4aab878efcf672536f0cdec3d04b6990c94
> Author: Alex Deucher <alexander.deucher@amd.com>
> Date:   Fri Nov 22 16:43:50 2019 -0500
> 
>     ALSA: hda/hdmi - fix vgaswitcheroo detection for AMD

Does the below fix the issue?

-- >8 --
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 35b4526f0d28..b856b89378ac 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -1419,7 +1419,6 @@ static bool atpx_present(void)
 				return true;
 			}
 		}
-		pci_dev_put(pdev);
 	}
 	return false;
 }