Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
To:     Lukas Wunner <lukas@wunner.de>
CC:     "mika.westerberg@linux.intel.com" <mika.westerberg@linux.intel.com>,
        Bjorn Helgaas <helgaas@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "alexander.deucher@amd.com" <alexander.deucher@amd.com>,
        "tiwai@suse.de" <tiwai@suse.de>
Subject: Re: Linux v5.5 serious PCI bug
Thread-Topic: Linux v5.5 serious PCI bug
Thread-Index: AQHVrozxq7Q7SfMf80m5ItEmvTDCAqexx4+AgAAF4YCAASwpAIAATBAAgAAIOoCAAAZVgA==
Date:   Tue, 10 Dec 2019 12:52:30 +0000
Message-ID: <PSXP216MB04382AFE08EAC9E3D7BB190E805B0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
References: <PSXP216MB0438BFEAA0617283A834E11580580@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
 <20191209131239.GP2665@lahna.fi.intel.com>
 <PSXP216MB043809A423446A6EF2C7909A80580@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
 <20191210072800.GY2665@lahna.fi.intel.com>
 <PSXP216MB04384F89D9D9DDA6999347CF805B0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
 <20191210122941.zzybs4z5jphpjsu2@wunner.de>
In-Reply-To: <20191210122941.zzybs4z5jphpjsu2@wunner.de>
Accept-Language: en-AU, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn:  [RPXDFIKaM2bbipOWDjzuehCjcYQcHz/l3gq05f1BRWhH4jxikfFS4QsT4xdvAHV+Lha5sUfQBMo=]
x-microsoft-original-message-id: <20191210125218.GA2390@nicholas-usb>
x-ms-publictraffictype: Email
x-incomingheadercount: 49
x-eopattributedmessage: 0
x-ms-office365-filtering-correlation-id: c4f99184-0c02-48b7-0c18-08d77d6fd160
x-ms-traffictypediagnostic: HK2APC01HT148:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: w5gUwVgnQhl0FmXVvVcZ3GzkvzCx4qGmsCZtVJnm7yS99xl2qIEVZ0cO4VnjMI+nlv6G1GPaKrie65bq8cFN1s3B0+8K2Bt2QTf92yBXAeBMSgc5UVylkKhTGHuXtOUhV6BZTtAAyjJz2wZB5jiK5POvj0AKfgEju7X8MMApixOA6bnFv0BqiSy4iHEEbcYZ
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7A63601F34FFC44EA9A5257000013AC0@KORP216.PROD.OUTLOOK.COM>
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: c4f99184-0c02-48b7-0c18-08d77d6fd160
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2019 12:52:30.7027
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2APC01HT148
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 10, 2019 at 01:29:41PM +0100, Lukas Wunner wrote:
> [cc += Alex, Takashi]
> 
> On Tue, Dec 10, 2019 at 12:00:23PM +0000, Nicholas Johnson wrote:
> > On Tue, Dec 10, 2019 at 09:28:00AM +0200, mika.westerberg@linux.intel.com wrote:
> > > On Mon, Dec 09, 2019 at 01:33:49PM +0000, Nicholas Johnson wrote:
> > > > On Mon, Dec 09, 2019 at 03:12:39PM +0200, mika.westerberg@linux.intel.com wrote:
> > > > > On Mon, Dec 09, 2019 at 12:34:04PM +0000, Nicholas Johnson wrote:
> > > > > > I have compiled Linux v5.5-rc1 and thought all was good until I 
> > > > > > hot-removed a Gigabyte Aorus eGPU from Thunderbolt. The driver for the 
> > > > > > GPU was not loaded (blacklisted) so the crash is nothing to do with the 
> > > > > > GPU driver.
> > > > > > 
> > > > > > We had:
> > > > > > - kernel NULL pointer dereference
> > > > > > - refcount_t: underflow; use-after-free.
> > 
> > The following is the culprit responsible for the issues:
> > 
> > commit 586bc4aab878efcf672536f0cdec3d04b6990c94
> > Author: Alex Deucher <alexander.deucher@amd.com>
> > Date:   Fri Nov 22 16:43:50 2019 -0500
> > 
> >     ALSA: hda/hdmi - fix vgaswitcheroo detection for AMD
> 
> Does the below fix the issue?
> 
> -- >8 --
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 35b4526f0d28..b856b89378ac 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -1419,7 +1419,6 @@ static bool atpx_present(void)
>  				return true;
>  			}
>  		}
> -		pci_dev_put(pdev);
>  	}
>  	return false;
>  }
Yes, removing the pci_dev_put() as above solves the issue.

Thanks.

Kind regards,
Nicholas.