Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191206114326.15856-1-faiz_abbas@ti.com>
In-Reply-To: <20191206114326.15856-1-faiz_abbas@ti.com>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Tue, 10 Dec 2019 14:09:59 +0100
Message-ID: <CAPDyKFr-3RZUPS596HE2+Hu-FxhQ5e1Sv8DbeUtt5qLOjuxU8w@mail.gmail.com>
Subject: Re: [PATCH] mmc: sdhci: Update the tuning failed messages to pr_debug level
To:     Faiz Abbas <faiz_abbas@ti.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 6 Dec 2019 at 12:42, Faiz Abbas <faiz_abbas@ti.com> wrote:
>
> Tuning support in DDR50 speed mode was added in SD Specifications Part1
> Physical Layer Specification v3.01. Its not possible to distinguish
> between v3.00 and v3.01 from the SCR and that is why since
> commit 4324f6de6d2e ("mmc: core: enable CMD19 tuning for DDR50 mode")
> tuning failures are ignored in DDR50 speed mode.
>
> Cards compatible with v3.00 don't respond to CMD19 in DDR50 and this
> error gets printed during enumeration and also if retune is triggered at
> any time during operation. Update the printk level to pr_debug so that
> these errors don't lead to false error reports.
>
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>

Applied for fixes and by adding a stable tag, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 296d955ede59..42a9c8179da7 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -2417,8 +2417,8 @@ static int __sdhci_execute_tuning(struct sdhci_host *host, u32 opcode)
>                 sdhci_send_tuning(host, opcode);
>
>                 if (!host->tuning_done) {
> -                       pr_info("%s: Tuning timeout, falling back to fixed sampling clock\n",
> -                               mmc_hostname(host->mmc));
> +                       pr_debug("%s: Tuning timeout, falling back to fixed sampling clock\n",
> +                                mmc_hostname(host->mmc));
>                         sdhci_abort_tuning(host, opcode);
>                         return -ETIMEDOUT;
>                 }
> --
> 2.19.2
>