Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191210145657.105808-1-oleksandr@redhat.com>
In-Reply-To: <20191210145657.105808-1-oleksandr@redhat.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Date:   Tue, 10 Dec 2019 16:37:09 +0100
Message-ID: <CAJKOXPfN4r+fi5R0GOyvQnQ6yn7hQvi+cScDD5THqF8X0nOX7w@mail.gmail.com>
Subject: Re: [PATCH RFC] init/Kconfig: enable -O3 for all arches
To:     Oleksandr Natalenko <oleksandr@redhat.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jessica Yu <jeyu@kernel.org>, Tejun Heo <tj@kernel.org>,
        Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
        Joel Fernandes <joel@joelfernandes.org>,
        David Howells <dhowells@redhat.com>,
        Patrick Bellasi <patrick.bellasi@arm.com>,
        Dan Williams <dan.j.williams@intel.com>,
        "Eric W . Biederman" <ebiederm@xmission.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 10 Dec 2019 at 15:57, Oleksandr Natalenko <oleksandr@redhat.com> wrote:
>
> Building a kernel with -O3 may help in hunting bugs like [1] and thus
> using this switch should not be restricted to one specific arch only.
>
> Thus lets expose it. If for some reasone we have to hide it, lets hide
> it under EXPERT.

You are not hiding it under EXPERT so no need to document in commit
log theoretical future decisions.

> The commit is made against next-20191210 tag.

This does not belong to commit message. You can put such under the ---
separator.

Best regards,
Krzysztof

>
> [1] https://lore.kernel.org/lkml/673b885183fb64f1cbb3ed2387524077@natalenko.name/
>
> Signed-off-by: Oleksandr Natalenko <oleksandr@redhat.com>
> ---
>  init/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index a34064a031a5..b41b18edb10e 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1228,7 +1228,6 @@ config CC_OPTIMIZE_FOR_PERFORMANCE
>
>  config CC_OPTIMIZE_FOR_PERFORMANCE_O3
>         bool "Optimize more for performance (-O3)"
> -       depends on ARC
>         imply CC_DISABLE_WARN_MAYBE_UNINITIALIZED  # avoid false positives
>         help
>           Choosing this option will pass "-O3" to your compiler to optimize
> --
> 2.24.0
>