Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 10 Dec 2019 18:06:53 +0100
From:   Andreas Kemnade <andreas@kemnade.info>
To:     Lee Jones <lee.jones@linaro.org>
Cc:     robh+dt@kernel.org, mark.rutland@arm.com, a.zummo@towertech.it,
        alexandre.belloni@bootlin.com, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
        stefan@agner.ch, b.galvani@gmail.com, phh@phh.me,
        letux-kernel@openphoenux.org
Subject: Re: [PATCH v3 2/6] mfd: rn5t618: prepare for irq handling
Message-ID: <20191210173146.6b31e599@kemnade.info>
In-Reply-To: <20191210091351.GS3468@dell>
References: <20191129212045.18325-1-andreas@kemnade.info>
 <20191129212045.18325-3-andreas@kemnade.info>
 <20191210091351.GS3468@dell>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 boundary="Sig_/lcL2C=9LQcpfETqHHrb8+K3"; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_/lcL2C=9LQcpfETqHHrb8+K3
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

accidently send it only to Lee, that was unintended.

On Tue, 10 Dec 2019 09:13:51 +0000
Lee Jones <lee.jones@linaro.org> wrote:

> On Fri, 29 Nov 2019, Andreas Kemnade wrote:
>=20
> > rn5t618 currently lacks irq handling. To prepare implementation =20
>=20
> "RN5T618"
> "IRQ"
>=20
> > in a rn5t618-irq.c, move main file to rn5t618-core.c =20
>=20
> Why do you *need* to call it "core"?
>=20
Well, the pattern is that irq stuff is in a separate file
for other mfds. And when I want to link things together to a rn5t618.[k]o
I think that none objects cannot be called rn5t618.o and so no source
file rn5t618.o. Am I wrong here? Of course if things can live in one file
this thing is not needed.

Regards,
Andreas

> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > ---
> >  drivers/mfd/Makefile                      | 2 ++
> >  drivers/mfd/{rn5t618.c =3D> rn5t618-core.c} | 0
> >  2 files changed, 2 insertions(+)
> >  rename drivers/mfd/{rn5t618.c =3D> rn5t618-core.c} (100%)
> >=20
> > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> > index c1067ea46204..110ea700231b 100644
> > --- a/drivers/mfd/Makefile
> > +++ b/drivers/mfd/Makefile
> > @@ -216,6 +216,8 @@ obj-$(CONFIG_MFD_PALMAS)	+=3D palmas.o
> >  obj-$(CONFIG_MFD_VIPERBOARD)    +=3D viperboard.o
> >  obj-$(CONFIG_MFD_RC5T583)	+=3D rc5t583.o rc5t583-irq.o
> >  obj-$(CONFIG_MFD_RK808)		+=3D rk808.o
> > +
> > +rn5t618-objs			:=3D rn5t618-core.o
> >  obj-$(CONFIG_MFD_RN5T618)	+=3D rn5t618.o
> >  obj-$(CONFIG_MFD_SEC_CORE)	+=3D sec-core.o sec-irq.o
> >  obj-$(CONFIG_MFD_SYSCON)	+=3D syscon.o
> > diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618-core.c
> > similarity index 100%
> > rename from drivers/mfd/rn5t618.c
> > rename to drivers/mfd/rn5t618-core.c =20
>=20
> --=20
> Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF]
> Linaro Services Technical Lead
> Linaro.org =E2=94=82 Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
>=20

--Sig_/lcL2C=9LQcpfETqHHrb8+K3
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEPIWxmAFyOaBcwCpFl4jFM1s/ye8FAl3v0K0ACgkQl4jFM1s/
ye/ilA/+OzgyZOMtqGTMLVIQy3K+s3tkm31ltQ6hT2NILDZsgmCwPUo5IkG+GJdL
9s5LX3lPEB7tP523Vxz+CUk/9+WD59jwtoTaQ3Rz7p0CZfvjQhTPbPPu4SFmDYrp
6VljHW/0sMgGsSQ/IyNFH949Obi2OZNe6n33UWr65MoNxPaMi/aNrzyHWjHIzqVo
jjrYmI0pvzOspPojvFYfxOlHfNJrdtAnOdmp5dT+eckGhRk6cdprGvDEN9sZ6WiK
enR5A6/y+5dRVW3L/ljm53rR2VK74gTNvVNDI+zwwNsgMSFBZwZeKgd8K3cVhNYr
XC8ZtHrP0tPVxChyaDUoTT2ewUMFsp7jCRoFYu4kLYwLfKNo4VNLh+oK+7MWLldb
GYsVMLemK1lISA4gmaZo6DYOL29J4b9yauXgbaPHHbfsMf77QZgOGX+HQGDpZb0f
tyKw8aym6lot/pciMw08ehFPgxJsqOHB6HIbxBLeIFhNkLoG1hHbUpCUcae6x7vQ
Xrb3uOyS3o+Fxcv4Qwf15sJ5T3oAWLUln4LbLtS9JAHDGvpYVKW/0zQydnCJ9fae
mXY3J8AcaR0ktYsAUGCeFs1y4gACSSwGIunximx+mQB5thhA6C89nSkp9BYC7ykU
Sq5n7wEcM+dDgwMD4NQwfaRGh5mDxgWMdvGXsr2TMskmoGF241Y=
=t/ga
-----END PGP SIGNATURE-----

--Sig_/lcL2C=9LQcpfETqHHrb8+K3--