Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 10 Dec 2019 10:57:16 -0800
From:   Paul Burton <paulburton@kernel.org>
To:     Denis Efremov <efremov@linux.com>
Cc:     Ralf Baechle <ralf@linux-mips.org>,
        James Hogan <jhogan@kernel.org>, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: Add KSEG*ADDR definitions to CONFIG_64BIT
Message-ID: <20191210185716.3lkhbuuqtzj2vs3l@lantea.localdomain>
References: <20191210172739.27131-1-efremov@linux.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20191210172739.27131-1-efremov@linux.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Denis,

On Tue, Dec 10, 2019 at 08:27:39PM +0300, Denis Efremov wrote:
> The patch adds KSEG0ADDR, KSEG1ADDR, KSEG2ADDR, KSEG3ADDR
> definitions to CONFIG_64BIT ifdef. This fixes broken compilation:
>   CC      drivers/watchdog/mtx-1_wdt.o
> In file included from drivers/watchdog/mtx-1_wdt.c:44:
> ./arch/mips/include/asm/mach-au1x00/au1000.h: In function ‘alchemy_rdsys’:
> ./arch/mips/include/asm/mach-au1x00/au1000.h:603:36: error: implicit
>   declaration of function ‘KSEG1ADDR’; did you mean ‘CKSEG1ADDR’?
>   [-Werror=implicit-function-declaration]

Since this driver is meant to run on a system that only supports 32 bit
kernels, I think it would be better to correct its dependencies in
Kconfig like so:

diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 58e7c100b6ad..509cbb6d2cea 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -1648,7 +1648,7 @@ config JZ4740_WDT

 config WDT_MTX1
        tristate "MTX-1 Hardware Watchdog"
-       depends on MIPS_MTX1 || (MIPS && COMPILE_TEST)
+       depends on MIPS_MTX1 || (MIPS && 32BIT && COMPILE_TEST)
        help
          Hardware driver for the MTX-1 boards. This is a watchdog timer that
          will reboot the machine after a 100 seconds timer expired.

And mark this with the appropriate fixes tag:

  Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")

What do you think?

Alternatively the driver could just use the existing & equivalent
CKSEG1ADDR() macro as the compiler suggested, but in that case it'd be
good to check that's the only change needed to build cleanly with
CONFIG_64BIT=y.

Thanks,
    Paul