Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190829050237.GA5161@jagdpanzerIV> <CAKywueRd4d_fojGL+n4BisoibhgkYfN9Wyc_+0=-1sarz4-HZw@mail.gmail.com>
 <20190921223847.GB29065@ZenIV.linux.org.uk> <CAKywueSC=MoBB6t2OeUiyc6+GST2Jgg8FTO-kkXif-pn+1k-cw@mail.gmail.com>
 <20191209003413.GY4203@ZenIV.linux.org.uk>
In-Reply-To: <20191209003413.GY4203@ZenIV.linux.org.uk>
From:   Pavel Shilovsky <piastryyy@gmail.com>
Date:   Tue, 10 Dec 2019 11:14:48 -0800
Message-ID: <CAKywueTZWUeN85CMDsmV6kJXmjx3kzgTtpegi_ctLN4bMKZtmA@mail.gmail.com>
Subject: Re: build_path_from_dentry_optional_prefix() may schedule from
 invalid context
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Steve French <stfrench@microsoft.com>,
        Ronnie Sahlberg <lsahlber@redhat.com>,
        linux-cifs <linux-cifs@vger.kernel.org>,
        Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

=D0=B2=D1=81, 8 =D0=B4=D0=B5=D0=BA. 2019 =D0=B3. =D0=B2 16:34, Al Viro <vir=
o@zeniv.linux.org.uk>:
>
> On Mon, Sep 30, 2019 at 10:32:16AM -0700, Pavel Shilovsky wrote:
> > =D1=81=D0=B1, 21 =D1=81=D0=B5=D0=BD=D1=82. 2019 =D0=B3. =D0=B2 15:38, A=
l Viro <viro@zeniv.linux.org.uk>:
>
> > > IOW, kindly lose that nonsense.  More importantly, why bother
> > > with that kmalloc()?  Just __getname() in the very beginning
> > > and __putname() on failure (and for freeing the result afterwards).
> > >
> > > What's more, you are open-coding dentry_path_raw(), badly.
> > > The only differences are
> > >         * use of dirsep instead of '/' and
> > >         * a prefix slapped in the beginning.
> > >
> > > I'm fairly sure that
> > >         char *buf =3D __getname();
> > >         char *s;
> > >
> > >         *to_free =3D NULL;
> > >         if (unlikely(!buf))
> > >                 return NULL;
> > >
> > >         s =3D dentry_path_raw(dentry, buf, PATH_MAX);
> > >         if (IS_ERR(s) || s < buf + prefix_len)
> > >                 __putname(buf);
> > >                 return NULL; // assuming that you don't care about de=
tails
> > >         }
> > >
> > >         if (dirsep !=3D '/') {
> > >                 char *p =3D s;
> > >                 while ((p =3D strchr(p, '/')) !=3D NULL)
> > >                         *p++ =3D dirsep;
> > >         }
> > >
> > >         s -=3D prefix_len;
> > >         memcpy(s, prefix, prefix_len);
> > >
> > >         *to_free =3D buf;
> > >         return s;
> > >
> > > would end up being faster, not to mention much easier to understand.
> > > With the caller expected to pass &to_free among the arguments and
> > > __putname() it once it's done.
> > >
> > > Or just do __getname() in the caller and pass it to the function -
> > > in that case freeing (in all cases) would be up to the caller.
> >
> > Thanks for pointing this out. Someone should look at this closely and
> > clean it up.
>
> Could you take a look through vfs.git#misc.cifs?

Looks good. I would only add the same or a similar comment as
fs/hostfs/hostfs_kern.c has when calling dentry_path_raw():

/*
* This function relies on the fact that dentry_path_raw() will place
* the path name at the end of the provided buffer.
*/

Otherwise it is not straightforward at the first glance how the code works.

Acked-by: Pavel Shilovsky <pshilov@microsoft.com>

--
Best regards,
Pavel Shilovsky