Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Leonard Crestez <leonard.crestez@nxp.com>
To:     Anson Huang <anson.huang@nxp.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 1/3] ARM: dts: imx6ul-14x14-evk: Add sensors' GPIO
 regulator
Thread-Topic: [PATCH 1/3] ARM: dts: imx6ul-14x14-evk: Add sensors' GPIO
 regulator
Thread-Index: AQHVikhFuKo1SLIff0mMLrsG10nb5A==
Date:   Tue, 10 Dec 2019 21:35:05 +0000
Message-ID: <VI1PR04MB7023CD288FCC57806F067FD9EE5B0@VI1PR04MB7023.eurprd04.prod.outlook.com>
References: <1571906920-29966-1-git-send-email-Anson.Huang@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d8575ba3-bd1d-4885-9d1a-08d77db8d259
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2019 21:35:05.1124
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Ga9GvwvObAZ6hv+CV2sJB/a7CeV5zaP19u9ifHgd23xINcUDOMHFw23qMyF1VXuzi9pJ7OrkL0rqNq3DBVn9Vw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3085
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 24.10.2019 11:51, Anson Huang wrote:=0A=
> On i.MX6UL 14x14 EVK board, sensors' power are controlled=0A=
> by GPIO5_IO02, add GPIO regulator for sensors to manage=0A=
> their power.=0A=
> =0A=
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>=0A=
=0A=
For me this breaks network boot on imx6ul evk, relevant log snippet is this=
:=0A=
=0A=
     fec 20b4000.ethernet eth0: Unable to connect to phy=0A=
     IP-Config: Failed to open eth0=0A=
=0A=
Looking at schematics (SPF-28616_C2.pdf) I see that SNVS_TAMPER2 pin is =0A=
connected to PERI_PWREN which controls VPERI_3V3 which is used across =0A=
the board:=0A=
  * Sensors (VSENSOR_3V3)=0A=
  * Ethernet (VENET_3V3)=0A=
  * Bluetooth=0A=
  * CAN=0A=
  * Arduino header=0A=
  * Camera=0A=
=0A=
Maybe there are board revision differences? As far as I can tell this =0A=
regulator is not specific to sensors so it should be always on.=0A=
=0A=
> ---=0A=
>   arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 16 ++++++++++++++++=0A=
>   1 file changed, 16 insertions(+)=0A=
> =0A=
> diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi b/arch/arm/boot/dts/=
imx6ul-14x14-evk.dtsi=0A=
> index c2a9dd5..4074570 100644=0A=
> --- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi=0A=
> +++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi=0A=
> @@ -30,6 +30,16 @@=0A=
>   		enable-active-high;=0A=
>   	};=0A=
>   =0A=
> +	reg_sensors: regulator-sensors {=0A=
> +		compatible =3D "regulator-fixed";=0A=
> +		pinctrl-names =3D "default";=0A=
> +		pinctrl-0 =3D <&pinctrl_sensors_reg>;=0A=
> +		regulator-name =3D "sensors-supply";=0A=
> +		regulator-min-microvolt =3D <3300000>;=0A=
> +		regulator-max-microvolt =3D <3300000>;=0A=
> +		gpio =3D <&gpio5 2 GPIO_ACTIVE_LOW>;=0A=
> +	};=0A=
> +=0A=
>   	reg_can_3v3: regulator-can-3v3 {=0A=
>   		compatible =3D "regulator-fixed";=0A=
>   		regulator-name =3D "can-3v3";=0A=
> @@ -448,6 +458,12 @@=0A=
>   		>;=0A=
>   	};=0A=
>   =0A=
> +	pinctrl_sensors_reg: sensorsreggrp {=0A=
> +		fsl,pins =3D <=0A=
> +			MX6UL_PAD_SNVS_TAMPER2__GPIO5_IO02	0x1b0b0=0A=
> +		>;=0A=
> +	};=0A=
> +=0A=
>   	pinctrl_pwm1: pwm1grp {=0A=
>   		fsl,pins =3D <=0A=
>   			MX6UL_PAD_GPIO1_IO08__PWM1_OUT   0x110b0=0A=
> =0A=
=0A=