Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5956671ybl; Tue, 10 Dec 2019 14:26:02 -0800 (PST) X-Google-Smtp-Source: APXvYqwXApF+RBUjPLq3dzEnKPVnsQApsRDZ32cFMYXxrff+j+MCUovTbenwbuB0X01t+q88DAhK X-Received: by 2002:a54:4407:: with SMTP id k7mr328957oiw.56.1576016762360; Tue, 10 Dec 2019 14:26:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576016762; cv=none; d=google.com; s=arc-20160816; b=N7gjIxY/lpomr+UBFST08whjYSODVHDSMQMGzuEe9G5KWn3tnwH45OFPIK+I2EQ+3V qvRJbaTRuJMweueWnOiLQizh0+ubyDgYLpf0IYZMCoRfEcPPf0bK11te5BpC4ugpB2Ro npuZXUx6vJvztXznfdf7L7MXnmW1++OUOHqZocszdtmOgPPt1Rs8T+01U7tRD0rva3bm CzvpPZztMCUhhkHkh2RouYiUc7/bsvTgzqGMT1TnL38ujlutuXG7E+tEuS2yLEIoCdG5 jV0pZVPd+/w8VLwcHs0VdsIwu2ORWIDsOH4ukR59zAjyHn4p/VdQLKPisCCCbZ/3Sl8A 6zWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=V7NOZM87Hjo3aH85Tq0UMYJwfwxR0GULXsdxgUGpUIg=; b=dTDhhV9YbNt64vR+rkO2iQd+rCO/CNk+KKxF9C/D5swfmHK5PwHklsRX28VZuU1eo4 RXlgyTLPNOmhTKARVKT1/6fo0VAEAoEq8W6g8fA739RvyEPhRnY32khOT29i/gDyDt1L wQs5P5WPhGrrSdVGVHFMaTcrrPbmxDgiURae2Bz/ppIVOGLwpgRPNKiLjrn+VFtxo1H3 NYb8T2U44IbnDQgSrtCewK1Csqafc+vy5KoiGwqlbLlGLBcx+5jMiWyLBX5lXZ8C5pHH HxEqlVmikeAnNwM2Daufkgk5C3qyN8WvnN1k/HPUJ1ZBJJ0yOJrE4IZF25jI1pcgxz6E Qx6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=iS3GKONz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e23si2857478otj.239.2019.12.10.14.25.49; Tue, 10 Dec 2019 14:26:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=iS3GKONz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726879AbfLJWTt (ORCPT + 99 others); Tue, 10 Dec 2019 17:19:49 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:56372 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726608AbfLJWTs (ORCPT ); Tue, 10 Dec 2019 17:19:48 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBAME8aK137834; Tue, 10 Dec 2019 22:19:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=V7NOZM87Hjo3aH85Tq0UMYJwfwxR0GULXsdxgUGpUIg=; b=iS3GKONzKGMUa3EaM0O0NhvcAW/iG7hEk43Pi/ciGvg5J2j6uemEbhNIYdyZcCUV6Gnl IF1zKbNQ+cW9QoyaOp4Bj+Mh3gv87Zdzbi599PzAXTQ5sCuGtrCSm0CqsZkqAJY/dTF4 8T01Nh/C9dbkCkqZBAGZMagCMrkjM+TZ/XLAVw+odnDtoKOOLNdTNElSduSGasvTQTXy +lIHRrXiRwBTOM6/TG4DajAGjnKLetFKXe4JaygKnhbxSN+TQXvyiO030SMahQgViKsO 5GOLZcNtEQL5Fyt+uO+L1TIIc8B8GiNiRsksrHXf6bv+U5SoK2igY+vOMjpy3i2Hh7vT Mw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 2wrw4n5y9p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Dec 2019 22:19:33 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBAMJ8g3075501; Tue, 10 Dec 2019 22:19:33 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 2wte9asq7m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Dec 2019 22:19:29 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xBAMI5ZW018162; Tue, 10 Dec 2019 22:18:05 GMT Received: from ca-dmjordan1.us.oracle.com (/10.211.9.48) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 10 Dec 2019 14:18:04 -0800 Date: Tue, 10 Dec 2019 17:18:14 -0500 From: Daniel Jordan To: David Hildenbrand Cc: Daniel Jordan , linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, Naoya Horiguchi , Pavel Tatashin , Andrew Morton , Steven Sistare , Michal Hocko , Bob Picco , Oscar Salvador Subject: Re: [PATCH v1 1/3] mm: fix uninitialized memmaps on a partially populated last section Message-ID: <20191210221814.bdgd4rw55paowhpv@ca-dmjordan1.us.oracle.com> References: <20191209174836.11063-1-david@redhat.com> <20191209174836.11063-2-david@redhat.com> <20191209211502.zhbvzv2qwbvcperm@ca-dmjordan1.us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9467 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912100183 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9467 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912100183 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 10, 2019 at 11:11:03AM +0100, David Hildenbrand wrote: > Some things that might be relevant from my config. > > # CONFIG_PAGE_POISONING is not set > CONFIG_DEFERRED_STRUCT_PAGE_INIT=y > CONFIG_SPARSEMEM_EXTREME=y > CONFIG_SPARSEMEM_VMEMMAP_ENABLE=y > CONFIG_SPARSEMEM_VMEMMAP=y > CONFIG_HAVE_MEMBLOCK_NODE_MAP=y > CONFIG_MEMORY_HOTPLUG=y > CONFIG_MEMORY_HOTPLUG_SPARSE=y > CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE=y Thanks for all that. After some poking around, turns out enabling DEBUG_VM with its page poisoning let me hit it right away, which makes me wonder how often someone would see this without it. Anyway, fix looks good to me. Tested-by: Daniel Jordan