Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <20191210220523.28540-1-dave@stgolabs.net>
References: <20191210220523.28540-1-dave@stgolabs.net> <20191210193011.GA11802@worktop.programming.kicks-ass.net>
To:     Davidlohr Bueso <dave@stgolabs.net>
Cc:     dhowells@redhat.com, peterz@infradead.org,
        linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, mingo@redhat.com, tglx@linutronix.de,
        will@kernel.org, Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH] Revert "locking/mutex: Complain upon mutex API misuse in IRQ contexts"
MIME-Version: 1.0
Content-ID: <24324.1576017132.1@warthog.procyon.org.uk>
Date:   Tue, 10 Dec 2019 22:32:12 +0000
Message-ID: <24325.1576017132@warthog.procyon.org.uk>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Davidlohr Bueso <dave@stgolabs.net> wrote:

> This ended up causing some noise in places such as rxrpc running in softi=
rq.
>=20
> The warning is misleading in this case as the mutex trylock and unlock
> operations are done within the same context; and therefore we need not
> worry about the PI-boosting issues that comes along with no single-owner
> lock guarantees.
>=20
> While we don't want to support this in mutexes, there is no way out of
> this yet; so lets get rid of the WARNs for now, as it is only fair to
> code that has historically relied on non-preemptible softirq guarantees.
> In addition, changing the lock type is also unviable: exclusive rwsems
> have the same issue (just not the WARN_ON) and counting semaphores
> would introduce a performance hit as mutexes are a lot more optimized.
>=20
> This reverts commit 5d4ebaa87329ef226e74e52c80ac1c62e4948987.
>=20
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>

Tested-by: David Howells <dhowells@redhat.com>