Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Namjae Jeon" <namjae.jeon@samsung.com>
To:     "'Vyacheslav Dubeyko'" <slava@dubeyko.com>
Cc:     <gregkh@linuxfoundation.org>, <valdis.kletnieks@vt.edu>,
        <hch@lst.de>, <sj1557.seo@samsung.com>,
        <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
In-Reply-To: <e234c599ec452ed81fb703c69adf60c1e57062dd.camel@dubeyko.com>
Subject: RE: [PATCH v6 05/13] exfat: add file operations
Date:   Wed, 11 Dec 2019 10:00:50 +0900
Message-ID: <002a01d5afbe$6e64e250$4b2ea6f0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQJ4BHLZ9o05RvmzeddUXNtWjOPDsAGOqq8IAu+ci5ICERQsxqY69XBw
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20191209065149.2230-1-namjae.jeon@samsung.com>
        <CGME20191209065500epcas1p3da26ef7963bbba978ed614bc19b2ea07@epcas1p3.samsung.com>
        <20191209065149.2230-6-namjae.jeon@samsung.com>
        <e234c599ec452ed81fb703c69adf60c1e57062dd.camel@dubeyko.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> > +	/* Of the r and x bits, all (subject to umask) must be
> > present.*/
> > +	if ((perm & 0555) =21=3D (i_mode & 0555))
I modified it due to warnning alarm from checkpatch.pl.
Other octal permissions are same reason.
WARNING: Symbolic permissions 'S_IRUGO =7C S_IXUGO' are not preferred. Cons=
ider using octal permissions '0555'.
+       if ((perm & (S_IRUGO =7C S_IXUGO)) =21=3D (i_mode & (S_IRUGO =7C S_=
IXUGO)))

> > +	/* update the directory entry */
> > +	if (=21evict) =7B
> > +		es =3D exfat_get_dentry_set(sb, &(ei->dir), ei->entry,
> > +				ES_ALL_ENTRIES, &ep);
> > +		if (=21es)
> > +			return -EIO;
> > +		ep2 =3D ep + 1;
>=20
> The ep2 could point out on the garbage here. Maybe, it makes sense to
> add some check here?
Could you please elaborate more? How could ep2 be the garbage?
I want you to check exfat_get_dentry_set().

Thanks for your review=21