Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp57127ybl; Tue, 10 Dec 2019 17:32:08 -0800 (PST) X-Google-Smtp-Source: APXvYqzf2/WLNK/hnVoRhyIFP4O++ROKdpLnK1fFAgRwTYbMPeC42xM1syHMyl2FiHHeT0k42Tn+ X-Received: by 2002:aca:fc02:: with SMTP id a2mr835125oii.38.1576027927917; Tue, 10 Dec 2019 17:32:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576027927; cv=none; d=google.com; s=arc-20160816; b=icI+MeqkCVWQmvQNQAr+ActCvjWp4Ks330XdVHU7TyQDP2mG9OP56ztxcDHBykWA8m my2ZHzbHoVvNinzdaiJnRAB8RRW2pp2FCOYWNvfg41y+LoPeyy9Q6JVwCmMQwSS8K0Rx m2raCeqgLYLhNN0I76dLgYdwjUfJkZMmi3AbPQeI22i7OV5+6XYg3oTEQs2MlEU+fOvp Ke8I3JMXzOTxxZW1PrZ+ilrKCetQIU0RHzK1E8D9MEzC69x1K5/+OSwwsOhXBifLTsJv hVUDAC4c3o9k3IUYL0O4EU0sw2akkYC3EdOXRksVo2qaBeOrEUjy1FrGNOFFCZAjV2Gz /TQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=9W9FU4s+XkpxX8+vpBjIEwCd+3BXy2AcoZVWQymmBso=; b=knFuOWaAybSiwDrK4BiV88k7E8fjCwNRm7o50fBiKkonZF5IYPwJ2rlTlOGnmjtCIG rVyxvAUDvX9hiJcds59lxc33JLKdCeUBShoL/jzOv3T6rc+MgGYKebNAlMr5Mv7B3AWU 806KyyHddQir0/c8mrRVHgJ4QMXFR1NNmq0/uWRp/a9PNrsJge0LkofyItNG9DsoNsFc noe4Zkq3yHnHKMJeLzfFuY8csAmHs5c6XTjDJVmLxD0a2uJiNHKytGY0HC+tagK2J2Fu 3IKWG1YHBr8m9EVEyI24GSYVV12K0x3RpEtPa6NiobdyTiUvP5ULGoSwpKYc0dc58wRa RNhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0PE2HvuI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f190si209812oig.229.2019.12.10.17.31.53; Tue, 10 Dec 2019 17:32:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0PE2HvuI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727352AbfLKBbP (ORCPT + 99 others); Tue, 10 Dec 2019 20:31:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:51770 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727302AbfLKBbP (ORCPT ); Tue, 10 Dec 2019 20:31:15 -0500 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 90C61206D5; Wed, 11 Dec 2019 01:31:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576027875; bh=wnOl6p1K/SUEQXiY8Gpr2seeZ+i631yAH+xs0grtRy0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0PE2HvuI9LIwtOeysXUN1ImbZRJLb/XthDWqd7Fg+5tFfEnUZ5OwJQmAXJFJvLVyl gNqkavvXjrKRMzn98OZgTHmr5M7KYttwI86S5Vc6NrKn6NKm1d6RYBL95gAzwyByiG y3R52W39slW/aKnJDxwbm7FvsvpkxmbtHYFRCMT8= Date: Tue, 10 Dec 2019 17:31:14 -0800 From: Andrew Morton To: Christoph Hellwig Cc: Daniel Axtens , kasan-dev@googlegroups.com, linux-mm@kvack.org, aryabinin@virtuozzo.com, glider@google.com, linux-kernel@vger.kernel.org, dvyukov@google.com, daniel@iogearbox.net, cai@lca.pw Subject: Re: [PATCH 1/3] mm: add apply_to_existing_pages helper Message-Id: <20191210173114.31a6f3e868f94173de76f5cb@linux-foundation.org> In-Reply-To: <20191209073458.GA3852@infradead.org> References: <20191205140407.1874-1-dja@axtens.net> <20191206163853.cdeb5dc80a8622fb6323a8d2@linux-foundation.org> <20191209073458.GA3852@infradead.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 8 Dec 2019 23:34:58 -0800 Christoph Hellwig wrote: > Or a flags argument with descriptive flags to the existing function? > These magic bool arguments don't scale.. True. But it's easy enough to do s/bool create/enum mode/ in the future should the need arise. For now, the code is clearer.