Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp290722ybl; Tue, 10 Dec 2019 23:08:38 -0800 (PST) X-Google-Smtp-Source: APXvYqxGqOnzPaeByK/mRpLyFQ9PzLd+QWtPEp1pvPC7rZY6VNfmMRJUatW0MhW13HmpuTONYNd/ X-Received: by 2002:a9d:7586:: with SMTP id s6mr1209533otk.342.1576048118797; Tue, 10 Dec 2019 23:08:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576048118; cv=none; d=google.com; s=arc-20160816; b=JU208SK/VBECIWXDxS6iYtr1bxiObUX9BPXiZ1rkUsIPc5YZ+0UtEOdI6XoZhP+9wX rBbCUfBXJ1RAGzzFpu2ek0JcLXGWT0+aHbV/t556VdLNAgg6zgruyi1YyPIoxDeOq3sE tH4WRsS6239SgdOD/fksuMIeDK5+pvMb5hYIOL5sg5phmzFD+b646+IZE2KRKF48lL2l 9/jkGtzN0t9h8rrvAg/0YX147YYTbsFv3PouaazxigZ5EvFbIz8D5OhgClwzhyC76d4K ABAzVthCPVMIPKQijfTTpqO9s6h1bDUSScXvRWt3KyLTmnXWmZhhEx8DPnnG7wQHsFZp G5cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=CDVm1y+JR+b9Rlz6X9UKqqmneaLKdZDs0yHAhJR/zZM=; b=hqtnuCjx2Oh6S72QAAkOUwyMlA2MWSfOe0+zILpcDd8mRigDeQGgmn6cGeuTcUb5bi Otu72ViXNHHgxJTagv4d6zWD5JfnHgxZs7L3u0kEe02lwdTx+ttbcsFqS3A3zHSxzxnI QEYpBhscYTf38XE9AMqtgR9PnRhcbbdbMhTUIb8q7cc7PwOybxibHjIPJFOx8U0icjP7 +SgcaJw9RgKIoE/mA8v7+lz3MSGB+siNWaCGncU1Fbzr4ET0SEsFrj9yvqm8A8kAJWbI qoVIRMJwdw+vyqZ1WtUkrfu4WIybyXir1YHMXACMCjvCBTokgIamQMnSCOamF3DgNUBg gkKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=I6qcpZab; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b10si569233otp.124.2019.12.10.23.08.26; Tue, 10 Dec 2019 23:08:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=I6qcpZab; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727960AbfLKHHy (ORCPT + 99 others); Wed, 11 Dec 2019 02:07:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:38316 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725800AbfLKHHx (ORCPT ); Wed, 11 Dec 2019 02:07:53 -0500 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 23CA520836; Wed, 11 Dec 2019 07:07:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576048073; bh=8msHcIRu3PefYDklXS+Yt8ZWDv8UpIyQUU1KePcXvUw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I6qcpZab4oL1uW14v+yRpdRAmH74HJX44/xxYLcSVUaU32XzcNP4JLGJBnNmveSFV MmDkfr/0zyM16WKOx7IBoLVqAnppDSdic4/Gy8TTKhNPvwZhbdT5BHxUZD9xkBq1XH rW0BSLiJ6z5+LOmelSd8ur+Vfj/c7gjpBRnM+27U= Date: Wed, 11 Dec 2019 15:07:40 +0800 From: Shawn Guo To: Peng Fan Cc: "sboyd@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , Abel Vesa , "kernel@pengutronix.de" , dl-linux-imx , Aisheng Dong , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Leonard Crestez , "stable@vger.kernel.org" Subject: Re: [PATCH V2] clk: imx: pll14xx: fix clk_pll14xx_wait_lock Message-ID: <20191211070739.GL15858@dragon> References: <1575879445-15386-1-git-send-email-peng.fan@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1575879445-15386-1-git-send-email-peng.fan@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 09, 2019 at 08:19:55AM +0000, Peng Fan wrote: > From: Peng Fan > > The usage of readl_poll_timeout is wrong, the 3rd parameter(cond) > should be "val & LOCK_STATUS" not "val & LOCK_TIMEOUT_US", > It is not check whether the pll locked, LOCK_STATUS reflects the mask, > not LOCK_TIMEOUT_US. > > Fixes: 8646d4dcc7fb ("clk: imx: Add PLLs driver for imx8mm soc") > Cc: > Reviewed-by: Abel Vesa > Signed-off-by: Peng Fan Applied, thanks.