Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Leonard Crestez <leonard.crestez@nxp.com>
To:     Marco Felsch <m.felsch@pengutronix.de>,
        Anson Huang <anson.huang@nxp.com>
CC:     "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] ARM: dts: imx6ul-14x14-evk: Add sensors' GPIO
 regulator
Thread-Topic: [PATCH 1/3] ARM: dts: imx6ul-14x14-evk: Add sensors' GPIO
 regulator
Thread-Index: AQHVikhFuKo1SLIff0mMLrsG10nb5A==
Date:   Wed, 11 Dec 2019 09:38:13 +0000
Message-ID: <VI1PR04MB7023B082934A79C181DAE7DDEE5A0@VI1PR04MB7023.eurprd04.prod.outlook.com>
References: <1571906920-29966-1-git-send-email-Anson.Huang@nxp.com>
 <VI1PR04MB7023CD288FCC57806F067FD9EE5B0@VI1PR04MB7023.eurprd04.prod.outlook.com>
 <DB3PR0402MB3916D3DB4C0CE0017FC2D4B1F55A0@DB3PR0402MB3916.eurprd04.prod.outlook.com>
 <20191211072721.ze6yn2felxyae5eb@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d8c2ccb-f361-4767-cdd7-08d77e1dd7fa
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2019 09:38:13.7241
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Ux64KqaQ+ej0538RNyQz1pQivll94wLsdzA3NIyvK75WXP4+Ho3Q9dXcbfXrnj3QhvFA4o0TzSuRXJ3XUWA0sA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5311
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2019-12-11 9:27 AM, Marco Felsch wrote:=0A=
> On 19-12-11 01:06, Anson Huang wrote:=0A=
>>> Subject: Re: [PATCH 1/3] ARM: dts: imx6ul-14x14-evk: Add sensors' GPIO=
=0A=
>>> regulator=0A=
>>>=0A=
>>> On 24.10.2019 11:51, Anson Huang wrote:=0A=
>>>> On i.MX6UL 14x14 EVK board, sensors' power are controlled by=0A=
>>>> GPIO5_IO02, add GPIO regulator for sensors to manage their power.=0A=
>>>>=0A=
>>>> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>=0A=
>>>=0A=
>>> For me this breaks network boot on imx6ul evk, relevant log snippet is =
this:=0A=
>>>=0A=
>>>       fec 20b4000.ethernet eth0: Unable to connect to phy=0A=
>>>       IP-Config: Failed to open eth0=0A=
>>>=0A=
>>> Looking at schematics (SPF-28616_C2.pdf) I see that SNVS_TAMPER2 pin is=
=0A=
>>> connected to PERI_PWREN which controls VPERI_3V3 which is used across=
=0A=
>>> the board:=0A=
>>>    * Sensors (VSENSOR_3V3)=0A=
>>>    * Ethernet (VENET_3V3)=0A=
>>>    * Bluetooth=0A=
>>>    * CAN=0A=
>>>    * Arduino header=0A=
>>>    * Camera=0A=
>>>=0A=
>>> Maybe there are board revision differences? As far as I can tell this r=
egulator=0A=
>>> is not specific to sensors so it should be always on.=0A=
>>=0A=
>> You are correct, this regulator controls many other peripherals, I shoul=
d make it always ON for now=0A=
>> to make sure NOT break other peripheral, and after all other peripherals=
 controlled=0A=
>> by this regulator have added this regulator management, then the always =
ON can be=0A=
>> removed.=0A=
> =0A=
> IMHO marking the regulator as always on shouldn't be the fix. Is it to=0A=
> much work to add all required regulators? At least please add a comment=
=0A=
> which describes the need of the always-on property.=0A=
=0A=
I don't have the hardware to test all affected peripherals on hand and =0A=
no familiarity with stuff like CAN.=0A=
=0A=
Renaming reg_sensor and adding a comment makes sense.=0A=
=0A=
--=0A=
Regards,=0A=
Leonard=0A=