Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191209062749.26429-1-vigneshr@ti.com>
In-Reply-To: <20191209062749.26429-1-vigneshr@ti.com>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Wed, 11 Dec 2019 10:47:11 +0100
Message-ID: <CAMpxmJVLZfvh0p0qpcS+V3Cwuv-mi6o-hO5X-JThj-T_0dOCVw@mail.gmail.com>
Subject: Re: [PATCH v2] gpio: pca953x: Don't hardcode irq trigger type
To:     Vignesh Raghavendra <vigneshr@ti.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        linux-gpio <linux-gpio@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Grygorii Strashko <grygorii.strashko@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

pon., 9 gru 2019 o 07:27 Vignesh Raghavendra <vigneshr@ti.com> napisa=C5=82=
(a):
>
> Don't hardcode irq trigger to IRQF_TRIGGER_LOW while registering IRQ
> handler. IRQ/platform core will take care of setting appropriate trigger
> type.
>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
> v2:
> Drop explicit call to irq_get_trigger_type() as this is take care of in c=
ore
> code.
>
>  drivers/gpio/gpio-pca953x.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 6652bee01966..40e48f7d83bb 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -770,8 +770,7 @@ static int pca953x_irq_setup(struct pca953x_chip *chi=
p, int irq_base)
>
>         ret =3D devm_request_threaded_irq(&client->dev, client->irq,
>                                         NULL, pca953x_irq_handler,
> -                                       IRQF_TRIGGER_LOW | IRQF_ONESHOT |
> -                                       IRQF_SHARED,
> +                                       IRQF_ONESHOT | IRQF_SHARED,
>                                         dev_name(&client->dev), chip);
>         if (ret) {
>                 dev_err(&client->dev, "failed to request irq %d\n",
> --
> 2.24.0
>

Patch applied, thanks!

Bartosz