Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Thomas Hellstrom <thellstrom@vmware.com>
To:     Navid Emamdoost <navid.emamdoost@gmail.com>
CC:     "emamd001@umn.edu" <emamd001@umn.edu>,
        "kjlu@umn.edu" <kjlu@umn.edu>,
        "smccaman@umn.edu" <smccaman@umn.edu>,
        Linux-graphics-maintainer <Linux-graphics-maintainer@vmware.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/vmwgfx: prevent memory leak in vmw_context_define
Thread-Topic: [PATCH] drm/vmwgfx: prevent memory leak in vmw_context_define
Thread-Index: AQHVc1w64ObAevD51UiahaDVPzrR7w==
Date:   Wed, 11 Dec 2019 10:20:56 +0000
Message-ID: <MN2PR05MB6141D12006ACDAD96C2F673BA15A0@MN2PR05MB6141.namprd05.prod.outlook.com>
References: <20190925044627.2476-1-navid.emamdoost@gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: vmware.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9fa0db10-a6bd-493d-3f43-08d77e23cfb8
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2019 10:20:56.7949
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6ITpknx2eFMY/Lpr7DSjzr87hNx+6M7elqAvrXIzD7JwWDIhLO4pwOm/z6Tpb4Rqr5sB+FUZUrb6cktXCIBlIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR05MB7071
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/25/19 6:46 AM, Navid Emamdoost wrote:=0A=
> In vmw_context_define if vmw_context_init fails the allocated resource=0A=
> should be unreferenced. The goto label was fixed.=0A=
>=0A=
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>=0A=
> ---=0A=
>  drivers/gpu/drm/vmwgfx/vmwgfx_context.c | 2 +-=0A=
>  1 file changed, 1 insertion(+), 1 deletion(-)=0A=
>=0A=
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_context.c b/drivers/gpu/drm/vm=
wgfx/vmwgfx_context.c=0A=
> index a56c9d802382..ac42f8a6acf0 100644=0A=
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_context.c=0A=
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_context.c=0A=
> @@ -773,7 +773,7 @@ static int vmw_context_define(struct drm_device *dev,=
 void *data,=0A=
>  =0A=
>  	ret =3D vmw_context_init(dev_priv, res, vmw_user_context_free, dx);=0A=
>  	if (unlikely(ret !=3D 0))=0A=
> -		goto out_unlock;=0A=
> +		goto out_err;=0A=
>  =0A=
>  	tmp =3D vmw_resource_reference(&ctx->res);=0A=
>  	ret =3D ttm_base_object_init(tfile, &ctx->base, false, VMW_RES_CONTEXT,=
=0A=
=0A=
This patch doesn't look correct. vmw_context_init should free up all=0A=
resources if failing.=0A=
=0A=
Thanks,=0A=
=0A=
Thomas=0A=
=0A=
=0A=