Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Thomas Hellstrom <thellstrom@vmware.com>
To:     Navid Emamdoost <navid.emamdoost@gmail.com>
CC:     "emamd001@umn.edu" <emamd001@umn.edu>,
        "kjlu@umn.edu" <kjlu@umn.edu>,
        "smccaman@umn.edu" <smccaman@umn.edu>,
        Linux-graphics-maintainer <Linux-graphics-maintainer@vmware.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/vmwgfx: prevent memory leak in vmw_cmdbuf_res_add
Thread-Topic: [PATCH] drm/vmwgfx: prevent memory leak in vmw_cmdbuf_res_add
Thread-Index: AQHVc1sNmr3ysv/LaEaIooNrIvLsMg==
Date:   Wed, 11 Dec 2019 10:19:55 +0000
Message-ID: <MN2PR05MB6141CA532CFFE7A8C519797FA15A0@MN2PR05MB6141.namprd05.prod.outlook.com>
References: <20190925043800.726-1-navid.emamdoost@gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: vmware.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7033cad8-5390-45c7-4c97-08d77e23aae5
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2019 10:19:55.0164
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BGQx+3H7q7hhTU/cLXfYZ+S/TFTlIl6wW0h4oQiBTgsdnrnFb+cQvIKHyQOuD7xk0dZeI5s8VG0sZvTknHBGBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR05MB7071
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/25/19 6:38 AM, Navid Emamdoost wrote:=0A=
> In vmw_cmdbuf_res_add if drm_ht_insert_item fails the allocated memory=0A=
> for cres should be released.=0A=
>=0A=
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>=0A=
> ---=0A=
>  drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c | 4 +++-=0A=
>  1 file changed, 3 insertions(+), 1 deletion(-)=0A=
>=0A=
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c b/drivers/gpu/drm=
/vmwgfx/vmwgfx_cmdbuf_res.c=0A=
> index 4ac55fc2bf97..44d858ce4ce7 100644=0A=
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c=0A=
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c=0A=
> @@ -209,8 +209,10 @@ int vmw_cmdbuf_res_add(struct vmw_cmdbuf_res_manager=
 *man,=0A=
>  =0A=
>  	cres->hash.key =3D user_key | (res_type << 24);=0A=
>  	ret =3D drm_ht_insert_item(&man->resources, &cres->hash);=0A=
> -	if (unlikely(ret !=3D 0))=0A=
> +	if (unlikely(ret !=3D 0)) {=0A=
> +		kfree(cres);=0A=
>  		goto out_invalid_key;=0A=
> +	}=0A=
>  =0A=
>  	cres->state =3D VMW_CMDBUF_RES_ADD;=0A=
>  	cres->res =3D vmw_resource_reference(res);=0A=
=0A=
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>=0A=
=0A=
Will be part of next vmwgfx-next pull.=0A=
=0A=
Thanks,=0A=
=0A=
Thomas=0A=
=0A=
=0A=