Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp630590ybl; Wed, 11 Dec 2019 05:11:21 -0800 (PST) X-Google-Smtp-Source: APXvYqw2dQJRefgXP/Op7wKMugAoncq2cHwU+qmeUgqwrbQZzjhBCeozVo5rCcHL1rvktM5fe0XO X-Received: by 2002:a9d:73c8:: with SMTP id m8mr2317863otk.34.1576069881127; Wed, 11 Dec 2019 05:11:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576069881; cv=none; d=google.com; s=arc-20160816; b=wy2gNCoLdLOgQcdwQql5zblpqVg+iz73SQD9TRM6MXGx5oW59F66YBxeqM13gF8Jz5 RSpT/TSQhHHIa0XQaX2f3lVTNXT+v4KKq10mmb36I+0h8Z5drD1DbPAj05lcmYzG1YKi LcZA2KxrdFEbWqhGnwMJarmaTKCtiG4UPQ+jxd29s9RDALiqQ45OZMCuySpSvKNryFK2 TyyHf3aiWM5lNf5PvaRLpIMDEg1IXpK3Lrj08eWxKPX2E4P9CFmSEcO+r3F6OkHGbL6G 9ga9VprImoiUGxkvnSnjTZ+6cVfKHEdoaoaejFYf+vuFL+MpMF6dkQWPboYE7m7L4gZC fiaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:in-reply-to:mime-version:references :message-id:subject:to:from:date:dkim-signature; bh=E9eYb2Zr4aouyWVOs1ApAsQoZVXyaK3L18xDM6NySAw=; b=zMWlwJe5e+6+pgiFvG5boUB+sDIrJLwCAIfY4xOL1vwBa7fbUv7y7dxvil1ZVpLnGY qRMf5O43zn9OEEoHSrHLCBHC8gZuOjgJtmVYw9i2rdw3u52oniC+DeWD5f9fmoBTiFIU MAieJy/z+PqMdTx8mjg7Xk/t2PJMz9hcWNbCnhrYmXofWrqe8ouYJ/Qxisf7cP7nuwAT m+KGrZ/+FM9bHziEffuJJ/xePtYI6iGEx5ZjMcEZo+6+jpfVEvfbMMuy+ugb8NjCJSgz n9XbBQb7tF47UtHevC+61qToljrfi0EGNqyf2Ermq5hktXHFnRwsfdhFFyZzYST40LbM Af5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=f6O4NzmA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i15si1033194otk.120.2019.12.11.05.11.09; Wed, 11 Dec 2019 05:11:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=f6O4NzmA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729661AbfLKNKU (ORCPT + 99 others); Wed, 11 Dec 2019 08:10:20 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:54830 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729299AbfLKNKN (ORCPT ); Wed, 11 Dec 2019 08:10:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576069811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E9eYb2Zr4aouyWVOs1ApAsQoZVXyaK3L18xDM6NySAw=; b=f6O4NzmAxIK4/hQZf8hkIwGjGWr257VBKD8zEwqZbfFEzhZUTkio8rObGKOqHvBswB9wQh rTMBBS8eOt169pJihe5JlksoJrv19Aj/uUSkOzEmzIMv6HVYk2nLzb5OW3ToCpq6xxI+p2 JvIyi4fbl6NGv1e7yksnMfF14I6f6dU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-88-Q1qPQcIRNgi3tQPSJY7csw-1; Wed, 11 Dec 2019 08:10:08 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6763A800EB5; Wed, 11 Dec 2019 13:10:07 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-67.ams2.redhat.com [10.36.116.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0999960BE2; Wed, 11 Dec 2019 13:10:07 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id F16D716E05; Wed, 11 Dec 2019 14:10:05 +0100 (CET) Date: Wed, 11 Dec 2019 14:10:05 +0100 From: Gerd Hoffmann To: dri-devel@lists.freedesktop.org, tzimmermann@suse.de, gurchetansingh@chromium.org, Maarten Lankhorst , Maxime Ripard , David Airlie , open list Subject: Re: [PATCH v3 1/4] drm: add pgprot callback to drm_gem_object_funcs Message-ID: <20191211131005.ojbnsu3rvorlgnof@sirius.home.kraxel.org> References: <20191211121957.18637-1-kraxel@redhat.com> <20191211121957.18637-2-kraxel@redhat.com> <20191211123835.GZ624164@phenom.ffwll.local> MIME-Version: 1.0 In-Reply-To: <20191211123835.GZ624164@phenom.ffwll.local> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: Q1qPQcIRNgi3tQPSJY7csw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > +=09/** > > +=09 * @pgprot: > > +=09 * > > +=09 * Tweak pgprot as needed, typically used to set cache bits. > > +=09 * > > +=09 * This callback is optional. > > +=09 * > > +=09 * If unset drm_gem_pgprot_wc() will be used. > > +=09 */ > > +=09pgprot_t (*pgprot)(struct drm_gem_object *obj, pgprot_t prot); >=20 > I kinda prefer v1, mostly because this is a huge can of worms, and solvin= g > this properly is going to be real hard (and will necessarily involve > dma-buf and dma-api and probably more). Charging ahead here just risks > that we dig ourselves into a corner. You're v1 is maybe not the most > clean, but just a few code bits here&there should be more flexible and > easier to hack on and experiment around with. Hmm. Second vote for v1. Problem with v1 is that it covers mmap() only, not vmap() ... cheers, Gerd