Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 11 Dec 2019 14:10:05 +0100
From:   Gerd Hoffmann <kraxel@redhat.com>
To:     dri-devel@lists.freedesktop.org, tzimmermann@suse.de,
        gurchetansingh@chromium.org,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        David Airlie <airlied@linux.ie>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/4] drm: add pgprot callback to drm_gem_object_funcs
Message-ID: <20191211131005.ojbnsu3rvorlgnof@sirius.home.kraxel.org>
References: <20191211121957.18637-1-kraxel@redhat.com>
 <20191211121957.18637-2-kraxel@redhat.com>
 <20191211123835.GZ624164@phenom.ffwll.local>
MIME-Version: 1.0
In-Reply-To: <20191211123835.GZ624164@phenom.ffwll.local>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> > +=09/**
> > +=09 * @pgprot:
> > +=09 *
> > +=09 * Tweak pgprot as needed, typically used to set cache bits.
> > +=09 *
> > +=09 * This callback is optional.
> > +=09 *
> > +=09 * If unset drm_gem_pgprot_wc() will be used.
> > +=09 */
> > +=09pgprot_t (*pgprot)(struct drm_gem_object *obj, pgprot_t prot);
>=20
> I kinda prefer v1, mostly because this is a huge can of worms, and solvin=
g
> this properly is going to be real hard (and will necessarily involve
> dma-buf and dma-api and probably more). Charging ahead here just risks
> that we dig ourselves into a corner. You're v1 is maybe not the most
> clean, but just a few code bits here&there should be more flexible and
> easier to hack on and experiment around with.

Hmm.  Second vote for v1.

Problem with v1 is that it covers mmap() only, not vmap() ...

cheers,
  Gerd