Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp708166ybl; Wed, 11 Dec 2019 06:21:17 -0800 (PST) X-Google-Smtp-Source: APXvYqzOq/F3XOG8nkR0zJSRNMOWYzwU1dC6USdeG+yZN4wLO2V51gAJtdT3iGWnloTkevL/uI7T X-Received: by 2002:aca:cf83:: with SMTP id f125mr2869239oig.15.1576074076999; Wed, 11 Dec 2019 06:21:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576074076; cv=none; d=google.com; s=arc-20160816; b=jLPNHneyHmwpu3lVwbw8cOOuzl7jnAmdIQKXDw7Fz4W/Ya+1CutxADgbU4/L5qfoHr lD56e6SlMGR1KV+3Wg6mKl93TOSNBkppe0zOHsUy6K9s1pG47JX1KcxYmW0bACFq1UNg tDXhEQej+UYYvRoosAJfOaM4GyVkwZF2c139p2r9x9kAR7pz2oM0+ILZyXcP25xppspZ xDozCkjlgl2UxMrdRrcIeJrS4zh7hMPw2x+PLGJpfHFXHLJUSv184l0rHGCXWt/gsjSz FZZerhXyaHBjxF44XJ4NQo8WBHW5uOLzXNLupS3lqtBwsUhgpu+RnZtfHm0oJXVUzayC sOkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:message-id:subject:cc:to:from:date :dkim-signature; bh=Ue6epug3gnXB5c/i3J3YWw3g7OXwohZaRD9uQyfIM2Q=; b=jppl+ZdRZ5HPs4Fe2NFCBn0jeR59Rm+WSU/YDFBevd9Fn7s0k1ID6J0ronX9wkJ+zS eDiRoYZBIxZk4fHCxynx7nkfIGQeWY2QyiyP643H8ovVjGMeiIHCh91t2MTjvdSJthZC bS2k7qcQ7WdgNH9us8+9ac3+SVHIVGldjUL1yXpaVhg4J2zmOMVt4gl9pqqM55TGozyb U3aEcZQo1awB1K6/UKbSt2jK7H2HV60Ae1/xoNzHavnsWkgUqYWFjTYNgAZ2Gvp9z8rk 2uAEyfaRdiuTBhGKWO5nmo9++yolMbzzYez1tnU9jTu0fc4FDZpmNBatTjdfAYH6x9BU n3Og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nu8bvQlO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p11si1116422ota.300.2019.12.11.06.21.02; Wed, 11 Dec 2019 06:21:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nu8bvQlO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729791AbfLKOUY (ORCPT + 99 others); Wed, 11 Dec 2019 09:20:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:57762 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbfLKOUY (ORCPT ); Wed, 11 Dec 2019 09:20:24 -0500 Received: from localhost (173-25-83-245.client.mchsi.com [173.25.83.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CAF6D214AF; Wed, 11 Dec 2019 14:20:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576074024; bh=2112vcRvffbbbfNLim0Vo0faBMt99YUI8qgiqHAGLqk=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=nu8bvQlOLmTPRsrn+c+H1hyBH50QH6IXCOetMbMqKW5Y7S5UXeh13ojI5cLmBF6wt cSgcERk+vhQAE5dvLKeKLAt7lHT+zKNjsG/Cizxwdod0woiuW52sQ4dBNq1BjavF1y +6fvpZq9547S28MAHy9ZyEhc1aKFDFu2Ma/pXsfM= Date: Wed, 11 Dec 2019 08:20:22 -0600 From: Bjorn Helgaas To: Dilip Kota Cc: lorenzo.pieralisi@arm.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, andriy.shevchenko@intel.com, gustavo.pimentel@synopsys.com, andrew.murray@arm.com, robh@kernel.org, linux-kernel@vger.kernel.org, cheol.yong.kim@intel.com, chuanhua.lei@linux.intel.com, qi-ming.wu@intel.com Subject: Re: [PATCH v10 2/3] PCI: dwc: intel: PCIe RC controller driver Message-ID: <20191211142022.GA26342@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7f5f0eec-465e-9c21-35ac-b6906119ed5e@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 11, 2019 at 05:59:58PM +0800, Dilip Kota wrote: > > On 12/11/2019 7:49 AM, Bjorn Helgaas wrote: > > On Fri, Dec 06, 2019 at 03:27:49PM +0800, Dilip Kota wrote: > > > Add support to PCIe RC controller on Intel Gateway SoCs. > > > PCIe controller is based of Synopsys DesignWare PCIe core. > > > > > > Intel PCIe driver requires Upconfigure support, Fast Training > > > Sequence and link speed configurations. So adding the respective > > > helper functions in the PCIe DesignWare framework. > > > It also programs hardware autonomous speed during speed > > > configuration so defining it in pci_regs.h. > > > > > > Also, mark Intel PCIe driver depends on MSI IRQ Domain > > > as Synopsys DesignWare framework depends on the > > > PCI_MSI_IRQ_DOMAIN. > > > > > > Signed-off-by: Dilip Kota > > > Signed-off-by: Lorenzo Pieralisi > > > Reviewed-by: Andrew Murray > > > Reviewed-by: Andy Shevchenko > > > Acked-by: Gustavo Pimentel > > > +static void pcie_update_bits(void __iomem *base, u32 ofs, u32 mask, u32 val) > > > +{ > > > + u32 old; > > > + > > > + old = readl(base + ofs); > > > + val = (old & ~mask) | (val & mask); > > > + > > > + if (val != old) > > > + writel(val, base + ofs); > > I assume this is never used on registers where the "old & ~mask" part > > contains RW1C bits? If there are RW1C bits in that part, this will > > corrupt them. > There is no impact because RW1C bits of respective registers are 0s at the > time of this function call. Sounds ... dangerous, but I'll take your word for it. > I see, this patch series is merged in the maintainer tree. > Should i need to submit as a separate patch on top of maintainer tree or > submit the new version of whole patch series? > Please let me know the best practice. Sorry, I didn't realize this had already been merged to Lorenzo's tree. But it's not upstream (in Linus' tree) yet. I don't know how Andrew and Lorenzo want to handle this. None of these are important, so you could just ignore these comments. What I personally would do is rebase the branch, e.g., lpieralisi/pci/dwc, and apply an incremental patch. But it's up to Andrew and Lorenzo whether they want to do anything. Bjorn