Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp775230ybl; Wed, 11 Dec 2019 07:20:19 -0800 (PST) X-Google-Smtp-Source: APXvYqwCR3axTqiCPDTyt8iLldcexOeC0A3I2I+KC8ThZlcJz3FBDY1k+mkOUN8RxnBLxbTBf490 X-Received: by 2002:a9d:6745:: with SMTP id w5mr2509204otm.221.1576077618945; Wed, 11 Dec 2019 07:20:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576077618; cv=none; d=google.com; s=arc-20160816; b=FbaSCb82thai0oOXDqRV1tNgp6D6Oen16lW/ILyi+5Qe993GO5SCif5xCjfAzIw/ei sVOQCtDo7BHoVNsrLZ+nlLZ3ry75IN+ao9hYlUQQZ44h21CGbpBKdFt9nnF+hXWYoz8t JqMlrzETc6zevmn/afOk404+5uiIQaIHexf2jpoQDMh/DCbQEHnsCjyQdeEc6pZeRFa2 x06aqtvlO4cumRqpYj1ra4aqMx5slRj/j/Nsn548ofS4kbHtxGbo3+TQo4th9newydn9 oI5xSiDmsty21EBuKGKDcHhvUeaUZ3wYsa4owTC2BPVWtbiQ6SdJK+z9ipiYXoY+EAI5 w5rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+1eZdBX79VoBP6NMFiQhtf6lyhpMu1WnhoofYGkqGK4=; b=Dlqq9jqEeu3+7vQcCdy+8e7utMLz/F6KFx4mWRhjVyotb0FqmIL40pTK8r3Et46o70 yH9tx+Muzeml8NxyP5jQdOmC8Q/K+j54mvRxHfHnuEA3+6soZkE5Tci4n8KlCr6zu1n6 vdCiX0zReMJLj9dIBiQ2D+PcSJmHm16ZlQ+7KRTyM5KxWi3oX+9oChKzsqDK4HLuOeBq kS8nCieTtdAdbp/KZICKvI4HKM6DC7osopfPYOgN0/NZxqkBwqR3towFfVd8j3soM2sa DhRdULc2R3zFAq5D8uOzu7m0BkdfusQjZBrPCvoIjR8BtIqTZe+GlkgOwnCLwQPf9h9r hjsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=k4e3Qli+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h28si1483623otg.63.2019.12.11.07.20.06; Wed, 11 Dec 2019 07:20:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=k4e3Qli+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732177AbfLKPTI (ORCPT + 99 others); Wed, 11 Dec 2019 10:19:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:47530 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731908AbfLKPTD (ORCPT ); Wed, 11 Dec 2019 10:19:03 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9D24D208C3; Wed, 11 Dec 2019 15:19:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077543; bh=nMiRvwjy9pgZJOq79CVsdSrU7++n8S1+JfDq94pQgRw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=k4e3Qli++3vyoLRf+avBmPS/FYAvg9s3e2vfkF0L92Lf7xK20d9raZg8EJQR++1kx rpclBu8+xX0lpM3oOA4BXmVkUmBGXh9tIY7yNxkQj0GFjn+H38pYpdJ8wm5zWtkyLl rkUVUXO5lIvS9QXVvOytzFyR7CEbfjXcFet5C1Gg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Steve Wise , Jason Gunthorpe , Sasha Levin Subject: [PATCH 4.19 079/243] iw_cxgb4: only reconnect with MPAv1 if the peer aborts Date: Wed, 11 Dec 2019 16:04:01 +0100 Message-Id: <20191211150344.441786407@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191211150339.185439726@linuxfoundation.org> References: <20191211150339.185439726@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Steve Wise [ Upstream commit 9828ca654b52848e7eb7dcc9b0994ff130dd4546 ] Only retry connection setup with MPAv1 if the peer actually aborted the connection upon receiving the MPAv2 start message. This avoids retrying with MPAv1 in the case where the connection was aborted due to retransmit timeouts. Fixes: d2fe99e86bb2 ("RDMA/cxgb4: Add support for MPAv2 Enhanced RDMA Negotiation") Signed-off-by: Steve Wise Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/cxgb4/cm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index a5ff1f0f2073e..4dcc92d116097 100644 --- a/drivers/infiniband/hw/cxgb4/cm.c +++ b/drivers/infiniband/hw/cxgb4/cm.c @@ -2798,7 +2798,8 @@ static int peer_abort(struct c4iw_dev *dev, struct sk_buff *skb) break; case MPA_REQ_SENT: (void)stop_ep_timer(ep); - if (mpa_rev == 1 || (mpa_rev == 2 && ep->tried_with_mpa_v1)) + if (status != CPL_ERR_CONN_RESET || mpa_rev == 1 || + (mpa_rev == 2 && ep->tried_with_mpa_v1)) connect_reply_upcall(ep, -ECONNRESET); else { /* -- 2.20.1