Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp776395ybl; Wed, 11 Dec 2019 07:21:25 -0800 (PST) X-Google-Smtp-Source: APXvYqyBpNglxA49ZqlcgUwTnQlDhrnziTKRvN5Famje/UK2SigSNnxTkV4IbeLhGIvJZWh5zCR9 X-Received: by 2002:aca:c692:: with SMTP id w140mr3276608oif.139.1576077685553; Wed, 11 Dec 2019 07:21:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576077685; cv=none; d=google.com; s=arc-20160816; b=Is5HXUxmAm+aSbhTnqcG3n1Ypya1XghYjKOhV0DCzELat9GkYJi/LFUKKQj0I3ZI/O QRpClQM1+Himq0+s8Bxr1jFh5R76bu8/M1/CyVzJOqEPSIiobt6mSKq+8ei7GwAFE0rA ERl2zmziYRowyc0MWyjulXlq+egrt3XIX3I4BeZkIG1M5dQ97K8YJCLoO4dHyLVIu1ZO l2SRoM1JUTSqWEJX4hzQhDIEqZI0IcaJLqcletMuRlwqp3jeMSWtynLLNVo8hpk5/tku NAHCDhQQKAphUVZOAadB60lbHbkR63djwVP/CkQqGXcHZ7UkxNMxWR/DjEjR7IJ6gMKv TAqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ByjnVnV9+6PBMsd23GrZoCNfyojAELYgnVIRPGJpTTU=; b=z8FqOPqKe7rSQwl2eu3rD7+PF7yn7S+Y9wzcH3S8w5aYLIlJjwm8sMzub+FGvtkoVY KbrszOXlk8+x56ep22s0i1djNIimmEGvZQ1qwEET8+FOdP43ei+ew+LF6DqoM4Gdmruf IrliMpJFT2R9fsA2sdu6WLlHF83n9YztBOLHXWydMDF2AfSs/83X6Q0BYayv3G+5q0pK kExwZi/Jba0kYMHStt+lhvNUKYZVfUjcMLe6ovy3qHb6vfO/DsMHE3ooton9+iTZzsli +aG2xfjdnbgXj0OpYSdOOnZUJ50UwtVBvxo6nLVGqL1rVigZTRi/bbW0d3FWYrLVWhJv Bh+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2XHqMuUn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i12si1353444otk.215.2019.12.11.07.21.13; Wed, 11 Dec 2019 07:21:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2XHqMuUn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731988AbfLKPUJ (ORCPT + 99 others); Wed, 11 Dec 2019 10:20:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:49092 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732297AbfLKPUE (ORCPT ); Wed, 11 Dec 2019 10:20:04 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7F8CB24654; Wed, 11 Dec 2019 15:20:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077604; bh=xZjEc4Xr/AqWgZBND/PK/05kelS3CIMjzvTBe38DF6o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2XHqMuUnkGlDht0eUZRZ07sPNs6pAGEKHMmbCfpIZzYfuGfJ0y3ePqLh82JxrYQzZ h9zhbMdd92rq86t+5jeDnMjgEumE5i6djzFZliXrI7zEgvxkQpxZvFbyU9FO1cnlRO qvxvvUk2dy5Kf9yXdXsvMtchLVtmfRzrjj8MqaZE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Brian Norris , Felipe Balbi , Sasha Levin Subject: [PATCH 4.19 100/243] usb: dwc3: dont log probe deferrals; but do log other error codes Date: Wed, 11 Dec 2019 16:04:22 +0100 Message-Id: <20191211150345.869230770@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191211150339.185439726@linuxfoundation.org> References: <20191211150339.185439726@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Brian Norris [ Upstream commit 408d3ba006af57380fa48858b39f72fde6405031 ] It's not very useful to repeat a bunch of probe deferral errors. And it's also not very useful to log "failed" without telling the error code. Signed-off-by: Brian Norris Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin --- drivers/usb/dwc3/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index aca7e7fa5e47d..f52fcbc5c9718 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -1481,7 +1481,8 @@ static int dwc3_probe(struct platform_device *pdev) ret = dwc3_core_init(dwc); if (ret) { - dev_err(dev, "failed to initialize core\n"); + if (ret != -EPROBE_DEFER) + dev_err(dev, "failed to initialize core: %d\n", ret); goto err4; } -- 2.20.1