Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp779966ybl; Wed, 11 Dec 2019 07:24:30 -0800 (PST) X-Google-Smtp-Source: APXvYqxRIyYYCjQxE6vvKVrvkfh0+IVELQ2G4TF7JL+sxk4X2ztJ66B4s5XyIW0bgC4FEPSh8oqG X-Received: by 2002:a54:4482:: with SMTP id v2mr3063491oiv.0.1576077870258; Wed, 11 Dec 2019 07:24:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576077870; cv=none; d=google.com; s=arc-20160816; b=wcN0oAYOZqYu1epcrZlaq2YNoHg7o4fozWsndqnLLpZC5Je4j1EzRotrgAPcgIYPIN DdyPuEmKK5Gl/o5LJl0uKEv6fEfSGZ1tCIU1Gi/wrlWE47/kLFJXb7zinuRPFDN2cNSK a/T0pvXol0TmCv8DIIFhPLOP9XsnsRCjYNduEbC5vhUEIbArqstHBBSkpMzuvl/AIKou IONsWHdsZom+7F/HBsqw1qBV4saeW0fIgvByeI7Zk9+jQ5hFeDIbcKuNVwrA6PFq6Nfx Ui484JYb9aTZXy1JcAgmBYzDK/oYDGMLtIgXiwnPA+jEkaqHQ3fuHfatop4CngEIYl3w jUxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=PmVEF2g3HvzpthIt3rDfxkxRu4YPCrM0VnFYCngwH/Y=; b=KWXlTjelHHVEcN3nnl8ZwIVFHsWNo/wWUohObMr06mNRQYa9kfk7pX3Kkm4oi60h9i 5r+K6wLU27SsMO1Islek9QQgnlWiNxd1FgxJVYzPySi10snYOUNklNU8VkSh/dgEY8ED IEg/SFsnHRZEZR+piZPm1GHQGpjLLWFNAViXsttoQxCsWt/PQYHZOCJ1Hc/OTFd77/1x vVXNgTAMBtNxVANWSR3GYlYd9UJQfCshbTXvzex2F5BHPvA0R/2F3m2GfSiKiSAC9YQm CVBWq849JPIC9zWjEl+WI4Vapm3nHfJXtNNEEAmeXiUt+L6IbGLnJ1//c8JRQtYJWczf PgFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="OUPB/BFm"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e21si1275119oti.246.2019.12.11.07.24.17; Wed, 11 Dec 2019 07:24:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="OUPB/BFm"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732383AbfLKPWk (ORCPT + 99 others); Wed, 11 Dec 2019 10:22:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:53438 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730932AbfLKPWi (ORCPT ); Wed, 11 Dec 2019 10:22:38 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EDCA32073D; Wed, 11 Dec 2019 15:22:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077758; bh=6WqnEtZcpwKMN0AGFQmDNkvleWZEMRKj16Ms18ORuJE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OUPB/BFmaj87I02qMYj8qb4d/1ysIcAJgFmQb0QjI+WHDVd6ncsBNfIQs4h+NtCt4 GUu9x7azBlDgD7/7zPmwCiLBRr4bkLL4JGqq/T8IjItQDUdhpDGqP5I4CvZQhMrGub +ILG41JVBjIwn34/xIOIliPFZEIOvh6idTvFGg+I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miquel Raynal , Boris Brezillon , Sasha Levin Subject: [PATCH 4.19 160/243] mtd: fix mtd_oobavail() incoherent returned value Date: Wed, 11 Dec 2019 16:05:22 +0100 Message-Id: <20191211150349.965520027@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191211150339.185439726@linuxfoundation.org> References: <20191211150339.185439726@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miquel Raynal [ Upstream commit 4348433d8c0234f44adb6e12112e69343f50f0c5 ] mtd_oobavail() returns either mtd->oovabail or mtd->oobsize. Both values are unsigned 32-bit entities, so there is no reason to pretend returning a signed one. Signed-off-by: Miquel Raynal Signed-off-by: Boris Brezillon Signed-off-by: Sasha Levin --- include/linux/mtd/mtd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h index cd0be91bdefa5..035d641e8847c 100644 --- a/include/linux/mtd/mtd.h +++ b/include/linux/mtd/mtd.h @@ -386,7 +386,7 @@ static inline struct device_node *mtd_get_of_node(struct mtd_info *mtd) return dev_of_node(&mtd->dev); } -static inline int mtd_oobavail(struct mtd_info *mtd, struct mtd_oob_ops *ops) +static inline u32 mtd_oobavail(struct mtd_info *mtd, struct mtd_oob_ops *ops) { return ops->mode == MTD_OPS_AUTO_OOB ? mtd->oobavail : mtd->oobsize; } -- 2.20.1