Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751227AbWAVH15 (ORCPT ); Sun, 22 Jan 2006 02:27:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751228AbWAVH15 (ORCPT ); Sun, 22 Jan 2006 02:27:57 -0500 Received: from mx1.redhat.com ([66.187.233.31]:62341 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1751227AbWAVH14 (ORCPT ); Sun, 22 Jan 2006 02:27:56 -0500 Date: Sat, 21 Jan 2006 23:27:21 -0800 From: Pete Zaitcev To: Guennadi Liakhovetski Cc: gl@dsa-ac.de, linux-kernel@vger.kernel.org, linux-usb-devel@lists.sourceforge.net, marcelo.tosatti@cyclades.com, zaitcev@redhat.com Subject: Re: [PATCH 2.4.32] usb-uhci.c failing "-" Message-Id: <20060121232721.60c09eed.zaitcev@redhat.com> In-Reply-To: References: <20060120151030.433abdf6.zaitcev@redhat.com> Organization: Red Hat, Inc. X-Mailer: Sylpheed version 2.0.4 (GTK+ 2.8.9; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 763 Lines: 17 On Sun, 22 Jan 2006 01:15:23 +0100 (CET), Guennadi Liakhovetski wrote: > i.e., if (!urb->completion) urb->status is not set, so, depending on > whether the urb has ->completion either the old or the new status will be > tested. Is this really correct? And a couple lines above that "goto > recycle;" is superfluous... I would not recommend to get too excercised over uhci-hcd in 2.4.32. I do not with to touch it, because it mostly works, and the risk of regressions is too great. -- Pete - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/