Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp827731ybl; Wed, 11 Dec 2019 08:06:47 -0800 (PST) X-Google-Smtp-Source: APXvYqw6crzNhXyUvL+w5QmPRY9rGlX+jZV25qAraf6/q0V7om8ilnunbOsNLh6ibKfIS1XB8v35 X-Received: by 2002:a05:6830:2110:: with SMTP id i16mr2709367otc.337.1576080406999; Wed, 11 Dec 2019 08:06:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576080406; cv=none; d=google.com; s=arc-20160816; b=tPzJUS6LNRqbnDgwbr9uk0F3XGWQtpzDa6MSsfABQPGPROSeBVBPzgeJrdeKHs8LWO +aPyCsJwoqBOAHy4xLigrKrs2jlGJJZzO2m46FH3noRFIuqQrBXJ7ucrZfE/aO6vVfNv 4e8JNgH6oiro8czHKlrXz343DQ+VwypCvoukxC0ghHWjOjIhW5DjqVMv0ovJ5d/upUX/ j5xvXvokJlBkEb4SiZW9yPNqC5OQJ5ibWsSctxghDQZPT4vNL4yj3QbILboWPVjJGnOr ToUfk20oa0/pim41qDYroS+OrPAv1NEhGioqNX/wPgxiLCzxuSkngiH2+l06Jhn8jxgs bWsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=N5cWSZzk7x5GTo7+iOhpNk7xMxkKcCtHiptyOQvWxrU=; b=AJ0f/aZyl0CiLMify+r/T2ia88bZ6FNETn0mwjU6f6QoSzWKeYveuiwYEei6IhqBPg kOOYN6bk3zspr24r3hH71D1qLzxTRTHTJU6SuzrX1LYwCTM36vRXUkP/VRSL6kBJKrA+ ZtTDpNv74VGnsX0HgSOxxqy7+v3e6UhVtM0uMbignAEsZM523xz6jFRScZEnMZk5IN6J QcrZhymdiCPwiIvTO8v0TQLdguKzyjxUmlVj57u7Ko/pQIpsI6+vfFP2eadS4F5jZFV/ tsxA/FGE9bYBVNE4eWxGjNqnYr+aBBo5JyRk093j6bhKa8nBe6NwkkEmQcQnRqGbL/tm HzJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bccjxDHc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l131si1447926oib.174.2019.12.11.08.06.11; Wed, 11 Dec 2019 08:06:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bccjxDHc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731279AbfLKPM5 (ORCPT + 99 others); Wed, 11 Dec 2019 10:12:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:34712 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731195AbfLKPMj (ORCPT ); Wed, 11 Dec 2019 10:12:39 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 60E6524656; Wed, 11 Dec 2019 15:12:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077158; bh=h+zBRcu+AdqgyaGpfKBX70mO7TzpaplwLhg4eUDP5ks=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bccjxDHca+hglLSshUIct3/WgrH2u08YHs3slyfGTRZaVoLP3HPiH33bsJcWs9w/5 gM7IZ3AgKwJhqSGvgEf3bGYa0Rl9a/bI8EfMkoWmidOOHiDuz8TPNcflVdFmnUN5GA SbApop/hbRp+VACBTs0MTNq+Y9GmOPhLvgVEv9iI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chuhong Yuan , Jens Axboe , Sasha Levin Subject: [PATCH 5.3 037/105] rsxx: add missed destroy_workqueue calls in remove Date: Wed, 11 Dec 2019 16:05:26 +0100 Message-Id: <20191211150234.404623500@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191211150221.153659747@linuxfoundation.org> References: <20191211150221.153659747@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan [ Upstream commit dcb77e4b274b8f13ac6482dfb09160cd2fae9a40 ] The driver misses calling destroy_workqueue in remove like what is done when probe fails. Add the missed calls to fix it. Signed-off-by: Chuhong Yuan Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/block/rsxx/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c index 76b73ddf8fd73..10f6368117d81 100644 --- a/drivers/block/rsxx/core.c +++ b/drivers/block/rsxx/core.c @@ -1000,8 +1000,10 @@ static void rsxx_pci_remove(struct pci_dev *dev) cancel_work_sync(&card->event_work); + destroy_workqueue(card->event_wq); rsxx_destroy_dev(card); rsxx_dma_destroy(card); + destroy_workqueue(card->creg_ctrl.creg_wq); spin_lock_irqsave(&card->irq_lock, flags); rsxx_disable_ier_and_isr(card, CR_INTR_ALL); -- 2.20.1