Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp837926ybl; Wed, 11 Dec 2019 08:15:00 -0800 (PST) X-Google-Smtp-Source: APXvYqzS9Eq5SLHMaWTolVNjs9qJ2myUZjV4IqWR/DmBIzi05xx0IogZNCrk1YWCGnw0CoAqp6YH X-Received: by 2002:aca:2419:: with SMTP id n25mr3445032oic.13.1576080900531; Wed, 11 Dec 2019 08:15:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576080900; cv=none; d=google.com; s=arc-20160816; b=rBe0wpX/Mq6h60SPQbKwVZcEoGmAAILFLFeL7VxcxiNhlh/D6JPaio1GZFyTtDlG1Q Ol4agAixjkFPVPMH5aS2wWbHxVTfDli+R6x63pJ+qcRCo2OHMtGCF7Fx6wg9L1RLPJNg mFhrJkUOj6E85vJRWmgIOAPtE2vtji0zGjpcN4oiHDCvffp8Kd5Yg51wl1YVyRFm+lYY 74tHdluTC0/IvS8OncOycut+skdvl+rnOw1hJjiv486pM7RRIAAG7BPTImeEPG/AglQP 7cPxrOiY4bYwNXnTZ7JW28Xitf+6SdLG3q2Cl7hbzdLY66LzF3B2ROhlnWpOsCceUMIR 8K3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=/PBsGTM2cqWaAnZeV+KwNk07WXG0mVhIlgsu8GQuVz8=; b=1JgCrmrjXSSjGqmPk7N21400dcD8fKTF+JgHsFwcijBjBir2Sy+W2RZhjT2qIKAVwK 2RMyOJRIZz6Hy0mvampKHi0spqAmj8xg//z5Qx1UyrP2DghJd6nQMNe0NtEVjoyor8iK vYDGLye3/Z+akEa6FH7tP7dCe3ONIi2ojZwqgosjgWrpYFAo1JKZrFgu5izapypGDYD/ AoDCrN/cxrCzaVrgrKXJFA1z3slau5pplrMAJvnhuzSeZqKhoFivVxwJjqh5R+2vUtzN g8GTSVz9j5tR7Gt3pChNs0M0k3oO1KsaHbw1DavW1ZQ8EA7+CjG+LaH5yW4UfJ+RAsMJ D+8Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d13si1243390ote.242.2019.12.11.08.14.48; Wed, 11 Dec 2019 08:15:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730679AbfLKQNW (ORCPT + 99 others); Wed, 11 Dec 2019 11:13:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:55724 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730292AbfLKPIO (ORCPT ); Wed, 11 Dec 2019 10:08:14 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4CBBC24679; Wed, 11 Dec 2019 15:08:13 +0000 (UTC) Date: Wed, 11 Dec 2019 10:08:11 -0500 From: Steven Rostedt To: Keita Suzuki Cc: takafumi.kubota1012@sslab.ics.keio.ac.jp, Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] tracing: Avoid memory leak in process_system_preds() Message-ID: <20191211100811.17dc5fbe@gandalf.local.home> In-Reply-To: <20191211091258.11310-1-keitasuzuki.park@sslab.ics.keio.ac.jp> References: <20191211091258.11310-1-keitasuzuki.park@sslab.ics.keio.ac.jp> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Dec 2019 09:12:58 +0000 Keita Suzuki wrote: > --- a/kernel/trace/trace_events_filter.c > +++ b/kernel/trace/trace_events_filter.c > @@ -1662,7 +1662,7 @@ static int process_system_preds(struct trace_subsystem_dir *dir, > parse_error(pe, FILT_ERR_BAD_SUBSYS_FILTER, 0); > return -EINVAL; > fail_mem: > - kfree(filter); > + __free_filter(filter); > /* If any call succeeded, we still need to sync */ > if (!fail) > tracepoint_synchronize_unregister(); Applied. Thanks Keita! -- Steve