Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp845943ybl; Wed, 11 Dec 2019 08:21:55 -0800 (PST) X-Google-Smtp-Source: APXvYqx6JoYE9TRGh/HtxNzz3iKGCaU06aYv+hznFl5MBhph9blBlHs2yT50jv+OmxqmHuYMnwWJ X-Received: by 2002:aca:4e90:: with SMTP id c138mr3487497oib.147.1576081315492; Wed, 11 Dec 2019 08:21:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576081315; cv=none; d=google.com; s=arc-20160816; b=tvaftcv+0UBatuerM1Onh3flok5cC2qwA7z8Yn1ckxrvuD43vWurS+0GWlCqSbrH/e v1AefKXbzwt82cqSU3qrnyNe8VcK8JKb/iiUSRw6HFIYv1AOlulf3EaS7GDM2RHre6bn //1ji16L7zjgFlPqTcB993q87b61ezfswJ86lrJAPC+W+Zzr1T/+d72GIhZjCgRKpwAr GLrho+OvX8rMoMg91ajJmyWMHgtjpkORQqhlLLNBLngIknwueZXwu3C57S1OawiAMNK+ kaC1DAdypYTiizfmO5VxEe7J2xaJuUVHZiThqTfTi5SPcPL0NpNa0Eh08r1Hv8GI6z0Y 0m3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject :dkim-signature; bh=tD2y5jZ8oTLJe6LbTN27zTEPS2JKCut3FdE1zrzBkUs=; b=wBt/vln/VzFL8XvAUo1mJkut7hWidyQszRmGNj0jhkjvzP24+uB7peVDqZGSmwq20r tFverREpGCzn1b5gI1XcSJSIln27a9/vWZDRQY+tWykm6Ihi3/+yHF658zBMoij7cEmr GQC3AC+8TXNazClSnBFjXZ4nACqdiVTNvBV7jUjYb71vWS+JmbFpEc+DXmX2CPFQhfLW fx/mOYXvgfPNNilgtHt14CmezpBsQkGZt1UespfS1ly7xErzmbf7s/r48OlgOt2JWGLY b2l4X5z16+UIPGywh0IQeHrobnToUHegTm4FaCdhOFxG9ci2TLBLyeYr2BskOlgokniM VRyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cogentembedded-com.20150623.gappssmtp.com header.s=20150623 header.b=XHByjpVp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r6si1343322otq.95.2019.12.11.08.21.43; Wed, 11 Dec 2019 08:21:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cogentembedded-com.20150623.gappssmtp.com header.s=20150623 header.b=XHByjpVp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730240AbfLKQU4 (ORCPT + 99 others); Wed, 11 Dec 2019 11:20:56 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:43701 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730036AbfLKQU4 (ORCPT ); Wed, 11 Dec 2019 11:20:56 -0500 Received: by mail-lj1-f195.google.com with SMTP id a13so24729295ljm.10 for ; Wed, 11 Dec 2019 08:20:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tD2y5jZ8oTLJe6LbTN27zTEPS2JKCut3FdE1zrzBkUs=; b=XHByjpVpksAhQp6qWGC8ANRLf3D8pRxjhxA0kZBgeoQGbehbI4T4UsJjHdjOSy3qGm lUR2sJZ7SZ8KAasxNhMFG8wLboHF8Zhuv/dN4u9DCZ5V4ZcQbl9wog+i3wbxinYLhBn9 MWXrZ28CAqcehkq7JynVp3OljN9N9gEfCTpst2pHJdC3HM3jJEPO1gskys5+aLtTz/0D sZ9MGH3g1KvShyB5NXhEXXirzTrpo14gy5QN41m5YeZTKRpCjKTtkOrWf0IA3LPwDp1W +PsL2xzzi6yBkHO+ybkGzuDYvoNZ/nsonXCW4Er4mOvDb5LTfMggKU4Onf4p87/ZLLUS iNDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=tD2y5jZ8oTLJe6LbTN27zTEPS2JKCut3FdE1zrzBkUs=; b=O1FZRKiIivihPqb8/cqY4vqJjCW/2MHT2pMhkYIi908TVSxld7p2GHcIdUlRHmD1uE fLAisgnCQaO6phuVl5n7qzuk3IgzjnD/Z/c2MtygQF6VVAMMhZ8MqCUA1/gwoEOhaTPL cQI5XvDMF243dq41QUbmQbYzK4let804Jdp5EtN/9DjX6ffaUOc5Izzey8QNPLxkKZWZ vt06J6pqUsg+T/wy+/ak5C346yQx3xokoQrz/NaFB44bxdstRx9UgTrfiV+1BYGhoy1r QBACCL+d+lIw1LW+cKwVYlV2ioR5MnK8P8OZcvXvstFfVH7tBlNx/ArLjQ7WEJWPgE0a I1hw== X-Gm-Message-State: APjAAAXQbkYgXTSuWptqmJyYJRkj8vm3Zl+CeDgbCaRDlFMlCiPaxZvk tOEGOXy24jS7MlhSdxO0BYvKQw== X-Received: by 2002:a2e:b017:: with SMTP id y23mr2776840ljk.229.1576081254052; Wed, 11 Dec 2019 08:20:54 -0800 (PST) Received: from wasted.cogentembedded.com ([2a00:1fa0:8d8:12fe:a87e:d4b8:621e:2b62]) by smtp.gmail.com with ESMTPSA id n19sm1434257lfl.85.2019.12.11.08.20.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Dec 2019 08:20:53 -0800 (PST) Subject: Re: [PATCH RFC 0/2] Add Renesas RPC-IF support To: Chris Brandt , Rob Herring , "devicetree@vger.kernel.org" Cc: Mark Rutland , "linux-kernel@vger.kernel.org" , Philipp Zabel , Mason Yang , "linux-spi@vger.kernel.org" References: From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <0af05149-78f5-8639-4a23-84edda0073ea@cogentembedded.com> Date: Wed, 11 Dec 2019 19:20:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/11/2019 05:33 PM, Chris Brandt wrote: >> Here's a set of 2 patches against Linus' repo. Renesas Reduced Pin Count >> Interface (RPC-IF) allows a SPI flash or HyperFlash connected to the SoC to >> be accessed via the external address space read mode or the manual mode. > > Looking at this driver, all it is are APIs. Meaning another driver is > needed to sit in between the MTD layer and this HW driver layer. > > In the driver that I did, if the "RPC" HW is going to be used to control > a SPI Flash device, it registered a spi controller and then the MTD > layer could access the device Via the SPI-to-MTD sublayer for (at least) direct mapping -- grep for "dirmap" in drivers/mtd/spi-nor/spi-nor.c... > just like any other SPI controller driver. No > additional drivers are needed. Then why do we have *struct* spi_controller_mem_ops? Do All drivers implement such ops? [...] MBR, Sergei