Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp873761ybl; Wed, 11 Dec 2019 08:49:22 -0800 (PST) X-Google-Smtp-Source: APXvYqz5q19FvJ+n3EnuIXdWtVU6hnfqoJgR7Oo5DS/57m7w96YQ7p/5JKH1FexNxGFXjyvJKwRf X-Received: by 2002:a05:6830:1185:: with SMTP id u5mr2696448otq.147.1576082962560; Wed, 11 Dec 2019 08:49:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576082962; cv=none; d=google.com; s=arc-20160816; b=p25Tn158wQZPL4tTcnOAnoxRxD3WowT6+4z98DO42ywgB2LKxBzRUlOWXDeez41vNK 7a4xhh42ck8HosFhzo/agQimSGZ4iE5bPr8bZuRhqVi9nOFr4YcIHKNaz3IGFkrmeh6C Im+ePRNBh7NHuX6cmiSxQzzgbZ+6qTjOOINzOSkWfknpdMdtvlTQ9rsTt/A93BlL8e3h I2ObR9x1zr+Q4XsBW2dNsL1WtuRcQ/ts1HiSoQOm+GQUnbYq4qWathu1pjaGNcVuVZks tzotv0osem+CiU1RMMkv3Tc9dwbVB3GA6uD0reGfuT67gObvhnwVgMUSOASxA0YCSu6l NGNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=quwvUgfAal9hpr4TQ4aApSGkXF4hHg8ZIPW4oluX/7I=; b=GYXz5z8Yij48tAbm4T5tRV2rs63W8+/ko3hUbQzSUdP6bswDQCqEeR/YRwFhTmjRBM t6B4aRMcBpFAgeWW6vVLEzss2zrLMHTvtY2ip6uBG9Lip84HXC211Zp2iV1Xl4277hwz 1C4Cjit4KNyv/Ma6/v4nzFWsq4YOpNbuFfP5/p7FxGnGdpPbREpTodyPVpGgeCz5wJOj E8Iq8A+bfGu0EG/VzMckF9d+KdYw+4S/kKHudiCHzLOJdAIUxQaDAV6k7PpOCWXxnG9Z uSpQcxpPmVOAlidAfI+/7D+i4gruDv4IL2AFFQacG8N5MBAWPeupZfLlhfBWGqXCrKKo wa9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=d2KoyMku; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m19si1369023oig.91.2019.12.11.08.49.10; Wed, 11 Dec 2019 08:49:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=d2KoyMku; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730865AbfLKQrQ (ORCPT + 99 others); Wed, 11 Dec 2019 11:47:16 -0500 Received: from linux.microsoft.com ([13.77.154.182]:38724 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727473AbfLKQrP (ORCPT ); Wed, 11 Dec 2019 11:47:15 -0500 Received: from nramas-ThinkStation-P520.corp.microsoft.com (unknown [131.107.174.108]) by linux.microsoft.com (Postfix) with ESMTPSA id CBD4F20B7189; Wed, 11 Dec 2019 08:47:14 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CBD4F20B7189 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1576082834; bh=quwvUgfAal9hpr4TQ4aApSGkXF4hHg8ZIPW4oluX/7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d2KoyMkuK3gM5Em1C19C5Tj5UcPeLCxolLKgz4dWkzoDzRE8KWtZetRzcWXvuWgW6 SFlrW4QaZQG7LdMgttBg8x4z5mb1yvvaONLxfCkJ/N3LAIh5nIEafOa5o6dmG77egF Dxv5hN4m06FfgJQI5TE3ytQLzdM9gAdXqISGTZaI= From: Lakshmi Ramasubramanian To: zohar@linux.ibm.com, linux-integrity@vger.kernel.org Cc: eric.snowberg@oracle.com, dhowells@redhat.com, mathew.j.martineau@linux.intel.com, matthewgarrett@google.com, sashal@kernel.org, jamorris@linux.microsoft.com, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org Subject: [PATCH v11 1/6] IMA: Check IMA policy flag Date: Wed, 11 Dec 2019 08:47:02 -0800 Message-Id: <20191211164707.4698-2-nramas@linux.microsoft.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191211164707.4698-1-nramas@linux.microsoft.com> References: <20191211164707.4698-1-nramas@linux.microsoft.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org process_buffer_measurement() may be called prior to IMA being initialized (for instance, when the IMA hook is called when a key is added to the .builtin_trusted_keys keyring), which would result in a kernel panic. This patch adds the check in process_buffer_measurement() to return immediately if IMA is not initialized yet. Signed-off-by: Lakshmi Ramasubramanian --- security/integrity/ima/ima_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c index d7e987baf127..9b35db2fc777 100644 --- a/security/integrity/ima/ima_main.c +++ b/security/integrity/ima/ima_main.c @@ -655,6 +655,9 @@ void process_buffer_measurement(const void *buf, int size, int action = 0; u32 secid; + if (!ima_policy_flag) + return; + /* * Both LSM hooks and auxilary based buffer measurements are * based on policy. To avoid code duplication, differentiate -- 2.17.1