Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191211163310.4788-1-sj38.park@gmail.com> <3dab421e-6aa5-90e4-791e-53482f5c1fe8@kernel.org>
 <CAEjAshqjjVgtf_JxNvi3WOvkrjOp_-YjK=rY7GE0Mt40Y1EMqQ@mail.gmail.com>
In-Reply-To: <CAEjAshqjjVgtf_JxNvi3WOvkrjOp_-YjK=rY7GE0Mt40Y1EMqQ@mail.gmail.com>
From:   Brendan Higgins <brendanhiggins@google.com>
Date:   Wed, 11 Dec 2019 09:45:07 -0800
Message-ID: <CAFd5g4649_C0tSy3W-KzN05Y8K5zZtGUGVYFA9iAKvaXsPentw@mail.gmail.com>
Subject: Re: [PATCH v5 0/6] Fix nits in the kunit
To:     SeongJae Park <sj38.park@gmail.com>
Cc:     shuah <shuah@kernel.org>, SeongJae Park <sjpark@amazon.com>,
        Jonathan Corbet <corbet@lwn.net>,
        KUnit Development <kunit-dev@googlegroups.com>,
        linux-doc <linux-doc@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>, SeongJae Park <sjpark@amazon.de>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Dec 11, 2019 at 9:40 AM SeongJae Park <sj38.park@gmail.com> wrote:
>
> On Wed, Dec 11, 2019 at 6:22 PM shuah <shuah@kernel.org> wrote:
> >
> > On 12/11/19 9:33 AM, SeongJae Park wrote:
> > > May I ask some comments?
> > >
> > >
> > > Thanks,
> > > SeongJae Park
> > >
> >
> > + Brendan
> >
> > > On Thu, 5 Dec 2019 10:34:34 +0100 SeongJae Park <sjpark@amazon.com> wrote:
> > >
> > >>
> > >> This patchset contains trivial fixes for the kunit documentations and
> > >> the wrapper python scripts.
> > >>
> > >> This patchset is based on 'kselftest/test' branch of linux-kselftest[1]
> > >> and depends on Heidi's patch[2].  A complete tree is available at my repo:
> > >> https://github.com/sjp38/linux/tree/kunit_fix/20191205_v5
> > >>
> > >> Changes from v4
> > >> (https://lore.kernel.org/linux-doc/1575490683-13015-1-git-send-email-sj38.park@gmail.com/):
> > >>   - Rebased on Heidi Fahim's patch[2]
> > >>   - Fix failing kunit_tool_test test
> > >>   - Add 'build_dir' option test in 'kunit_tool_test.py'
> > >>
> >
> > Please include Brendana Higgins on kunit patches.
>
> Not sure how I could forgot adding him.  I will never forget from next time.

No worries. I still got the email from the list :-)

I think I reviewed all the patches in this series; I just need to test
them. I will try to have that done later today or tomorrow.

Cheers!