Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp956735ybl; Wed, 11 Dec 2019 10:07:37 -0800 (PST) X-Google-Smtp-Source: APXvYqxFVW2NXRwrflcacAolIKCmPtKf7sSYI3tyWPJx7hnQx4cvxxKhwkEtIfhuRBnyi8fr+uq3 X-Received: by 2002:a9d:554f:: with SMTP id h15mr3400271oti.338.1576087657771; Wed, 11 Dec 2019 10:07:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576087657; cv=none; d=google.com; s=arc-20160816; b=XsSWdTi1qxvDjyJQ8t+OoHfCx9WpMM6oGInqf/y0UV63tk8bt1y97pBVD5iMaIRdNc UqNukzlb7hfyr19Rqg0OwR37ENtKRqNUTJWA8samZHiuX/h+XS5Vay6cLa3VunkB95jc JwpWyDPvMiSnWAFxEWH5EkdRKkFHjR9CusrY3pfAgB/dnTd5oINFHoCN3NWC9RkyumR7 mbKs6mNdyr7vdHlVw99WI3YV7kOaKnwlBfgeJVY0m+I37CByFY0a4NSbv1ATV5/w3rHn fNBgJvD1os4AOuOj/WVZm5U/qE+dJ9y5PbuilpVJKp1eWFenNB2klExB748fHo06ZEqC 3qZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=SidTrYsF0vWB9wvv03an41xEYqYJUhf3JHqdapOEIwk=; b=0/0+Ixrf4q9okrkv+8/ZZg8HPGkY/qQN8Ay/NbG5KxS/1g54lO4iKoQ7KTl+jOrq22 HJDSvqTcRDk2hzA6ouu7DcPiDzIGlRiM5/uVT7VXFWDW65RIop+9Ox27TNPXRy+DZ7gy 2UYzCZRruIO4sT7R2aygkfinxZu0AFKPhCb9z1KhaLHFMT9DccTrcrkAiofTnxPOoGKh Ovhb/3WBZ1Li+TKZG5CKpqKgy8LCx5kACebuLp4UoTEA3mtmOwh17PcW6oWrqErPRTeV hVsTtx2gPB5RQ5xLQXBeK61OH2eIEVuKhd+cLpDEym0+clgti9Lliuwg+zsKp516DFDF 0Nag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=hqrpbJAs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j16si1533515otp.316.2019.12.11.10.07.23; Wed, 11 Dec 2019 10:07:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=hqrpbJAs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730893AbfLKSGl (ORCPT + 99 others); Wed, 11 Dec 2019 13:06:41 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:44740 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730328AbfLKSGl (ORCPT ); Wed, 11 Dec 2019 13:06:41 -0500 Received: by mail-wr1-f66.google.com with SMTP id q10so25090585wrm.11; Wed, 11 Dec 2019 10:06:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SidTrYsF0vWB9wvv03an41xEYqYJUhf3JHqdapOEIwk=; b=hqrpbJAshp6Vc1bnVOnnvi+Jiio3YbUCKcaEYm12C7LDxOFDZh9gyAAYy3Bm4wJzJx tgNc7NoXw8xMfmTLkdwK+8ZZxZjSYI/qpsennvljI04Niik+rOFlZEOP/4F4xwk8SBfq TQ92ayALVM9nAuHC7ioiw6Od8FmXzOgA/ueCLq0oZnFaxRzbmZ/dpvPyHisIrOGFfbxw JWWPYR2JFQKFOXmrHX6zKCFiRUBmfMqqfpoP1WGsqcD6+SRmb93bjjROidWRZLFPHVoQ jYdZMnqKR2V8QAr5SInQL5I1tKyOfDNvnC2DILWMNpeWQ2ckRt+XHpiSWDrHUv5HaVko gFBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=SidTrYsF0vWB9wvv03an41xEYqYJUhf3JHqdapOEIwk=; b=SZadH1MrYpAnwECFBVyAzzPtbD04k5eAKIFKE6Yxd49GgqmqK9ZqVI8W66Xhb0lSZD +FUKcpmEtYpxMtTNbsDgFD/38wcb+ZOyZWZmGylpLtYwCNLndYwhGxvud1/BZ9E2gYsY 660/r8nTWfAWFZFkR+O0s9lfzkwRviXAGljpCpXEz/+DMtGx19SSDEzcNQSOUE4xbPN2 e5A6qwEXW53ilZp9945BEKGemWIW7JRY67Hlzodv+MVu494rybVrWXhu8bpKLy3mXWLs TRarDhuyQH6Cjb0i8pn1c3Gpwwendt9M+MlEUwEBT//O5c/fif3X4qDvMltK1pVsRc6X 4UOw== X-Gm-Message-State: APjAAAUhtl1Kghd/O4lvqbvkErywXyuo9JWU1dfWcVgzye+VERX4bGls PeViepSCNVbpcFN9uk5lT2U= X-Received: by 2002:a5d:4692:: with SMTP id u18mr1231786wrq.206.1576087597592; Wed, 11 Dec 2019 10:06:37 -0800 (PST) Received: from ziggy.stardust ([37.223.145.31]) by smtp.gmail.com with ESMTPSA id o19sm2422409wmc.18.2019.12.11.10.06.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Dec 2019 10:06:36 -0800 (PST) Subject: Re: [PATCH] [RESEND] arm64: dts: mt8173: Add dynamic power node. To: Michael Kao , Daniel Lezcano Cc: Zhang Rui , Eduardo Valentin , Rob Herring , Mark Rutland , hsinyi@chromium.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Dawei Chien , mn.tsou@mediatek.com References: <20191122090610.17015-1-michael.kao@mediatek.com> <4aaf8cee-eaa2-5de4-37f0-094b9bc8da22@linaro.org> <1576052012.1631.13.camel@mtksdccf07> From: Matthias Brugger Autocrypt: addr=matthias.bgg@gmail.com; prefer-encrypt=mutual; keydata= mQINBFP1zgUBEAC21D6hk7//0kOmsUrE3eZ55kjc9DmFPKIz6l4NggqwQjBNRHIMh04BbCMY fL3eT7ZsYV5nur7zctmJ+vbszoOASXUpfq8M+S5hU2w7sBaVk5rpH9yW8CUWz2+ZpQXPJcFa OhLZuSKB1F5JcvLbETRjNzNU7B3TdS2+zkgQQdEyt7Ij2HXGLJ2w+yG2GuR9/iyCJRf10Okq gTh//XESJZ8S6KlOWbLXRE+yfkKDXQx2Jr1XuVvM3zPqH5FMg8reRVFsQ+vI0b+OlyekT/Xe 0Hwvqkev95GG6x7yseJwI+2ydDH6M5O7fPKFW5mzAdDE2g/K9B4e2tYK6/rA7Fq4cqiAw1+u EgO44+eFgv082xtBez5WNkGn18vtw0LW3ESmKh19u6kEGoi0WZwslCNaGFrS4M7OH+aOJeqK fx5dIv2CEbxc6xnHY7dwkcHikTA4QdbdFeUSuj4YhIZ+0QlDVtS1QEXyvZbZky7ur9rHkZvP ZqlUsLJ2nOqsmahMTIQ8Mgx9SLEShWqD4kOF4zNfPJsgEMB49KbS2o9jxbGB+JKupjNddfxZ HlH1KF8QwCMZEYaTNogrVazuEJzx6JdRpR3sFda/0x5qjTadwIW6Cl9tkqe2h391dOGX1eOA 1ntn9O/39KqSrWNGvm+1raHK+Ev1yPtn0Wxn+0oy1tl67TxUjQARAQABtClNYXR0aGlhcyBC cnVnZ2VyIDxtYXR0aGlhcy5iZ2dAZ21haWwuY29tPokCUgQTAQIAPAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AWIQTmuZIYwPLDJRwsOhfZFAuyVhMC8QUCWt3scQIZAQAKCRDZFAuy VhMC8WzRD/4onkC+gCxG+dvui5SXCJ7bGLCu0xVtiGC673Kz5Aq3heITsERHBV0BqqctOEBy ZozQQe2Hindu9lasOmwfH8+vfTK+2teCgWesoE3g3XKbrOCB4RSrQmXGC3JYx6rcvMlLV/Ch YMRR3qv04BOchnjkGtvm9aZWH52/6XfChyh7XYndTe5F2bqeTjt+kF/ql+xMc4E6pniqIfkv c0wsH4CkBHqoZl9w5e/b9MspTqsU9NszTEOFhy7p2CYw6JEa/vmzR6YDzGs8AihieIXDOfpT DUr0YUlDrwDSrlm/2MjNIPTmSGHH94ScOqu/XmGW/0q1iar/Yr0leomUOeeEzCqQtunqShtE 4Mn2uEixFL+9jiVtMjujr6mphznwpEqObPCZ3IcWqOFEz77rSL+oqFiEA03A2WBDlMm++Sve 9jpkJBLosJRhAYmQ6ey6MFO6Krylw1LXcq5z1XQQavtFRgZoruHZ3XlhT5wcfLJtAqrtfCe0 aQ0kJW+4zj9/So0uxJDAtGuOpDYnmK26dgFN0tAhVuNInEVhtErtLJHeJzFKJzNyQ4GlCaLw jKcwWcqDJcrx9R7LsCu4l2XpKiyxY6fO4O8DnSleVll9NPfAZFZvf8AIy3EQ8BokUsiuUYHz wUo6pclk55PZRaAsHDX/fNr24uC6Eh5oNQ+v4Pax/gtyybkCDQRd1TkHARAAt1BBpmaH+0o+ deSyJotkrpzZZkbSs5ygBniCUGQqXpWqgrc7Uo/qtxOFL91uOsdX1/vsnJO9FyUv3ZNI2Thw NVGCTvCP9E6u4gSSuxEfVyVThCSPvRJHCG2rC+EMAOUMpxokcX9M2b7bBEbcSjeP/E4KTa39 q+JJSeWliaghUfMXXdimT/uxpP5Aa2/D/vcUUGHLelf9TyihHyBohdyNzeEF3v9rq7kdqamZ Ihb+WYrDio/SzqTd1g+wnPJbnu45zkoQrYtBu58n7u8oo+pUummOuTR2b6dcsiB9zJaiVRIg OqL8p3K2fnE8Ewwn6IKHnLTyx5T/r2Z0ikyOeijDumZ0VOPPLTnwmb780Nym3LW1OUMieKtn I3v5GzZyS83NontvsiRd4oPGQDRBT39jAyBr8vDRl/3RpLKuwWBFTs1bYMLu0sYarwowOz8+ Mn+CRFUvRrXxociw5n0P1PgJ7vQey4muCZ4VynH1SeVb3KZ59zcQHksKtpzz2OKhtX8FCeVO mHW9u4x8s/oUVMZCXEq9QrmVhdIvJnBCqq+1bh5UC2Rfjm/vLHwt5hes0HDstbCzLyiA0LTI ADdP77RN2OJbzBkCuWE21YCTLtc8kTQlP+G8m23K5w8k2jleCSKumprCr/5qPyNlkie1HC4E GEAfdfN+uLsFw6qPzSAsmukAEQEAAYkEbAQYAQgAIBYhBOa5khjA8sMlHCw6F9kUC7JWEwLx BQJd1TkHAhsCAkAJENkUC7JWEwLxwXQgBBkBCAAdFiEEUdvKHhzqrUYPB/u8L21+TfbCqH4F Al3VOQcACgkQL21+TfbCqH79RRAAtlb6oAL9y8JM5R1T3v02THFip8OMh7YvEJCnezle9Apq C6Vx26RSQjBV1JwSBv6BpgDBNXarTGCPXcre6KGfX8u1r6hnXAHZNHP7bFGJQiBv5RqGFf45 OhOhbjXCyHc0jrnNjY4M2jTkUC+KIuOzasvggU975nolC8MiaBqfgMB2ab5W+xEiTcNCOg3+ 1SRs5/ZkQ0iyyba2FihSeSw3jTUjPsJBF15xndexoc9jpi0RKuvPiJ191Xa3pzNntIxpsxqc ZkS1HSqPI63/urNezeSejBzW0Xz2Bi/b/5R9Hpxp1AEC3OzabOBATY/1Bmh2eAVK3xpN2Fe1 Zj7HrTgmzBmSefMcSXN0oKQWEI5tHtBbw5XUj0Nw4hMhUtiMfE2HAqcaozsL34sEzi3eethZ IvKnIOTmllsDFMbOBa8oUSoaNg7GzkWSKJ59a9qPJkoj/hJqqeyEXF+WTCUv6FcA8BtBJmVf FppFzLFM/QzF5fgDZmfjc9czjRJHAGHRMMnQlW88iWamjYVye57srNq9pUql6A4lITF7w00B 5PXINFk0lMcNUdkWipu24H6rJhOO6xSP4n6OrCCcGsXsAR5oH3d4TzA9iPYrmfXAXD+hTp82 s+7cEbTsCJ9MMq09/GTCeroTQiqkp50UaR0AvhuPdfjJwVYZfmMS1+5IXA/KY6DbGBAAs5ti AK0ieoZlCv/YxOSMCz10EQWMymD2gghjxojf4iwB2MbGp8UN4+++oKLHz+2j+IL08rd2ioFN YCJBFDVoDRpF/UnrQ8LsH55UZBHuu5XyMkdJzMaHRVQc1rzfluqx+0a/CQ6Cb2q7J2d45nYx 8jMSCsGj1/iU/bKjMBtuh91hsbdWCxMRW0JnGXxcEUklbhA5uGj3W4VYCfTQxwK6JiVt7JYp bX7JdRKIyq3iMDcsTXi7dhhwqsttQRwbBci0UdFGAG4jT5p6u65MMDVTXEgYfZy0674P06qf uSyff73ivwvLR025akzJui8MLU23rWRywXOyTINz8nsPFT4ZSGT1hr5VnIBs/esk/2yFmVoc FAxs1aBO29iHmjJ8D84EJvOcKfh9RKeW8yeBNKXHrcOV4MbMOts9+vpJgBFDnJeLFQPtTHuI kQXT4+yLDvwOVAW9MPLfcHlczq/A/nhGVaG+RKWDfJWNSu/mbhqUQt4J+RFpfx1gmL3yV8NN 7JXABPi5M97PeKdx6qc/c1o3oEHH8iBkWZIYMS9fd6rtAqV3+KH5Ors7tQVtwUIDYEvttmeO ifvpW6U/4au4zBYfvvXagbyXJhG9mZvz+jN1cr0/G2ZC93IbjFFwUmHtXS4ttQ4pbrX6fjTe lq5vmROjiWirpZGm+WA3Vx9QRjqfMdS5Ag0EXdU5SAEQAJu/Jk58uOB8HSGDSuGUB+lOacXC bVOOSywZkq+Ayv+3q/XIabyeaYMwhriNuXHjUxIORQoWHIHzTCqsAgHpJFfSHoM4ulCuOPFt XjqfEHkA0urB6S0jnvJ6ev875lL4Yi6JJO7WQYRs/l7OakJiT13GoOwDIn7hHH/PGUqQoZlA d1n5SVdg6cRd7EqJ+RMNoud7ply6nUSCRMNWbNqbgyWjKsD98CMjHa33SB9WQQSQyFlf+dz+ dpirWENCoY3vvwKJaSpfeqKYuqPVSxnqpKXqqyjNnG9W46OWZp+JV5ejbyUR/2U+vMwbTilL cIUpTgdmxPCA6J0GQjmKNsNKKYgIMn6W4o/LoiO7IgROm1sdn0KbJouCa2QZoQ0+p/7mJXhl tA0XGZhNlI3npD1lLpjdd42lWboU4VeuUp4VNOXIWU/L1NZwEwMIqzFXl4HmRi8MYbHHbpN5 zW+VUrFfeRDPyjrYpax+vWS+l658PPH+sWmhj3VclIoAU1nP33FrsNfp5BiQzao30rwe4ntd eEdPENvGmLfCwiUV2DNVrmJaE3CIUUl1KIRoB5oe7rJeOvf0WuQhWjIU98glXIrh3WYd7vsf jtbEXDoWhVtwZMShMvp7ccPCe2c4YBToIthxpDhoDPUdNwOssHNLD8G4JIBexwi4q7IT9lP6 sVstwvA5ABEBAAGJAjYEGAEIACAWIQTmuZIYwPLDJRwsOhfZFAuyVhMC8QUCXdU5SAIbDAAK CRDZFAuyVhMC8bXXD/4xyfbyPGnRYtR0KFlCgkG2XWeWSR2shSiM1PZGRPxR888zA2WBYHAk 7NpJlFchpaErV6WdFrXQjDAd9YwaEHucfS7SAhxIqdIqzV5vNFrMjwhB1N8MfdUJDpgyX7Zu k/Phd5aoZXNwsCRqaD2OwFZXr81zSXwE2UdPmIfTYTjeVsOAI7GZ7akCsRPK64ni0XfoXue2 XUSrUUTRimTkuMHrTYaHY3544a+GduQQLLA+avseLmjvKHxsU4zna0p0Yb4czwoJj+wSkVGQ NMDbxcY26CMPK204jhRm9RG687qq6691hbiuAtWABeAsl1AS+mdS7aP/4uOM4kFCvXYgIHxP /BoVz9CZTMEVAZVzbRKyYCLUf1wLhcHzugTiONz9fWMBLLskKvq7m1tlr61mNgY9nVwwClMU uE7i1H9r/2/UXLd+pY82zcXhFrfmKuCDmOkB5xPsOMVQJH8I0/lbqfLAqfsxSb/X1VKaP243 jzi+DzD9cvj2K6eD5j5kcKJJQactXqfJvF1Eb+OnxlB1BCLE8D1rNkPO5O742Mq3MgDmq19l +abzEL6QDAAxn9md8KwrA3RtucNh87cHlDXfUBKa7SRvBjTczDg+HEPNk2u3hrz1j3l2rliQ y1UfYx7Vk/TrdwUIJgKS8QAr8Lw9WuvY2hSqL9vEjx8VAkPWNWPwrQ== Message-ID: <8994c4a9-4cf3-5d20-0a89-f1501075d1a7@gmail.com> Date: Wed, 11 Dec 2019 19:06:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <1576052012.1631.13.camel@mtksdccf07> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/12/2019 09:13, Michael Kao wrote: > On Thu, 2019-12-05 at 17:00 +0100, Daniel Lezcano wrote: >> Hi Michael, >> >> >> On 22/11/2019 10:06, michael.kao@mediatek.com wrote: >>> From: "michael.kao" >>> >>> This device node is for calculating dynamic power in mW. >>> Since mt8173 has two clusters, there are two dynamic power >>> coefficient as well. >> >> Are you sure about the values? Usually, Big is ~x4 little, here it is ~x2. > > Hi Daniel, > > I have confirmed again with our IC designer. > The dynamic power coefficients are these value is right. > Designer comment that it is result from different IC implement. Applied to v5.5-next/dts64 Thanks! Matthias >> >>> Signed-off-by: Dawei Chien >>> Signed-off-by: Michael.Kao >>> >>> --- >>> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >>> index 15f1842f6df3..b03ca5a71338 100644 >>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi >>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >>> @@ -157,6 +157,7 @@ >>> enable-method = "psci"; >>> cpu-idle-states = <&CPU_SLEEP_0>; >>> #cooling-cells = <2>; >>> + dynamic-power-coefficient = <263>; >>> clocks = <&infracfg CLK_INFRA_CA53SEL>, >>> <&apmixedsys CLK_APMIXED_MAINPLL>; >>> clock-names = "cpu", "intermediate"; >>> @@ -170,6 +171,7 @@ >>> enable-method = "psci"; >>> cpu-idle-states = <&CPU_SLEEP_0>; >>> #cooling-cells = <2>; >>> + dynamic-power-coefficient = <263>; >>> clocks = <&infracfg CLK_INFRA_CA53SEL>, >>> <&apmixedsys CLK_APMIXED_MAINPLL>; >>> clock-names = "cpu", "intermediate"; >>> @@ -183,6 +185,7 @@ >>> enable-method = "psci"; >>> cpu-idle-states = <&CPU_SLEEP_0>; >>> #cooling-cells = <2>; >>> + dynamic-power-coefficient = <530>; >>> clocks = <&infracfg CLK_INFRA_CA72SEL>, >>> <&apmixedsys CLK_APMIXED_MAINPLL>; >>> clock-names = "cpu", "intermediate"; >>> @@ -196,6 +199,7 @@ >>> enable-method = "psci"; >>> cpu-idle-states = <&CPU_SLEEP_0>; >>> #cooling-cells = <2>; >>> + dynamic-power-coefficient = <530>; >>> clocks = <&infracfg CLK_INFRA_CA72SEL>, >>> <&apmixedsys CLK_APMIXED_MAINPLL>; >>> clock-names = "cpu", "intermediate"; >>> >> >> >