Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1007161ybl; Wed, 11 Dec 2019 10:56:41 -0800 (PST) X-Google-Smtp-Source: APXvYqwVLu8eboMM2PTWqCXBtd2YBNhZpzWVCu2noIjQzPVd7E/J1MLEnBSogWLPHQBKYMo3giv2 X-Received: by 2002:a05:6830:10a:: with SMTP id i10mr3235599otp.365.1576090601404; Wed, 11 Dec 2019 10:56:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576090601; cv=none; d=google.com; s=arc-20160816; b=T/e28eIjbnlmfAV+AEt+lE+xVxbcnMfIkoeL29ue7QOYQTWoMSA7ZQ0mVRwO1WtubR QatYGUpDATU9Jo1ThAIyr5i+kpY6GCzoTLOtWS15oN71O//EiC7YP88n1+XF6BJw4LHX 1oTnsWnbINm4dFlQ/6P9xATakJvZxkclB+dB77BC2jXbtJGAwkg34XpOP5JBnji+pJ7M hf+E5N9df100Kv4QdA0FXYxEIEziuGJVAYfGCxSQhpiULHDqSvCLZ+uAeRxBStPJjfGt ERdNjFhVP26neF73v6+LZpK1G6nx97LcwlQzFbbi7/6x4B0K7Ml0M6x+LRrl37D//5W0 /POQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ufbZHwsY/9nj6K1GH7OdpYuqVG3d27/xnwT9bS0q0U0=; b=cfo7oybpoKz6+5M07xulFOhQy1BI7iJ+FrR2YgVAWRX/ByiP0haq2uQliK95wDWV+S 6ySQxLm6i3k/fjZlTfGOgnokoPPaTtF8fV96LCDnAdErGT+LzHmOgE/yHRDcsjSGeDrn lshlU5xFmMliYALvTX9ohXB+VvfL1g6J8AZIcHO/dQGvSdbWqF0nqyJMRL57oDv2Qyoy B247UxuxF/4GVqHiRLa0J6Oj5zeE943SFdYs9+kAeWxmUhYIKkJYzpvOfP3hJRRemmf1 5mBJfI9NAgLAwJ19nw+AVVDwAPEVD9eqHpipbcgDgxwe/GDZFluXYEsZIDAiCwLFgZT5 Z3tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@duncanthrax.net header.s=dkim header.b=UAJnnhxu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v25si1539268oth.136.2019.12.11.10.56.28; Wed, 11 Dec 2019 10:56:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@duncanthrax.net header.s=dkim header.b=UAJnnhxu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728401AbfLKSyf (ORCPT + 99 others); Wed, 11 Dec 2019 13:54:35 -0500 Received: from shroom.duncanthrax.net ([178.63.180.169]:60783 "EHLO smtp.duncanthrax.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727113AbfLKSyf (ORCPT ); Wed, 11 Dec 2019 13:54:35 -0500 X-Greylist: delayed 2411 seconds by postgrey-1.27 at vger.kernel.org; Wed, 11 Dec 2019 13:54:34 EST DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=duncanthrax.net; s=dkim; h=In-Reply-To:Content-Type:MIME-Version:References :Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ufbZHwsY/9nj6K1GH7OdpYuqVG3d27/xnwT9bS0q0U0=; b=UAJnnhxu18P1B+mCOIIrbJSDHO eIXYMIr0ouG2va7ZlIq/mvnTm5CnUPS1PLOxYPnEvskHa19uvGPatW1CeaFtQlcxexCahExspfNmK d00sgO2mJgkBi3XpuOGPTz1G5860/POBndYi7rbEt1Std8kflVESaVEWgjuqErnvVZxE=; Received: from hsi-kbw-046-005-233-221.hsi8.kabel-badenwuerttemberg.de ([46.5.233.221] helo=t470p.stackframe.org) by smtp.duncanthrax.net with esmtpa (Exim 4.90_1) (envelope-from ) id 1if6VB-0001QM-Ff; Wed, 11 Dec 2019 19:14:21 +0100 Date: Wed, 11 Dec 2019 19:14:21 +0100 From: Sven Schnelle To: Steven Rostedt Cc: linux-trace-devel@vger.kernel.org, LKML , Tom Zanussi Subject: Re: ftrace histogram sorting broken on BE architecures Message-ID: <20191211181421.GA19097@t470p.stackframe.org> References: <20191211123316.GD12147@stackframe.org> <20191211103557.7bed6928@gandalf.local.home> <20191211110959.2baeb70f@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191211110959.2baeb70f@gandalf.local.home> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steven, On Wed, Dec 11, 2019 at 11:09:59AM -0500, Steven Rostedt wrote: > On Wed, 11 Dec 2019 10:35:57 -0500 > Steven Rostedt wrote: > > > > Any thoughts on how to fix this? I'm not sure whether i fully understand the > > > ftrace maps... ;-) > > > > Your analysis makes sense. I'll take a deeper look at it. > > Does this patch fix it for you? Yes, it does. Thanks for looking into this. > Correct me if I'm wrong, from what I can tell, all sums and keys are > u64 unless they are a string. Thus, I believe this patch should not > have any issues. I'll retest if Tom comes up with another patch. Thanks, Sven