Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp69032ybl; Wed, 11 Dec 2019 14:10:20 -0800 (PST) X-Google-Smtp-Source: APXvYqyqYg9AbA5/IIeHeK/Oi8rI1msmptyOMOxA50PceNh4A6VJ+d/Z2ApDVOtOT5ClttlqFXpR X-Received: by 2002:a05:6830:10d7:: with SMTP id z23mr4240157oto.114.1576102220607; Wed, 11 Dec 2019 14:10:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576102220; cv=none; d=google.com; s=arc-20160816; b=CbqMBzz8e0rvDyJ9AzymskZumhnoFZJoQ9ctYir7zDj8wJqaOeC6fQ+hUmV6Pw6AQj 77GoB68bUpGsoy0UdgfZp1R/0iewjsojBXvlU38vTZxulqkeDOlxAhuM5fHqW1UQsM4y PNGF4USp9VqnZUW6MPLuAj/CQh/1Mf97DQdSN8Yt9UqKUBnJLzy0FA+EmL1BP/cNBir5 2p4WwrBQSfcyLM3A2Iy0OPSBUYQJ6o/dxgKBnyfhmVQ8ZTufd4/D0hGUltRhB3BstrH1 6BIpauWCdMAjeJTHKSwSHtbRPChB7QKmyr/ZvauCelwvKTwUQFF/w7wOnKro67kuSvLk 7NTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=k7d7WsbP3LoU75+WuemV9UlLvjwYU63WdP9k7hHQzFM=; b=huJQTzDMAMxUnO9fBcq02QoQ7JgPqiHb3aaZ9S1uEZa0lSo3bN+Ugv0zG/DiFkrssO DUXwodXL5DLvyoGOUZhrTZ9cVZ+IblfxBiMP57VP8/HhmKqMqEIDSfcG5ntb+kcANy/n dwczWL+XgFc6+Ugosg3Z8WJHFGy5uFKqKPMuWLG0c/Lk8VWNl8DHZUCZPiPaA2TN6qN4 71eyR2e6dL6PzbfnYn1VrdFcbOAEplXXJ8N5V/Ngo4ziXt5mDeP3BRGAKHYJIxqWR78q y25iYvVYSzRojHVChRywwEcwd8qLarPo0AorhRN52HCRtybuw51CQH3AZ2izJJ8bhsBI UuUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=S60IcC8q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r6si1958983otq.95.2019.12.11.14.10.05; Wed, 11 Dec 2019 14:10:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=S60IcC8q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726801AbfLKWJX (ORCPT + 99 others); Wed, 11 Dec 2019 17:09:23 -0500 Received: from mail-qt1-f194.google.com ([209.85.160.194]:38302 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726345AbfLKWJW (ORCPT ); Wed, 11 Dec 2019 17:09:22 -0500 Received: by mail-qt1-f194.google.com with SMTP id z15so430412qts.5 for ; Wed, 11 Dec 2019 14:09:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=k7d7WsbP3LoU75+WuemV9UlLvjwYU63WdP9k7hHQzFM=; b=S60IcC8q2ZKHlkDtHhETX2BprZm1KILkOpTxAFaysmnH1ZUe5PKiDzDAbQA0+L2aG5 jGoaV42u5oEaJmjpcsbN+sT+pm6ZJSgih5K4iICnmqQ7Ofcygc/D7shmAAtbrZH8Vanz iz2lsJhsiZjz0UfO25zlNcbayx9quiDGiIur4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k7d7WsbP3LoU75+WuemV9UlLvjwYU63WdP9k7hHQzFM=; b=qm9/8kfyLojcPSJTVGR/ug2vtNQInSOwsHrr0vDarZk6/T9ZMW/1aYgRd2MJyjKzzl E/ubckgBkXfTegPTQaKDvbsBMtL4I6a8PxwFZDMHJjRkMBeQcfT1OsGKaK+gvL57cGD5 KdasAWqkKIYmAf6wq8M3lDbeo+4ZE+fcuypqjDo3JgvknX8INJRy4J/xd+5XOnXrjiya 2R2WcdhmPbHEzecA1bcdsDf4b79JUwuTvrWpSIBZoyeOqJrRrazd+4hkAckNwGY12l0O 97/VDts1hljW9xMFZqP4mMwUZBM9Zm4RiVG/qGcGHKwjWWJNphtn7s+0NiNw2PS+aAD6 jd2w== X-Gm-Message-State: APjAAAXcE/RJqqVD4BtZQsAI0iqjom0NBLMZMemu8ElXrdhdfwJ5AV0w MdNyYFiQxAKwz41xg7xRUrqiK/u+TKxmdpi9Bc5f9w== X-Received: by 2002:ac8:3946:: with SMTP id t6mr4934746qtb.278.1576102161712; Wed, 11 Dec 2019 14:09:21 -0800 (PST) MIME-Version: 1.0 References: <20191121015410.18852-1-bibby.hsieh@mediatek.com> In-Reply-To: <20191121015410.18852-1-bibby.hsieh@mediatek.com> From: Nicolas Boichat Date: Wed, 11 Dec 2019 14:09:10 -0800 Message-ID: Subject: Re: [PATCH v17 0/6] support gce on mt8183 platform To: Bibby Hsieh Cc: Matthias Brugger , Rob Herring , CK HU , devicetree@vger.kernel.org, lkml , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , srv_heupstream , Dennis-YC Hsieh Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthias, Quick question, any reason you picked only patches 2+3+6 from this series, and not the 3 others? Thanks. On Wed, Nov 20, 2019 at 5:54 PM Bibby Hsieh wrote: > > Changes since v16: > - naming the poll mask enable bit > - add a patch to fiup the input order of write api > > Changes since v15: > - rebase onto 5.4-rc1 > - rollback the v14 change > - add a patch to fixup the combination of return value > > Changes since v14: > - change input argument as pointer in append_commend() > > Changes since v13: > - separate poll function as poll w/ & w/o mask function > - directly pass inst into append_command function instead > of returns a pointer > - fixup coding style > - rebase onto 5.3-rc1 > > [... snip ...] > > Bibby Hsieh (6): > soc: mediatek: cmdq: fixup wrong input order of write api > soc: mediatek: cmdq: remove OR opertaion from err return > soc: mediatek: cmdq: define the instruction struct > soc: mediatek: cmdq: add polling function > soc: mediatek: cmdq: add cmdq_dev_get_client_reg function > arm64: dts: add gce node for mt8183 > > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 10 ++ > drivers/soc/mediatek/mtk-cmdq-helper.c | 147 +++++++++++++++++++---- > include/linux/mailbox/mtk-cmdq-mailbox.h | 11 ++ > include/linux/soc/mediatek/mtk-cmdq.h | 53 ++++++++ > 4 files changed, 195 insertions(+), 26 deletions(-) > > -- > 2.18.0