Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp141547ybl; Wed, 11 Dec 2019 15:26:27 -0800 (PST) X-Google-Smtp-Source: APXvYqxLvKSI+90IcD4z1D+orfj9rWAtYubmMGeuyZ3VlojrsuuafANFfNgJ6iHyYslplffLD2O6 X-Received: by 2002:a05:6830:14d5:: with SMTP id t21mr4658401otq.324.1576106787431; Wed, 11 Dec 2019 15:26:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576106787; cv=none; d=google.com; s=arc-20160816; b=seXUzVb4iDtAtcHn0GHF79ciR4kRxRvFxOIorygsPUuSWJDsGIlS8pgIlAkVY2V069 zqBvaZ26Mbcfe71l3Q8zPC4yCDALIDwEVWgXTm3SPR5PTS8RM7TA4qAMa7ghUpY0ChI8 iyOfSfj6SbxKCzbtlCFGbyKtomul5vzvRnFXM9krAHwpNvZvUUc41HjbWQSl1seOHsHM 0I/C7DNcOL83LqydoI1KJu4Zh6lOefNLsoOVn5kPtiw8pCNJ57s5aydZRDobKV0DS6sq +66YmNqfkLtplDvlbWN4NIdJJe8hBjG061YTrw/Er+NYOPlxGWg0WU59WN88Dyp/5OER 7Z9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=B65H/agzDcjgNC5hqDt4i9zRG5ZTYsjrllkhNt7z4Nw=; b=N9zuPAUeGJWRnHIJcpO/eFmLJGwGuqnggrBO+KFIp/XWMGwbtaT9tSLcNW3g++ixmN +hN9L9/DY1Fgj0wzZG8CNqeZtF0gLrEwavLhwsGKlFGddgYBabaZIRVwt4YEU6lRzYwI bLpjfpXATzWxMew0/Gsfp7DIMF6gzZbCGC7wzaqws1gFxfPqBxnyMpGIlue1JANBo1zJ 9N87obNW2ny+XSlSfYsqJVDdbU8DrJlOoNtCN8gx2fQOmETSQeO+drrt5E9lMKKt9iMu pj2agfePfnxcuIn3ehb7rVGQFSIniVwNdYyA7RED4Z+uKe3uVOAXysYCs9WQRITF6zbv FQ6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=R8tBwyGh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w29si2308268oth.313.2019.12.11.15.26.15; Wed, 11 Dec 2019 15:26:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=R8tBwyGh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727085AbfLKXZV (ORCPT + 99 others); Wed, 11 Dec 2019 18:25:21 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:54020 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726589AbfLKXZU (ORCPT ); Wed, 11 Dec 2019 18:25:20 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBBMxSSK116104; Wed, 11 Dec 2019 23:24:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=B65H/agzDcjgNC5hqDt4i9zRG5ZTYsjrllkhNt7z4Nw=; b=R8tBwyGhmO2rEaYvX2LYP6AYc4XsuJErBUT652JfkN+lYcI4ORyC+RdluFwDPG3vCy8N u4SAVOBXoSEOkmJgDUpdC01hq0dLjoe7ygw3QoHS33CdBwT/0c0/h79ioOe8ZOj9MEE6 /rOotgpP8rYsuykjTOfeiqIK2EL/Poj+5TA+692Xbrg5JlU1k3hnX97iGYAAUxfv8UTH 9QQQKlaMFwLToMCjXxMVktslwJ1vq5tgLrIJtGFDqJI/XJdSnYl7qETV5z+63IHkk9b7 0Obt+GcNW4ZYEztzTrtI30kCpgubreb4llzEecyWh+cD7ngUoqhISvfU1NrPWbk9Av/Z jA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2wr4qrqpc3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Dec 2019 23:24:58 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBBMxEZ4078792; Wed, 11 Dec 2019 23:24:58 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2wu3k0298f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Dec 2019 23:24:58 +0000 Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xBBNOuee008494; Wed, 11 Dec 2019 23:24:56 GMT Received: from ca-dmjordan1.us.oracle.com (/10.211.9.48) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 11 Dec 2019 15:24:56 -0800 Date: Wed, 11 Dec 2019 18:25:04 -0500 From: Daniel Jordan To: Hillf Danton Cc: linux-kernel , linux-mm , Tejun Heo , Lai Jiangshan Subject: Re: [RFC 3/4] workqueue: reap dead pool workqueue on queuing work Message-ID: <20191211232504.ih7ms7pwymzeaiym@ca-dmjordan1.us.oracle.com> References: <20191211104601.16468-1-hdanton@sina.com> <20191211112229.22652-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191211112229.22652-1-hdanton@sina.com> User-Agent: NeoMutt/20180716 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9468 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=987 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912110181 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9468 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912110181 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 11, 2019 at 07:22:29PM +0800, Hillf Danton wrote: > Release rcu lock to reap dead pool workqueue. What's to be gained by reaping the pwq (and possibly worker pool and wq) before __queue_work() retries? It'll just happen after the queueing finishes.