Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191211163310.4788-1-sj38.park@gmail.com> <3dab421e-6aa5-90e4-791e-53482f5c1fe8@kernel.org>
 <CAEjAshqjjVgtf_JxNvi3WOvkrjOp_-YjK=rY7GE0Mt40Y1EMqQ@mail.gmail.com>
 <CAFd5g4649_C0tSy3W-KzN05Y8K5zZtGUGVYFA9iAKvaXsPentw@mail.gmail.com> <CAFd5g46X4P7dfJWVw9hdvhVupanuZU-_KWGzostRy_e1Z=P1Og@mail.gmail.com>
In-Reply-To: <CAFd5g46X4P7dfJWVw9hdvhVupanuZU-_KWGzostRy_e1Z=P1Og@mail.gmail.com>
From:   SeongJae Park <sj38.park@gmail.com>
Date:   Thu, 12 Dec 2019 03:12:19 +0100
Message-ID: <CAEjAshpxvhL_h9tVDy9fX7ocs=cc1ihtqE5L39RhJh9CDD8bpw@mail.gmail.com>
Subject: Re: [PATCH v5 0/6] Fix nits in the kunit
To:     Brendan Higgins <brendanhiggins@google.com>
Cc:     shuah <shuah@kernel.org>, SeongJae Park <sjpark@amazon.com>,
        Jonathan Corbet <corbet@lwn.net>,
        KUnit Development <kunit-dev@googlegroups.com>,
        linux-doc <linux-doc@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>, SeongJae Park <sjpark@amazon.de>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Dec 12, 2019 at 3:06 AM Brendan Higgins
<brendanhiggins@google.com> wrote:
>
> On Wed, Dec 11, 2019 at 9:45 AM Brendan Higgins
> <brendanhiggins@google.com> wrote:
> >
> > On Wed, Dec 11, 2019 at 9:40 AM SeongJae Park <sj38.park@gmail.com> wrote:
> > >
> > > On Wed, Dec 11, 2019 at 6:22 PM shuah <shuah@kernel.org> wrote:
> > > >
> > > > On 12/11/19 9:33 AM, SeongJae Park wrote:
> > > > > May I ask some comments?
>
> SeongJae,
>
> I reviewed and tested all your patches. Everything looks good to me
> with one minor caveat: I tried applying your patches on
> kselftest/fixes[1] and got the following error:
>
> error: patch failed: Documentation/dev-tools/kunit/start.rst:21
> error: Documentation/dev-tools/kunit/start.rst: patch does not apply
> Patch failed at 0005 kunit: Rename 'kunitconfig' to '.kunitconfig'
>
> I think the merge conflict is fairly straightforward, but it would
> still probably make Shuah's life easier if you rebased your patches.

Appreciate your nice response, I will rebase it and send the next version!


Thanks,
SeongJae Park

>
> Cheers!
>
> P.S. Thanks for the patch adding the test case for test the build_dir
> thing. I really appreciate that!
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=fixes