Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Thu, 12 Dec 2019 07:17:42 +0000
From:   rkambl@codeaurora.org
To:     Doug Anderson <dianders@chromium.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        sivaa@codeaurora.org, sanm@codeaurora.org,
        Amit Kucheria <amit.kucheria@linaro.org>,
        Matthias Kaehlcke <mka@chromium.org>
Subject: Re: [PATCH v2 1/1] arm64: dts: qcom: sc7180: Add device node support
 for TSENS in SC7180
In-Reply-To: <CAD=FV=UtHebABCpJo1QUc6C2v2iZq2rFL+pTMx=EHBL+7d=jTQ@mail.gmail.com>
References: <1574934847-30372-1-git-send-email-rkambl@codeaurora.org>
 <1574934847-30372-2-git-send-email-rkambl@codeaurora.org>
 <CAD=FV=UtHebABCpJo1QUc6C2v2iZq2rFL+pTMx=EHBL+7d=jTQ@mail.gmail.com>
Message-ID: <0101016ef8f874fd-124cabf9-f93f-4ba1-a04e-e102f0de4d9f-000000@us-west-2.amazonses.com>
User-Agent: Roundcube Webmail/1.3.9
Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2019-12-12 01:03, Doug Anderson wrote:
> Hi,
> 
> On Thu, Nov 28, 2019 at 1:55 AM Rajeshwari <rkambl@codeaurora.org> 
> wrote:
>> 
>> Add TSENS node and user thermal zone for TSENS sensors in SC7180.
>> 
>> Signed-off-by: Rajeshwari <rkambl@codeaurora.org>
>> ---
>>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 527 
>> +++++++++++++++++++++++++++++++++++
>>  1 file changed, 527 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi 
>> b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> index 666e9b9..6656ffc 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> @@ -911,6 +911,26 @@
>>                         status = "disabled";
>>                 };
>> 
>> +               tsens0: thermal-sensor@c263000 {
>> +                       compatible = 
>> "qcom,sc7180-tsens","qcom,tsens-v2";
>> +                       reg = <0 0x0c263000 0 0x1ff>, /* TM */
>> +                               <0 0x0c222000 0 0x1ff>; /* SROT */
>> +                       #qcom,sensors = <15>;
>> +                       interrupts = <GIC_SPI 506 
>> IRQ_TYPE_LEVEL_HIGH>;
>> +                       interrupt-names = "uplow";
> 
> Can you also send a patch to match Amit's ("arm64: dts: sdm845:
> thermal: Add critical interrupt support") [1].  If I'm reading things
> correctly it should be 508 for tsens0 and 509 for tsens1 just like on
> sdm845.
> 
> [1]
> https://lore.kernel.org/r/c536e9cdb448bbad3441f6580fa57f1f921fb580.1573499020.git.amit.kucheria@linaro.org

yes, i will send the patch for critical interrupt support.
> 
> 
> Thanks!
> 
> -Rajeshwari